bind ServerModule

Summary: A basic cython bindings, which makes it possible to install thrift `ServerModule` into `ThriftServer` from Python. This is an easy pre-req for adding `ServiceInterceptor` to `ThriftServer` from Python. See next diff

Reviewed By: prakashgayasen

Differential Revision: D75273370

fbshipit-source-id: e0d7d3347a3cae4814eb00103f6b188e8ce8f782

Author: ahilger

third-party/thrift/src/thrift/lib/py3/server.pxd

@@ -33,6 +33,7 @@ from thrift.python.server_impl.async_processor cimport (
     cAsyncProcessorFactory,
     AsyncProcessorFactory as Py3AsyncProcessorFactory,
 )
+from thrift.python.server_impl.interceptor.server_module cimport cServerModule
 
 
 cdef extern from "thrift/lib/cpp2/server/StatusServerInterface.h" \
@@ -94,6 +95,7 @@ cdef extern from "thrift/lib/cpp2/server/ThriftServer.h" \
         void requireResourcePools() nogil noexcept
         void setTaskExpireTime(milliseconds timeout)
         void setUseClientTimeout(cbool useClientTimeout)
+        void addModule(unique_ptr[cServerModule] module)
 
 cdef extern from "folly/ssl/OpenSSLCertUtils.h" \
         namespace "folly::ssl":

third-party/thrift/src/thrift/lib/py3/server.pyi

@@ -35,6 +35,7 @@ from typing import (
 )
 
 from thrift.py3.common import Headers, Priority
+from thrift.python.server_impl.interceptor.server_module import PythonServerModule
 from thrift.python.types import ServiceInterface as PythonServiceInterface
 
 # pyre-ignore[33]: the callable can be any function
@@ -127,6 +128,7 @@ class ThriftServer:
     def is_resource_pool_enabled(self) -> bool: ...
     def set_task_expire_time(self, seconds: float) -> None: ...
     def set_use_client_timeout(self, use_client_timeout: bool) -> None: ...
+    def add_server_module(self, module: PythonServerModule) -> None: ...
 
 class ReadHeaders(Headers): ...
 class WriteHeaders(Headers): ...

third-party/thrift/src/thrift/lib/py3/server.pyx

@@ -52,6 +52,7 @@ from thrift.python.server_impl.request_context import ( # noqa
     get_context,
 )
 from thrift.python.server_impl.request_context cimport handleAddressCallback
+from thrift.python.server_impl.interceptor.server_module cimport PythonServerModule
 
 AsyncProcessorFactory = AsyncProcessorFactory_
 
@@ -292,6 +293,13 @@ cdef class ThriftServer:
     def set_use_client_timeout(self, cbool use_client_timeout):
         self.server.get().setUseClientTimeout(use_client_timeout)
 
+    def add_server_module(self, PythonServerModule module): 
+        # this is a dumb hack around cython not understanding that 
+        # unique_ptr[Base] = unique_ptr[Derived] is valid and safe
+        self.server.get().addModule(
+            unique_ptr[[cServerModule]](module._cpp_module.release())
+        )
+
     @property
     def handler(self):
         if self.handler is not None:

third-party/thrift/src/thrift/lib/python/server/interceptor/PythonServerModule.h

@@ -0,0 +1,44 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <thrift/lib/cpp2/server/ServerModule.h>
+
+namespace apache::thrift::python {
+
+class PythonServerModule : public apache::thrift::ServerModule {
+ public:
+  explicit PythonServerModule(std::string name) : name_(std::move(name)) {}
+
+  std::string getName() const override { return name_; }
+
+  std::vector<std::shared_ptr<apache::thrift::ServiceInterceptorBase>>
+  getServiceInterceptors() override {
+    return interceptors_;
+  }
+
+  void addServiceInterceptor(
+      std::shared_ptr<apache::thrift::ServiceInterceptorBase> interceptor) {
+    interceptors_.push_back(std::move(interceptor));
+  }
+
+ private:
+  std::string name_;
+  std::vector<std::shared_ptr<apache::thrift::ServiceInterceptorBase>>
+      interceptors_;
+};
+} // namespace apache::thrift::python

third-party/thrift/src/thrift/lib/python/server/interceptor/server_module.pxd

@@ -0,0 +1,38 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+from libcpp.string cimport string
+from libcpp.vector cimport vector
+from libcpp.memory cimport shared_ptr, unique_ptr
+
+
+cdef extern from "thrift/lib/cpp2/server/ServiceInterceptorBase.h" namespace "apache::thrift":
+    cdef cppclass ServiceInterceptorBase:
+        pass
+
+cdef extern from "thrift/lib/cpp2/server/ServerModule.h" namespace "apache::thrift":
+    cdef cppclass cServerModule "apache::thrift::ServerModule":
+        ServerModule() except +
+        string getName() const
+        vector[shared_ptr[ServiceInterceptorBase]] getServiceInterceptors()
+
+cdef extern from "thrift/lib/python/server/interceptor/PythonServerModule.h":
+    cdef cppclass cPythonServerModule "apache::thrift::python::PythonServerModule"(cServerModule):
+        PythonServerModule(string name)
+        void addServiceInterceptor(shared_ptr[ServiceInterceptorBase])
+
+
+cdef class PythonServerModule:
+    cdef unique_ptr[cPythonServerModule] _cpp_module

third-party/thrift/src/thrift/lib/python/server/interceptor/server_module.pyi

@@ -0,0 +1,17 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+class PythonServerModule:
+    def __init__(self, name: str) -> None: ...
+    def add_service_interceptor(self, interceptor) -> None: ...

third-party/thrift/src/thrift/lib/python/server/interceptor/server_module.pyx

@@ -0,0 +1,27 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from libcpp.memory cimport make_unique
+from libcpp.string cimport string
+from libcpp.utility cimport move as cmove
+
+
+
+cdef class PythonServerModule: 
+    def __init__(self, str name):
+        self._cpp_module = make_unique[cPythonServerModule](<string>name.encode("utf-8"))
+
+    def add_service_interceptor(self, interceptor):
+        # impl added next diff
+        pass

third-party/thrift/src/thrift/lib/python/server/server.pyx

@@ -34,3 +34,4 @@ from thrift.python.server_impl.python_async_processor import (
     PythonUserException,
     RpcKind,
 )
+from thrift.python.server_impl.interceptor.server_module import PythonServerModule