From a15aff602255d7a59791abf1308e307cc222ee13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Szab=C3=B3?= Date: Mon, 16 Jun 2025 03:20:01 +0200 Subject: [PATCH] Fix trivial OSS test failures Address some straightforward test failures in HHVM OSS: * Gate tests for internal Meta extensions behind appropriate runif checks. * Set -vPHP7.EngineExceptions=false for some tests that assume this, as this knob defaults to false in internal builds but to true in OSS. * Skip tests that exercise fb_(un)serialize() outside internal builds, since FBSerialize was removed from HHVM OSS in D46525242. --- hphp/test/slow/checked_unsafe_cast/config.opts | 1 + hphp/test/slow/class-ptr/class-serde.php.skipif | 6 ++++++ hphp/test/slow/dict/fb_serialize.php.skipif | 8 ++++++++ hphp/test/slow/dv_array_hack_arr/fb_serialize.php.skipif | 8 ++++++++ .../test/slow/dv_array_hack_arr/fb_serialize_2.php.skipif | 8 ++++++++ hphp/test/slow/eden/config.runif | 1 + hphp/test/slow/ext_configerator/config.runif | 1 + hphp/test/slow/ext_fb/compact_serialize.php.skipif | 8 ++++++++ .../ext_fb/fb_serialize_hack_array_notices.php.skipif | 8 ++++++++ hphp/test/slow/ext_fb/migratory_serialize.php.skipif | 8 ++++++++ hphp/test/slow/ext_fb/serialize.php.skipif | 8 ++++++++ hphp/test/slow/ext_fb/serialize_post_ham.php.skipif | 8 ++++++++ hphp/test/slow/ext_fb/unserialize_max_depth.php.skipif | 8 ++++++++ hphp/test/slow/func-ptr-no-interop/func-serde.php.skipif | 6 ++++++ hphp/test/slow/hack_arr_compat/fb_unserialize.php.skipif | 8 ++++++++ .../legacy_serialize/fb_compact_serialize.php.skipif | 8 ++++++++ .../slow/hack_arr_compat/serialization-notices.php.skipif | 8 ++++++++ .../memo-agnostic-ic-all-types.php.skipif | 7 +++++++ hphp/test/slow/keyset/fb_serialize.php.skipif | 6 ++++++ hphp/test/slow/meth-caller-serialize-native.php.skipif | 6 ++++++ hphp/test/slow/meth-caller-serialize-throw.php.skipif | 6 ++++++ hphp/test/slow/meth-caller-serialize.php.skipif | 6 ++++++ hphp/test/slow/static-analysis-error.php.expectf | 2 +- hphp/test/slow/typed_locals/config.opts | 1 + hphp/test/slow/vec/fb_serialize.php.skipif | 6 ++++++ hphp/test/slow/vle/config.runif | 1 + 26 files changed, 151 insertions(+), 1 deletion(-) create mode 100644 hphp/test/slow/checked_unsafe_cast/config.opts create mode 100644 hphp/test/slow/class-ptr/class-serde.php.skipif create mode 100644 hphp/test/slow/dict/fb_serialize.php.skipif create mode 100644 hphp/test/slow/dv_array_hack_arr/fb_serialize.php.skipif create mode 100644 hphp/test/slow/dv_array_hack_arr/fb_serialize_2.php.skipif create mode 100644 hphp/test/slow/eden/config.runif create mode 100644 hphp/test/slow/ext_configerator/config.runif create mode 100644 hphp/test/slow/ext_fb/compact_serialize.php.skipif create mode 100644 hphp/test/slow/ext_fb/fb_serialize_hack_array_notices.php.skipif create mode 100644 hphp/test/slow/ext_fb/migratory_serialize.php.skipif create mode 100644 hphp/test/slow/ext_fb/serialize.php.skipif create mode 100644 hphp/test/slow/ext_fb/serialize_post_ham.php.skipif create mode 100644 hphp/test/slow/ext_fb/unserialize_max_depth.php.skipif create mode 100644 hphp/test/slow/func-ptr-no-interop/func-serde.php.skipif create mode 100644 hphp/test/slow/hack_arr_compat/fb_unserialize.php.skipif create mode 100644 hphp/test/slow/hack_arr_compat/legacy_serialize/fb_compact_serialize.php.skipif create mode 100644 hphp/test/slow/hack_arr_compat/serialization-notices.php.skipif create mode 100644 hphp/test/slow/implicit-context/memo-agnostic-ic-all-types.php.skipif create mode 100644 hphp/test/slow/keyset/fb_serialize.php.skipif create mode 100644 hphp/test/slow/meth-caller-serialize-native.php.skipif create mode 100644 hphp/test/slow/meth-caller-serialize-throw.php.skipif create mode 100644 hphp/test/slow/meth-caller-serialize.php.skipif create mode 100644 hphp/test/slow/typed_locals/config.opts create mode 100644 hphp/test/slow/vec/fb_serialize.php.skipif create mode 100644 hphp/test/slow/vle/config.runif diff --git a/hphp/test/slow/checked_unsafe_cast/config.opts b/hphp/test/slow/checked_unsafe_cast/config.opts new file mode 100644 index 00000000000000..5437ee9f96f842 --- /dev/null +++ b/hphp/test/slow/checked_unsafe_cast/config.opts @@ -0,0 +1 @@ +-vPHP7.EngineExceptions=false diff --git a/hphp/test/slow/class-ptr/class-serde.php.skipif b/hphp/test/slow/class-ptr/class-serde.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/class-ptr/class-serde.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/dict/fb_serialize.php.skipif b/hphp/test/slow/dict/fb_serialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/dict/fb_serialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/dv_array_hack_arr/fb_serialize.php.skipif b/hphp/test/slow/dv_array_hack_arr/fb_serialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/dv_array_hack_arr/fb_serialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/dv_array_hack_arr/fb_serialize_2.php.skipif b/hphp/test/slow/dv_array_hack_arr/fb_serialize_2.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/dv_array_hack_arr/fb_serialize_2.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/eden/config.runif b/hphp/test/slow/eden/config.runif new file mode 100644 index 00000000000000..311fcf8fd4e08e --- /dev/null +++ b/hphp/test/slow/eden/config.runif @@ -0,0 +1 @@ +extension eden diff --git a/hphp/test/slow/ext_configerator/config.runif b/hphp/test/slow/ext_configerator/config.runif new file mode 100644 index 00000000000000..c6921afacebbf5 --- /dev/null +++ b/hphp/test/slow/ext_configerator/config.runif @@ -0,0 +1 @@ +extension configerator diff --git a/hphp/test/slow/ext_fb/compact_serialize.php.skipif b/hphp/test/slow/ext_fb/compact_serialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/ext_fb/compact_serialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/ext_fb/fb_serialize_hack_array_notices.php.skipif b/hphp/test/slow/ext_fb/fb_serialize_hack_array_notices.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/ext_fb/fb_serialize_hack_array_notices.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/ext_fb/migratory_serialize.php.skipif b/hphp/test/slow/ext_fb/migratory_serialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/ext_fb/migratory_serialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/ext_fb/serialize.php.skipif b/hphp/test/slow/ext_fb/serialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/ext_fb/serialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/ext_fb/serialize_post_ham.php.skipif b/hphp/test/slow/ext_fb/serialize_post_ham.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/ext_fb/serialize_post_ham.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/ext_fb/unserialize_max_depth.php.skipif b/hphp/test/slow/ext_fb/unserialize_max_depth.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/ext_fb/unserialize_max_depth.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/func-ptr-no-interop/func-serde.php.skipif b/hphp/test/slow/func-ptr-no-interop/func-serde.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/func-ptr-no-interop/func-serde.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/hack_arr_compat/fb_unserialize.php.skipif b/hphp/test/slow/hack_arr_compat/fb_unserialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/hack_arr_compat/fb_unserialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/hack_arr_compat/legacy_serialize/fb_compact_serialize.php.skipif b/hphp/test/slow/hack_arr_compat/legacy_serialize/fb_compact_serialize.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/hack_arr_compat/legacy_serialize/fb_compact_serialize.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/hack_arr_compat/serialization-notices.php.skipif b/hphp/test/slow/hack_arr_compat/serialization-notices.php.skipif new file mode 100644 index 00000000000000..18efa7b19fbf6c --- /dev/null +++ b/hphp/test/slow/hack_arr_compat/serialization-notices.php.skipif @@ -0,0 +1,8 @@ +> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/implicit-context/memo-agnostic-ic-all-types.php.skipif b/hphp/test/slow/implicit-context/memo-agnostic-ic-all-types.php.skipif new file mode 100644 index 00000000000000..91535cc534e35e --- /dev/null +++ b/hphp/test/slow/implicit-context/memo-agnostic-ic-all-types.php.skipif @@ -0,0 +1,7 @@ +> function skipif(): void { + if (!function_exists('HH\Coeffects\fb\backdoor_from_leak_safe__DO_NOT_USE')) { + exit('skip HH\Coeffects\fb\backdoor_from_leak_safe__DO_NOT_USE() not available in OSS'); + } +} diff --git a/hphp/test/slow/keyset/fb_serialize.php.skipif b/hphp/test/slow/keyset/fb_serialize.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/keyset/fb_serialize.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/meth-caller-serialize-native.php.skipif b/hphp/test/slow/meth-caller-serialize-native.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/meth-caller-serialize-native.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/meth-caller-serialize-throw.php.skipif b/hphp/test/slow/meth-caller-serialize-throw.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/meth-caller-serialize-throw.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/meth-caller-serialize.php.skipif b/hphp/test/slow/meth-caller-serialize.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/meth-caller-serialize.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/static-analysis-error.php.expectf b/hphp/test/slow/static-analysis-error.php.expectf index de5e6b078ca86e..6bb581692c2512 100644 --- a/hphp/test/slow/static-analysis-error.php.expectf +++ b/hphp/test/slow/static-analysis-error.php.expectf @@ -1,5 +1,5 @@ %A -%|{Detected jit::trap at 0x%s: from fbcode/hphp/runtime/vm/jit/irlower-intrinsic.cpp:%d|fbcode/hphp/runtime/vm/bytecode.cpp:%d: void HPHP::iopStaticAnalysisError(): assertion `!Cfg::Eval::CrashOnStaticAnalysisError' failed.} +%|{Detected jit::trap at 0x%s: from %s/hphp/runtime/vm/jit/irlower-intrinsic.cpp:%d|%s/hphp/runtime/vm/bytecode.cpp:%d: void HPHP::iopStaticAnalysisError(): assertion `!Cfg::Eval::CrashOnStaticAnalysisError' failed.} %A PHP Stacktrace: diff --git a/hphp/test/slow/typed_locals/config.opts b/hphp/test/slow/typed_locals/config.opts new file mode 100644 index 00000000000000..5437ee9f96f842 --- /dev/null +++ b/hphp/test/slow/typed_locals/config.opts @@ -0,0 +1 @@ +-vPHP7.EngineExceptions=false diff --git a/hphp/test/slow/vec/fb_serialize.php.skipif b/hphp/test/slow/vec/fb_serialize.php.skipif new file mode 100644 index 00000000000000..725b90ee172495 --- /dev/null +++ b/hphp/test/slow/vec/fb_serialize.php.skipif @@ -0,0 +1,6 @@ +<<__EntryPoint>> +function skipif(): void { + if (!HHVM_FACEBOOK) { + exit('skip fb_serialize() not available in OSS'); + } +} diff --git a/hphp/test/slow/vle/config.runif b/hphp/test/slow/vle/config.runif new file mode 100644 index 00000000000000..15025161cbc3d6 --- /dev/null +++ b/hphp/test/slow/vle/config.runif @@ -0,0 +1 @@ +extension vle