Skip to content

Commit 4cabd4a

Browse files
generatedunixname89002005287564meta-codesync[bot]
authored andcommitted
Fix CQS signal modernize-use-override in fbcode/proxygen/httpserver
Differential Revision: D90837594 fbshipit-source-id: 9a1860ec63e8e44a44c0fee27db657a6a447c756
1 parent f2a190a commit 4cabd4a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

proxygen/httpserver/ExMessageHandler.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ namespace proxygen {
1717
*/
1818
class ExMessageHandler : public RequestHandler {
1919
public:
20-
virtual void onUpgrade(proxygen::UpgradeProtocol /*prot*/) noexcept override {
20+
void onUpgrade(proxygen::UpgradeProtocol /*prot*/) noexcept override {
2121
LOG(FATAL) << "ExMessageHandler doesn't support upgrade";
2222
}
2323

24-
virtual ExMessageHandler* getExHandler() noexcept override {
24+
ExMessageHandler* getExHandler() noexcept override {
2525
LOG(FATAL) << "getExHandler can't be called on ExMessageHandler";
2626
}
2727
};

proxygen/httpserver/HTTPTransactionHandlerAdaptor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class HTTPTransactionHandlerAdaptor : public RequestHandler {
6969
void onEgressResumed() noexcept override {
7070
handler_->onEgressResumed();
7171
}
72-
~HTTPTransactionHandlerAdaptor() = default;
72+
~HTTPTransactionHandlerAdaptor() override = default;
7373

7474
private:
7575
HTTPTransactionHandler* handler_;

proxygen/httpserver/filters/CompressionFilter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class CompressionFilter : public Filter {
2525
: Filter(downstream), params_(std::move(params)) {
2626
}
2727

28-
virtual ~CompressionFilter() override = default;
28+
~CompressionFilter() override = default;
2929

3030
CompressionFilter(const CompressionFilter&) = delete;
3131
CompressionFilter& operator=(const CompressionFilter&) = delete;
@@ -153,7 +153,7 @@ class CompressionFilterFactory : public RequestHandlerFactory {
153153
CompressionFilterFactory(const Options& opts) : options_(opts) {
154154
}
155155

156-
virtual ~CompressionFilterFactory() = default;
156+
~CompressionFilterFactory() override = default;
157157

158158
CompressionFilterFactory(const CompressionFilterFactory&) = delete;
159159
CompressionFilterFactory& operator=(const CompressionFilterFactory&) = delete;

0 commit comments

Comments
 (0)