Skip to content

Commit c542309

Browse files
Yang Wangmeta-codesync[bot]
authored andcommitted
add keyType to CreateCertOptions and optionally support creating RSA private keys
Summary: CertUtil::createCert by default creates an EC private key. Let's extend this to optionally create RSA private keys as well. Other supported key types remain unimplemented for now. Reviewed By: mingtaoy Differential Revision: D91269144 fbshipit-source-id: b566a0e2712ab715c7aea2442b38f52d816f724d
1 parent c2ae813 commit c542309

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

proxygen/lib/transport/test/PersistentFizzPskCacheTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ class PersistentFizzPskCacheTest : public Test {
2424
createCache();
2525

2626
std::shared_ptr<fizz::PeerCert> serverCert = fizz::test::getPeerCert(
27-
fizz::test::createCert("server", false, nullptr));
27+
fizz::test::createCert("server", false, nullptr, fizz::KeyType::P256));
2828

2929
std::shared_ptr<fizz::PeerCert> clientCert = fizz::test::getPeerCert(
30-
fizz::test::createCert("client", false, nullptr));
30+
fizz::test::createCert("client", false, nullptr, fizz::KeyType::P256));
3131

3232
psk1_.psk = "PSK1";
3333
psk1_.secret = "secret1";

proxygen/lib/transport/test/PersistentQuicPskCacheTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ class PersistentQuicPskCacheTest : public Test {
2525
createCache();
2626

2727
std::shared_ptr<fizz::PeerCert> serverCert = fizz::test::getPeerCert(
28-
fizz::test::createCert("server", false, nullptr));
28+
fizz::test::createCert("server", false, nullptr, fizz::KeyType::P256));
2929

3030
std::shared_ptr<fizz::PeerCert> clientCert = fizz::test::getPeerCert(
31-
fizz::test::createCert("client", false, nullptr));
31+
fizz::test::createCert("client", false, nullptr, fizz::KeyType::P256));
3232

3333
auto& fizzPsk1 = quicPsk1_.cachedPsk;
3434
fizzPsk1.psk = "PSK1";

0 commit comments

Comments
 (0)