fixed errors highlighted one line below, fixed .pysa files not being tracked by the server

Author: m0mosenpai

client/commands/v2/persistent.py

@@ -187,10 +187,14 @@ async def try_initialize(
 async def _read_lsp_request(
     input_channel: connection.TextReader, output_channel: connection.TextWriter
 ) -> AsyncIterator[json_rpc.Request]:
+    LOG.info("** Inside the read lsp function ** ")
     try:
+        LOG.info("** Inside the try and except ** ")
         message = await lsp.read_json_rpc(input_channel)
+        LOG.info(f"** {message} **")
         yield message
     except json_rpc.JSONRPCException as json_rpc_error:
+        LOG.info("** Inside the except ** ")
         await lsp.write_json_rpc(
             output_channel,
             json_rpc.ErrorResponse(
@@ -510,9 +514,9 @@ def invalid_model_to_diagnostic(
 ) -> lsp.Diagnostic:
     return lsp.Diagnostic(
         range=lsp.Range(
-            start=lsp.Position(line=invalid_model.line, character=invalid_model.column),
+            start=lsp.Position(line=invalid_model.line - 1, character=invalid_model.column),
             end=lsp.Position(
-                line=invalid_model.stop_line, character=invalid_model.stop_column
+                line=invalid_model.stop_line - 1, character=invalid_model.stop_column
             ),
         ),
         message=invalid_model.full_error_message,

client/commands/v2/pysa_server.py

@@ -101,7 +101,7 @@ async def wait_for_exit(self) -> int:
     async def process_open_request(
         self, parameters: lsp.DidOpenTextDocumentParameters
     ) -> None:
-        print("A document was just opened!")
+        LOG.info("** Inside process_open_request() **")
         document_path = parameters.text_document.document_uri().to_file_path()
         if document_path is None:
             raise json_rpc.InvalidRequestError(
@@ -111,7 +111,7 @@ async def process_open_request(
     async def process_close_request(
         self, parameters: lsp.DidCloseTextDocumentParameters
     ) -> None:
-        print("A document was just closed!")
+        LOG.info("** Inside process_close_request() **")
         document_path = parameters.text_document.document_uri().to_file_path()
         if document_path is None:
             raise json_rpc.InvalidRequestError(
@@ -126,7 +126,7 @@ async def process_close_request(
     async def process_did_save_request(
         self, parameters: lsp.DidSaveTextDocumentParameters
     ) -> None:
-        print("A document was just saved!")
+        LOG.info("** Inside process_did_save_request() **")
         document_path = parameters.text_document.document_uri().to_file_path()
         if document_path is None:
             raise json_rpc.InvalidRequestError(
@@ -148,6 +148,7 @@ async def run(self) -> int:
                     )
                     return await self.wait_for_exit()
                 elif request.method == "textDocument/didOpen":
+                    LOG.info("** A Document just opened! **")
                     parameters = request.parameters
                     if parameters is None:
                         raise json_rpc.InvalidRequestError(
@@ -159,6 +160,7 @@ async def run(self) -> int:
                         )
                     )
                 elif request.method == "textDocument/didClose":
+                    LOG.info("** A Document just closed! **")
                     parameters = request.parameters
                     if parameters is None:
                         raise json_rpc.InvalidRequestError(
@@ -170,6 +172,7 @@ async def run(self) -> int:
                         )
                     )
                 elif request.method == "textDocument/didSave":
+                    LOG.info("** A Document just saved! **")
                     parameters = request.parameters
                     if parameters is None:
                         raise json_rpc.InvalidRequestError(
@@ -182,6 +185,8 @@ async def run(self) -> int:
                     )
                 elif request.id is not None:
                     raise lsp.RequestCancelledError("Request not supported yet")
+                else:
+                    LOG.info("** Hmmm I guess nothing seems to be happening **")
 
 
 async def run_persistent(

documentation/pysa_tutorial/exercise2/.pyre_configuration

@@ -0,0 +1,15 @@
+{
+  "source_directories": [
+    "."
+  ],
+  "taint_models_path": [
+    "."
+  ],
+  "search_path": [
+    "../../../stubs/"
+  ],
+  "exclude": [
+    ".*/integration_test/.*"
+  ],
+  "use_command_v2": true
+}

documentation/pysa_tutorial/exercise2/views.py

@@ -0,0 +1,30 @@
+# Copyright (c) Facebook, Inc. and its affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+import subprocess
+
+from django.http import HttpRequest, HttpResponse
+
+def operate_on_twos(request: HttpRequest) -> HttpResponse:
+    operator = request.POST["operator"]
+
+    result = eval(f"2 {operator} 2")  # noqa: P204
+
+    return result
+
+
+def operate_on_threes(request: HttpRequest) -> HttpResponse:
+    operator = request.GET["operator"]
+
+    exec(f"result = 3 {operator} 3")
+ 
+    return result  # noqa: F82 1
+
+def operate_on_fours(request: HttpRequest) -> HttpResponse:
+    operator = request.GET["operator"]
+
+    result = subprocess.getoutput(f"expr 4 {operator} 4")
+
+    return result