Expand relative paths for --source-directory cli argument

Reviewed By: dkgi

Differential Revision: D30521928

fbshipit-source-id: 3e5a7bb4575b2fe7cab1939b27cfd70e61c351cf

Author: grievejia

client/configuration.py

@@ -1254,7 +1254,7 @@ def create_configuration(
 
     command_argument_configuration = PartialConfiguration.from_command_arguments(
         arguments
-    )
+    ).expand_relative_paths(str(Path.cwd()))
     if found_root is None:
         project_root = Path.cwd()
         relative_local_root = None
@@ -1275,7 +1275,8 @@ def create_configuration(
                 ).expand_relative_paths(str(local_root)),
             )
         partial_configuration = merge_partial_configurations(
-            base=partial_configuration, override=command_argument_configuration
+            base=partial_configuration,
+            override=command_argument_configuration,
         )
 
     configuration = Configuration.from_partial_configuration(

client/tests/configuration_test.py

@@ -1179,6 +1179,10 @@ def test_create_from_command_arguments_only(self) -> None:
                 self.assertEqual(configuration.project_root, str(root_path))
                 self.assertEqual(configuration.relative_local_root, None)
                 self.assertEqual(configuration.dot_pyre_directory, root_path / ".pyre")
+                self.assertListEqual(
+                    list(configuration.source_directories or []),
+                    [SimpleSearchPathElement(str(root_path))],
+                )
 
     def test_create_from_global_configuration(self) -> None:
         with tempfile.TemporaryDirectory() as root:
@@ -1198,6 +1202,10 @@ def test_create_from_global_configuration(self) -> None:
                 self.assertEqual(configuration.relative_local_root, None)
                 self.assertEqual(configuration.dot_pyre_directory, Path(".pyre"))
                 self.assertEqual(configuration.strict, True)
+                self.assertListEqual(
+                    list(configuration.source_directories or []),
+                    [SimpleSearchPathElement(str(root_path))],
+                )
 
     def test_create_from_local_configuration(self) -> None:
         with tempfile.TemporaryDirectory() as root:
@@ -1225,6 +1233,10 @@ def test_create_from_local_configuration(self) -> None:
                 self.assertEqual(configuration.relative_local_root, "local")
                 self.assertEqual(configuration.dot_pyre_directory, Path(".pyre"))
                 self.assertEqual(configuration.strict, True)
+                self.assertListEqual(
+                    list(configuration.source_directories or []),
+                    [SimpleSearchPathElement(str(root_path))],
+                )
                 self.assertListEqual(
                     list(configuration.search_path),
                     [