minor refactoring, minor fixes

Author: m0mosenpai

client/commands/v2/pysa_server.py

@@ -62,7 +62,8 @@ def __init__(
         self.binary_location = binary_location
         self.server_identifier = server_identifier
 
-    async def update_errors(self) -> None:
+    async def update_errors(self, document_path) -> None:
+        await _publish_diagnostics(self.output_channel, document_path, [])
         pyre_connection = api_connection.PyreConnection(
             Path(self.pyre_arguments.global_root)
         )
@@ -120,6 +121,8 @@ async def process_open_request(
                 f"Document URI is not a file: {parameters.text_document.uri}"
             )
 
+        await self.update_errors(document_path)
+
     async def process_close_request(
         self, parameters: lsp.DidCloseTextDocumentParameters
     ) -> None:
@@ -142,6 +145,7 @@ async def process_did_save_request(
             raise json_rpc.InvalidRequestError(
                 f"Document URI is not a file: {parameters.text_document.uri}"
             )
+        await self.update_errors(document_path)
 
     async def run(self) -> int:
         while True:

client/commands/v2/start.py

@@ -513,7 +513,7 @@ def get_server_identifier(configuration: configuration_module.Configuration) ->
 
 
 def _write_argument_file(output_file: IO[str], arguments: Arguments) -> None:
-    # LOG.info(f"Writing server startup configurations into {output_file.name}...")
+    LOG.info(f"Writing server startup configurations into {output_file.name}...")
     serialized_arguments = arguments.serialize()
     LOG.debug(f"Arguments:\n{json.dumps(serialized_arguments, indent=2)}")
     output_file.write(json.dumps(serialized_arguments))