Improve name extraction for non-python methods

Summary: For slot wrappers like the ones that thrift generates, the existing qualified name generation does not correctly identify the parent module, leading to failures in pysa.

Reviewed By: gbleaney

Differential Revision: D30091530

fbshipit-source-id: 689250a737b25291e2d6ff9fceb73fe04eb364b5

Author: keshavdv

tools/generate_taint_models/inspect_parser.py

@@ -20,6 +20,11 @@ def extract_qualified_name(callable_object: Callable[..., object]) -> Optional[s
         return extract_qualified_name(callable_object.__func__)
     else:
         module_name = getattr(callable_object, "__module__", None)
+        # Try and fallback to objclass
+        if module_name is None and (
+            objclass := getattr(callable_object, "__objclass__", None)
+        ):
+            module_name = getattr(objclass, "__module__", None)
         view_name = getattr(
             callable_object, "__qualname__", callable_object.__class__.__qualname__
         )

tools/generate_taint_models/tests/inspect_parser_test.py

@@ -5,6 +5,8 @@
 
 import unittest
 
+from testing.types import File
+
 from ..inspect_parser import extract_parameters, extract_qualified_name
 from ..parameter import Parameter
 
@@ -65,3 +67,9 @@ def test_extract_parameters(self) -> None:
         self.assertEqual(
             extract_parameters(TestMethodClass.test_method), expected_parameters
         )
+
+    def test_thrift_structs(self) -> None:
+        self.assertEqual(
+            extract_qualified_name(File.__hash__),
+            "testing.types.File.__hash__",
+        )