Skip to content

Commit 4a8df7e

Browse files
arthaudfacebook-github-bot
authored andcommitted
Remove an outdated comment
Summary: This comment is misleading. We only handle the `AttachTo` feature here. Declared taint doesn't need to be handled here, it will be joined at the end of the iteration, by the fixpoint algorithm. Let's remove the comment to prevent confusion. Reviewed By: dkgi Differential Revision: D30758273 fbshipit-source-id: 66697ca1a5f0181089a51cbb39011d8b44d1ef57
1 parent c6b4ba6 commit 4a8df7e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

source/interprocedural_analyses/taint/forwardAnalysis.ml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1805,8 +1805,6 @@ let run ~environment ~qualifier ~define ~call_graph_of_define ~existing_model =
18051805
in
18061806
let resolution = TypeEnvironment.ReadOnly.global_resolution environment in
18071807
let extract_model { FixpointState.taint; _ } =
1808-
(* Explicitly declared taint is not propagated to the result and needs to be picked up from the
1809-
existing model. *)
18101808
let features_to_attach = extract_features_to_attach existing_model.forward.source_taint in
18111809
let source_taint =
18121810
extract_source_model ~define:define.value ~resolution ~features_to_attach taint

0 commit comments

Comments
 (0)