Implement pyre statistics (7/9) -- aggregate stats

Reviewed By: dkgi

Differential Revision: D30414289

fbshipit-source-id: 165480c7bee7c70f19e1606daaeb91ef1e04b7c2

Author: grievejia

client/commands/v2/statistics.py

@@ -151,6 +151,42 @@ def collect_statistics(sources: Sequence[Path], strict_default: bool) -> Statist
     )
 
 
+@dataclasses.dataclass(frozen=True)
+class AggregatedStatisticsData:
+    annotations: Dict[str, int] = dataclasses.field(default_factory=dict)
+    fixmes: int = 0
+    ignores: int = 0
+    strict: int = 0
+    unsafe: int = 0
+
+
+def aggregate_statistics(data: StatisticsData) -> AggregatedStatisticsData:
+    aggregate_annotations = {
+        "return_count": 0,
+        "annotated_return_count": 0,
+        "globals_count": 0,
+        "annotated_globals_count": 0,
+        "parameter_count": 0,
+        "annotated_parameter_count": 0,
+        "attribute_count": 0,
+        "annotated_attribute_count": 0,
+        "partially_annotated_function_count": 0,
+        "fully_annotated_function_count": 0,
+        "line_count": 0,
+    }
+    for annotation_data in data.annotations.values():
+        for key in aggregate_annotations.keys():
+            aggregate_annotations[key] += annotation_data[key]
+
+    return AggregatedStatisticsData(
+        annotations=aggregate_annotations,
+        fixmes=sum(len(fixmes) for fixmes in data.fixmes.values()),
+        ignores=sum(len(ignores) for ignores in data.ignores.values()),
+        strict=sum(strictness["strict_count"] for strictness in data.strict.values()),
+        unsafe=sum(strictness["unsafe_count"] for strictness in data.strict.values()),
+    )
+
+
 def run_statistics(
     configuration: configuration_module.Configuration,
     statistics_arguments: command_arguments.StatisticsArguments,

client/commands/v2/tests/statistics_test.py

@@ -17,6 +17,8 @@
     parse_text_to_module,
     parse_path_to_module,
     collect_statistics,
+    aggregate_statistics,
+    AggregatedStatisticsData,
 )
 
 
@@ -154,3 +156,94 @@ def test_collect_statistics(self) -> None:
             self.assertIn(str(bar_path), data.fixmes)
             self.assertIn(str(bar_path), data.ignores)
             self.assertIn(str(bar_path), data.strict)
+
+    def test_aggregate_statistics__single_file(self) -> None:
+        with tempfile.TemporaryDirectory() as root:
+            root_path = Path(root)
+            a_path = root_path / "a.py"
+            a_path.write_text(
+                textwrap.dedent(
+                    """
+                    # pyre-unsafe
+
+                    def foo():
+                        return 1
+                    """.rstrip()
+                )
+            )
+
+            self.assertEqual(
+                aggregate_statistics(
+                    collect_statistics([a_path], strict_default=False)
+                ),
+                AggregatedStatisticsData(
+                    annotations={
+                        "return_count": 1,
+                        "annotated_return_count": 0,
+                        "globals_count": 0,
+                        "annotated_globals_count": 0,
+                        "parameter_count": 0,
+                        "annotated_parameter_count": 0,
+                        "attribute_count": 0,
+                        "annotated_attribute_count": 0,
+                        "partially_annotated_function_count": 0,
+                        "fully_annotated_function_count": 0,
+                        "line_count": 6,
+                    },
+                    fixmes=0,
+                    ignores=0,
+                    strict=0,
+                    unsafe=1,
+                ),
+            )
+
+    def test_aggregate_statistics__multiple_files(self) -> None:
+        with tempfile.TemporaryDirectory() as root:
+            root_path = Path(root)
+            a_path = root_path / "a.py"
+            b_path = root_path / "b.py"
+            a_path.write_text(
+                textwrap.dedent(
+                    """
+                    # pyre-unsafe
+
+                    def foo():
+                        return 1
+                    """.rstrip()
+                )
+            )
+            b_path.write_text(
+                textwrap.dedent(
+                    """
+                    # pyre-strict
+
+                    def foo(x: int) -> int:
+                        return 1
+                    """.rstrip()
+                )
+            )
+
+            self.assertEqual(
+                aggregate_statistics(
+                    collect_statistics([a_path, b_path], strict_default=False)
+                ),
+                AggregatedStatisticsData(
+                    annotations={
+                        "return_count": 2,
+                        "annotated_return_count": 1,
+                        "globals_count": 0,
+                        "annotated_globals_count": 0,
+                        "parameter_count": 1,
+                        "annotated_parameter_count": 1,
+                        "attribute_count": 0,
+                        "annotated_attribute_count": 0,
+                        "partially_annotated_function_count": 0,
+                        "fully_annotated_function_count": 1,
+                        "line_count": 12,
+                    },
+                    fixmes=0,
+                    ignores=0,
+                    strict=1,
+                    unsafe=1,
+                ),
+            )