Refactor uninitializedLocalCheck to allow running directly on define

Reviewed By: dkgi

Differential Revision: D28973956

fbshipit-source-id: 18a58aea48b72d99fd0cafea37aec757ccc1b376

Author: kbansal

source/analysis/uninitializedLocalCheck.ml

@@ -127,20 +127,24 @@ module State (Context : Context) = struct
   let backward ~key:_ _ ~statement:_ = failwith "Not implemented"
 end
 
+let run_on_define ~qualifier define =
+  let module Context = struct
+    let uninitialized_usage = Int.Table.create ()
+  end
+  in
+  let module State = State (Context) in
+  let module Fixpoint = Fixpoint.Make (State) in
+  let cfg = Cfg.create (Node.value define) in
+  let fixpoint = Fixpoint.forward ~cfg ~initial:(State.initial ~define) in
+  Fixpoint.exit fixpoint >>| State.errors ~qualifier ~define |> Option.value ~default:[]
+
+
 let run
     ~configuration:_
     ~environment:_
     ~source:({ Source.source_path = { SourcePath.qualifier; _ }; _ } as source)
   =
-  let check define =
-    let module Context = struct
-      let uninitialized_usage = Int.Table.create ()
-    end
-    in
-    let module State = State (Context) in
-    let module Fixpoint = Fixpoint.Make (State) in
-    let cfg = Cfg.create (Node.value define) in
-    let fixpoint = Fixpoint.forward ~cfg ~initial:(State.initial ~define) in
-    Fixpoint.exit fixpoint >>| State.errors ~qualifier ~define |> Option.value ~default:[]
-  in
-  source |> Preprocessing.defines ~include_toplevels:false |> List.map ~f:check |> List.concat
+  source
+  |> Preprocessing.defines ~include_toplevels:false
+  |> List.map ~f:(run_on_define ~qualifier)
+  |> List.concat

source/analysis/uninitializedLocalCheck.mli

@@ -10,6 +10,8 @@ module Error = AnalysisError
 
 val name : string
 
+val run_on_define : qualifier:Reference.t -> Statement.Define.t Node.t -> Error.t list
+
 val run
   :  configuration:Configuration.Analysis.t ->
   environment:TypeEnvironment.ReadOnly.t ->