Move the unexpected statement error after the parser error

Summary: Those are logically the most general type of errors, let's put them on the top.

Reviewed By: dkgi

Differential Revision: D28950396

fbshipit-source-id: 0b3fa257a5c42ea1315aafa9f0b1ec67a940c8be

Author: arthaud

source/interprocedural_analyses/taint/modelVerificationError.ml

@@ -20,6 +20,7 @@ module T = struct
 
   type kind =
     | ParseError
+    | UnexpectedStatement of Statement.t
     | InvalidDefaultValue of {
         callable_name: string;
         name: string;
@@ -70,7 +71,6 @@ module T = struct
         unexpected_decorators: Statement.Decorator.t list;
       }
     | InvalidIdentifier of Expression.t
-    | UnexpectedStatement of Statement.t
     | ClassBodyNotEllipsis of string
     | DefineBodyNotEllipsis of string
     (* TODO(T81363867): Remove this variant. *)
@@ -93,6 +93,7 @@ include T
 let description error =
   match error with
   | ParseError -> "Syntax error."
+  | UnexpectedStatement _ -> "Unexpected statement."
   | InvalidDefaultValue { callable_name; name; expression } ->
       Format.sprintf
         "Default values of `%s`'s parameters must be `...`. Did you mean to write `%s: %s`?"
@@ -179,7 +180,6 @@ let description error =
       Format.sprintf
         "Invalid identifier: `%s`. Expected a fully-qualified name."
         (Expression.show expression)
-  | UnexpectedStatement _ -> "Unexpected statement."
   | ClassBodyNotEllipsis class_name ->
       Format.sprintf "Class model for `%s` must have a body of `...`." class_name
   | DefineBodyNotEllipsis model_name ->

source/interprocedural_analyses/taint/modelVerificationError.mli

@@ -18,6 +18,7 @@ module T : sig
 
   type kind =
     | ParseError
+    | UnexpectedStatement of Statement.t
     | InvalidDefaultValue of {
         callable_name: string;
         name: string;
@@ -68,7 +69,6 @@ module T : sig
         unexpected_decorators: Statement.Decorator.t list;
       }
     | InvalidIdentifier of Expression.t
-    | UnexpectedStatement of Statement.t
     | ClassBodyNotEllipsis of string
     | DefineBodyNotEllipsis of string
     | UnclassifiedError of {