impl ?

Author: asukaminato0721

crates/pyrefly_types/src/display.rs

@@ -7,9 +7,11 @@
 
 //! Display a type. The complexity comes from if we have two classes with the same name,
 //! we want to display disambiguating information (e.g. module name or location).
+use std::cell::RefCell;
 use std::fmt;
 use std::fmt::Display;
 
+use dupe::Dupe;
 use pyrefly_python::module_name::ModuleName;
 use pyrefly_python::qname::QName;
 use pyrefly_util::display::Fmt;
@@ -87,6 +89,7 @@ pub struct TypeDisplayContext<'a> {
     /// Should we display for IDE Hover? This makes type names more readable but less precise.
     hover: bool,
     always_display_module_name: bool,
+    display_modules: RefCell<SmallSet<ModuleName>>,
 }
 
 impl<'a> TypeDisplayContext<'a> {
@@ -232,13 +235,26 @@ impl<'a> TypeDisplayContext<'a> {
         name: &str,
         f: &mut fmt::Formatter<'_>,
     ) -> fmt::Result {
+        self.display_modules
+            .borrow_mut()
+            .insert(ModuleName::from_str(module));
         if self.always_display_module_name {
             write!(f, "{module}.{name}")
         } else {
             write!(f, "{name}")
         }
     }
 
+    pub fn referenced_modules(&self) -> SmallSet<ModuleName> {
+        let mut modules = self.display_modules.borrow().clone();
+        for info in self.qnames.values() {
+            for module in info.info.keys() {
+                modules.insert(module.dupe());
+            }
+        }
+        modules
+    }
+
     fn fmt_helper<'b>(
         &self,
         t: &'b Type,

pyrefly/lib/lsp/non_wasm/server.rs

@@ -196,8 +196,6 @@ use crate::lsp::non_wasm::module_helpers::module_info_to_uri;
 use crate::lsp::non_wasm::queue::HeavyTaskQueue;
 use crate::lsp::non_wasm::queue::LspEvent;
 use crate::lsp::non_wasm::queue::LspQueue;
-use crate::lsp::non_wasm::stdlib::is_python_stdlib_file;
-use crate::lsp::non_wasm::stdlib::should_show_stdlib_error;
 use crate::lsp::non_wasm::transaction_manager::TransactionManager;
 use crate::lsp::non_wasm::will_rename_files::will_rename_files;
 use crate::lsp::non_wasm::workspace::LspAnalysisConfig;
@@ -2339,20 +2337,29 @@ impl Server {
             .into_iter()
             .filter_map(|x| {
                 // If the url is a notebook cell, filter out inlay hints for other cells
-                if info.to_cell_for_lsp(x.0) != maybe_cell_idx {
+                if info.to_cell_for_lsp(x.position) != maybe_cell_idx {
                     return None;
                 }
-                let position = info.to_lsp_position(x.0);
+                let position = info.to_lsp_position(x.position);
                 // The range is half-open, so the end position is exclusive according to the spec.
                 if position >= range.start && position < range.end {
+                    let mut text_edits = Vec::with_capacity(1 + x.import_edits.len());
+                    text_edits.push(TextEdit {
+                        range: Range::new(position, position),
+                        new_text: x.label.clone(),
+                    });
+                    for (offset, import_text) in x.import_edits {
+                        let insert_position = info.to_lsp_position(offset);
+                        text_edits.push(TextEdit {
+                            range: Range::new(insert_position, insert_position),
+                            new_text: import_text,
+                        });
+                    }
                     Some(InlayHint {
                         position,
-                        label: InlayHintLabel::String(x.1.clone()),
+                        label: InlayHintLabel::String(x.label),
                         kind: None,
-                        text_edits: Some(vec![TextEdit {
-                            range: Range::new(position, position),
-                            new_text: x.1,
-                        }]),
+                        text_edits: Some(text_edits),
                         tooltip: None,
                         padding_left: None,
                         padding_right: None,

pyrefly/lib/playground.rs

@@ -515,9 +515,12 @@ impl Playground {
             .get_module_info(handle)
             .zip(transaction.inlay_hints(handle, Default::default()))
             .map(|(info, hints)| {
-                hints.into_map(|(position, label)| {
-                    let position = Position::from_display_pos(info.display_pos(position));
-                    InlayHint { label, position }
+                hints.into_map(|hint| {
+                    let position = Position::from_display_pos(info.display_pos(hint.position));
+                    InlayHint {
+                        label: hint.label,
+                        position,
+                    }
                 })
             })
             .unwrap_or_default()