Move add_literal_completions to completion module

Summary: Moves add_literal_completions to the completion module.

Reviewed By: yangdanny97

Differential Revision: D91782197

fbshipit-source-id: 5c3e4ee9f219db22700ec9677cee6c63129f0a84

Author: jvansch1

pyrefly/lib/lsp/wasm/completion.rs

@@ -292,4 +292,28 @@ impl Transaction<'_> {
         }
         has_added_any
     }
+
+    /// Adds literal completions for function call arguments based on parameter types.
+    pub(crate) fn add_literal_completions(
+        &self,
+        handle: &Handle,
+        position: TextSize,
+        completions: &mut Vec<CompletionItem>,
+        in_string_literal: bool,
+    ) {
+        if let Some((callables, chosen_overload_index, active_argument, _)) =
+            self.get_callables_from_call(handle, position)
+            && let Some(callable) = callables.get(chosen_overload_index)
+            && let Some(params) =
+                Self::normalize_singleton_function_type_into_params(callable.clone())
+            && let Some(arg_index) = Self::active_parameter_index(&params, &active_argument)
+            && let Some(param) = params.get(arg_index)
+        {
+            Self::add_literal_completions_from_type(
+                param.as_type(),
+                completions,
+                in_string_literal,
+            );
+        }
+    }
 }

pyrefly/lib/state/lsp.rs

@@ -2695,29 +2695,6 @@ impl<'a> Transaction<'a> {
         }
     }
 
-    fn add_literal_completions(
-        &self,
-        handle: &Handle,
-        position: TextSize,
-        completions: &mut Vec<CompletionItem>,
-        in_string_literal: bool,
-    ) {
-        if let Some((callables, chosen_overload_index, active_argument, _)) =
-            self.get_callables_from_call(handle, position)
-            && let Some(callable) = callables.get(chosen_overload_index)
-            && let Some(params) =
-                Self::normalize_singleton_function_type_into_params(callable.clone())
-            && let Some(arg_index) = Self::active_parameter_index(&params, &active_argument)
-            && let Some(param) = params.get(arg_index)
-        {
-            Self::add_literal_completions_from_type(
-                param.as_type(),
-                completions,
-                in_string_literal,
-            );
-        }
-    }
-
     // Kept for backwards compatibility - used by external callers (lsp/server.rs, playground.rs)
     // who don't need the is_incomplete flag
     pub fn completion(