add version support to textDocument/publishDiagnostics

Author: dearfl

pyrefly/lib/lsp/non_wasm/server.rs

@@ -292,11 +292,17 @@ impl ServerConnection {
         ));
     }
 
-    fn publish_diagnostics(&self, diags: SmallMap<PathBuf, Vec<Diagnostic>>) {
+    fn publish_diagnostics(
+        &self,
+        diags: SmallMap<PathBuf, Vec<Diagnostic>>,
+        version_info: &HashMap<PathBuf, i32>,
+    ) {
         for (path, diags) in diags {
             let path = std::fs::canonicalize(&path).unwrap_or(path);
             match Url::from_file_path(&path) {
-                Ok(uri) => self.publish_diagnostics_for_uri(uri, diags, None),
+                Ok(uri) => {
+                    self.publish_diagnostics_for_uri(uri, diags, version_info.get(&path).copied())
+                }
                 Err(_) => eprint!("Unable to convert path to uri: {path:?}"),
             }
         }
@@ -1218,7 +1224,8 @@ impl Server {
                 let handle = make_open_handle(&self.state, path);
                 Self::append_unreachable_diagnostics(transaction, &handle, diagnostics);
             }
-            self.connection.publish_diagnostics(diags);
+            self.connection
+                .publish_diagnostics(diags, &*self.version_info.lock());
         };
 
         match possibly_committable_transaction {
@@ -1570,6 +1577,7 @@ impl Server {
         self.version_info.lock().remove(&uri);
         let open_files = self.open_files.dupe();
         open_files.write().remove(&uri);
+        // TODO: should we use the last version or None?
         self.connection
             .publish_diagnostics_for_uri(params.text_document.uri, Vec::new(), None);
         let state = self.state.dupe();