Don't early return in expr_infer_type_info_with_hint

Summary:
We need to be really careful about early returns in `expr` code, because there
are side-effects due to type tracing.

Literal string method support added an early return instead of using
structured control flow, which turned off type tracing for the methods of
string literals.

Reviewed By: rchen152

Differential Revision: D80376724

fbshipit-source-id: 6313de2b8fd5c0cd233db984349ebfececab9682

Author: stroxler

pyrefly/lib/alt/expr.rs

@@ -238,15 +238,14 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
                 let attr_type = self.attr_infer(&base, &x.attr.id, x.range, errors, None);
                 if base.ty().is_literal_string() {
                     match attr_type.ty() {
-                        Type::BoundMethod(method) => {
-                            return attr_type
-                                .clone()
-                                .with_ty(method.with_bound_object(base.ty().clone()).as_type());
-                        }
-                        _ => {}
+                        Type::BoundMethod(method) => attr_type
+                            .clone()
+                            .with_ty(method.with_bound_object(base.ty().clone()).as_type()),
+                        _ => attr_type,
                     }
+                } else {
+                    attr_type
                 }
-                attr_type
             }
             Expr::Subscript(x) => {
                 // TODO: We don't deal properly with hint here, we should.