Skip to content

Commit eef3d1d

Browse files
stroxlermeta-codesync[bot]
authored andcommitted
Add pytest back to the blocklist
Summary: I did a round of pruning the nondeterminism blocklist recently because having too many packages in it makes the regression checks less powerful and also makes it harder to stress-test potential determinism improvements. But there's always a risk of pruning packages that are actually nondeterministic; I think this is particularly possible because the full mypy primer CI job runs massively in parallel, creating a ton of resource contention that a smaller stress-test might not (plus CI machines are sometimes pretty wimpy). I've been seeing periodic - although relatively rare - nondeterminism on pytest so I think we need to add it back. Reviewed By: rchen152 Differential Revision: D91730726 fbshipit-source-id: 0eb011cb859bd4ff9cda7d3b78562f5782e8cad5
1 parent 981ee3d commit eef3d1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/mypy_primer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
--new $GITHUB_SHA --old base_commit \
6262
--num-shards 10 --shard-index ${{ matrix.shard-index }} \
6363
--debug \
64-
--project-selector '^(?!.*(python-attrs/attrs|scipy/scipy|scikit-learn/scikit-learn|pandas-dev/pandas|google/jax|apache/spark|spack/spack|sympy/sympy|PyCQA/flake8-pyi|Gobot1234/steam\.py|rotki/rotki|enthought/comtypes))' \
64+
--project-selector '^(?!.*(python-attrs/attrs|scipy/scipy|scikit-learn/scikit-learn|pandas-dev/pandas|google/jax|apache/spark|spack/spack|sympy/sympy|PyCQA/flake8-pyi|Gobot1234/steam\.py|rotki/rotki|enthought/comtypes|pytest-dev/pytest))' \
6565
--type-checker pyrefly \
6666
--output concise \
6767
| tee diff_${{ matrix.shard-index }}.txt

0 commit comments

Comments
 (0)