Merge pull request #114 from facebook/scroll-bug

jaredly · jaredly · commit 32ff902f5696 · 2015-08-04T15:38:59.000-07:00
fixes #112; scroll + hover bug
diff --git a/frontend/Node.js b/frontend/Node.js
@@ -50,8 +50,8 @@ class Node {
     }
   }
 
-  componentDidUpdate() {
-    if (this.props.selected) {
+  componentDidUpdate(prevProps) {
+    if (this.props.selected && !prevProps.selected) {
       this.ensureInView();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ class Node {`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
`53`		`- componentDidUpdate() {`
`54`		`- if (this.props.selected) {`
	`53`	`+ componentDidUpdate(prevProps) {`
	`54`	`+ if (this.props.selected && !prevProps.selected) {`
`55`	`55`	`this.ensureInView();`
`56`	`56`	`}`
`57`	`57`	`}`