nits and comments

Author: jaredly

frontend/PropState.js

@@ -13,6 +13,7 @@
 var React = require('react');
 var BlurInput = require('./BlurInput');
 var DataView = require('./DataView/DataView');
+var invariant = require('./invariant');
 
 var decorate = require('./decorate');
 
@@ -146,6 +147,8 @@ var WrappedPropState = decorate({
           store.setState(store.selected, path.slice(1), val);
         } else if (path[0] === 'context') {
           store.setContext(store.selected, path.slice(1), val);
+        } else {
+          invariant(false, "the path to change() must start wth props, state, or context");
         }
       },
       showMenu(e, val, path, name) {
@@ -160,7 +163,8 @@ var styles = {
   container: {
     padding: 3,
     fontSize: '11px',
-    fontFamily: 'Menlo, monospace',
+    // TODO figure out what font Chrome devtools uses on Windows
+    fontFamily: 'Menlo, Consolas, monospace',
     overflow: 'auto',
     flex: 1,
     display: 'flex',

frontend/PropVal.js

@@ -7,8 +7,6 @@
  * of patent rights can be found in the PATENTS file in the same directory.
  *
  * @flow
- * $FLowFixMe
- * - thinks all react component classes must inherit from React.Component
  */
 'use strict';
 

frontend/Props.js

@@ -34,13 +34,13 @@ class Props {
 
     var items = [];
     names.slice(0, 3).forEach(name => {
-      items.push((
+      items.push(
         <span key={name} style={styles.prop}>
           <span style={styles.propName}>{name}</span>
           =
           <PropVal val={props[name]}/>
         </span>
-      ));
+      );
     });
 
     if (names.length > 3) {

frontend/SearchPane.js

@@ -35,6 +35,7 @@ class SearchPane extends React.Component {
   componentDidMount() {
     this._key = this.onDocumentKeyDown.bind(this);
     var doc = React.findDOMNode(this).ownerDocument;
+    // capture=true is needed to prevent chrome devtools console popping up
     doc.addEventListener('keydown', this._key, true);
   }
 
@@ -65,9 +66,7 @@ class SearchPane extends React.Component {
 
   cancel() {
     this.props.onChangeSearch('');
-    setTimeout(() => {
-      React.findDOMNode(this.input).blur();
-    }, 100);
+    React.findDOMNode(this.input).blur();
   }
 
   onKeyDown(key) {

frontend/Store.js

@@ -184,7 +184,7 @@ class Store extends EventEmitter {
           .map(([key, val]) => key)
           .toList();
       }
-      // $FlowFixMe
+      // $FlowFixMe this.searchRoots is not falsey
       this.searchRoots.forEach(id => {
         if (this.hasBottom(id)) {
           this._nodes = this._nodes.setIn([id, 'collapsed'], true);