Skip to content

Commit 1a6892a

Browse files
authored
Revert "Add FB only network event coverage notice (#228)"
This reverts commit c85f7e9.
1 parent 1f006e2 commit 1a6892a

File tree

9 files changed

+0
-183
lines changed

9 files changed

+0
-183
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1654,8 +1654,6 @@ grd_files_debug_sources = [
16541654
"front_end/panels/network/components/EditableSpan.js",
16551655
"front_end/panels/network/components/HeaderSectionRow.css.js",
16561656
"front_end/panels/network/components/HeaderSectionRow.js",
1657-
"front_end/panels/network/components/NetworkEventCoverageInfobar.css.js",
1658-
"front_end/panels/network/components/NetworkEventCoverageInfobar.js",
16591657
"front_end/panels/network/components/RequestHeaderSection.css.js",
16601658
"front_end/panels/network/components/RequestHeaderSection.js",
16611659
"front_end/panels/network/components/RequestHeadersView.css.js",

front_end/global_typings/react_native.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,5 @@ declare global {
2121
var reactNativeOpenInEditorButtonImage: string|undefined;
2222
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
2323
var FB_ONLY__reactNativeFeedbackLink: string|undefined;
24-
// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
25-
var FB_ONLY__enableNetworkCoverageNotice: boolean|undefined;
2624
}
2725
}

front_end/panels/network/NetworkLogView.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ import {
6565
type NetworkNode,
6666
NetworkRequestNode,
6767
} from './NetworkDataGridNode.js';
68-
import './components/NetworkEventCoverageInfobar.js';
6968
import {NetworkFrameGrouper} from './NetworkFrameGrouper.js';
7069
import networkLogViewStyles from './networkLogView.css.js';
7170
import {NetworkLogViewColumns} from './NetworkLogViewColumns.js';
@@ -572,12 +571,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
572571
this.durationCalculator = new NetworkTransferDurationCalculator();
573572
this.calculatorInternal = this.timeCalculatorInternal;
574573

575-
// [RN][FB-only] Add network event coverage info banner
576-
if (globalThis.FB_ONLY__enableNetworkCoverageNotice) {
577-
const infobar = document.createElement('devtools-network-event-coverage-infobar');
578-
this.element.appendChild(infobar);
579-
}
580-
581574
this.columnsInternal = new NetworkLogViewColumns(
582575
this, this.timeCalculatorInternal, this.durationCalculator, networkLogLargeRowsSetting);
583576
this.columnsInternal.show(this.element);
@@ -1145,12 +1138,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
11451138
this.recordingHint.contentElement.appendChild(button);
11461139
}
11471140

1148-
// [RN][FB-only] Add network event coverage info banner
1149-
if (globalThis.FB_ONLY__enableNetworkCoverageNotice) {
1150-
const infobar = document.createElement('devtools-network-event-coverage-infobar');
1151-
this.recordingHint.element.prepend(infobar);
1152-
}
1153-
11541141
this.recordingHint.show(this.element);
11551142
this.setHidden(true);
11561143
}

front_end/panels/network/components/BUILD.gn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ generate_css("css_files") {
1212
sources = [
1313
"EditableSpan.css",
1414
"HeaderSectionRow.css",
15-
"NetworkEventCoverageInfobar.css",
1615
"RequestHeaderSection.css",
1716
"RequestHeadersView.css",
1817
"RequestTrustTokensView.css",
@@ -25,7 +24,6 @@ devtools_module("components") {
2524
sources = [
2625
"EditableSpan.ts",
2726
"HeaderSectionRow.ts",
28-
"NetworkEventCoverageInfobar.ts",
2927
"RequestHeaderSection.ts",
3028
"RequestHeadersView.ts",
3129
"RequestTrustTokensView.ts",

front_end/panels/network/components/NetworkEventCoverageInfobar.css

Lines changed: 0 additions & 61 deletions
This file was deleted.

front_end/panels/network/components/NetworkEventCoverageInfobar.ts

Lines changed: 0 additions & 99 deletions
This file was deleted.

front_end/panels/network/components/components.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import * as EditableSpan from './EditableSpan.js';
66
import * as HeaderSectionRow from './HeaderSectionRow.js';
7-
import * as NetworkEventCoverageInfobar from './NetworkEventCoverageInfobar.js';
87
import * as RequestHeaderSection from './RequestHeaderSection.js';
98
import * as RequestHeadersView from './RequestHeadersView.js';
109
import * as RequestTrustTokensView from './RequestTrustTokensView.js';
@@ -14,7 +13,6 @@ import * as WebBundleInfoView from './WebBundleInfoView.js';
1413
export {
1514
EditableSpan,
1615
HeaderSectionRow,
17-
NetworkEventCoverageInfobar,
1816
RequestHeaderSection,
1917
RequestHeadersView,
2018
RequestTrustTokensView,

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2434,7 +2434,6 @@ export const knownContextValues = new Set([
24342434
'network-conditions.network-mid-tier-mobile',
24352435
'network-conditions.network-offline',
24362436
'network-conditions.network-online',
2437-
'network-event-coverage-infobar',
24382437
'network-event-source-message-filter',
24392438
'network-film-strip',
24402439
'network-hide-chrome-extensions',

scripts/eslint_rules/lib/check-license-header.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ const META_CODE_PATHS = [
8383
'entrypoints/shell/browser_compatibility_guard.ts',
8484
'global_typings/react_native.d.ts',
8585
'models/react_native',
86-
'panels/network/components/NetworkEventCoverageInfobar.ts',
8786
'panels/react_devtools',
8887
'panels/rn_welcome',
8988
'panels/timeline/ReactNativeTimelineLandingPage.ts',

0 commit comments

Comments
 (0)