Commit f2a508f
Sync fork with chromium/7103 (#170)
* Reland "Have InspectorView remove the Infobar instead of CookieControlsView"
This is a reland of commit 1ac4ec696c100a4ad50d8a951d96069f2a791d06
Original change's description:
> Have InspectorView remove the Infobar instead of CookieControlsView
>
> If CookieControlsView was responsible for listening for a
> PrimaryPageChanged event and then removing the Infobar, the infobar
> would not be removed if CookieControlsView was never created to
> listen in the first place. This is a problem because the Infobar
> might be created by the InspectorMain entrypoint which does not
> guarantee that a CookieControlsView will be created as well.
>
> By moving the listener to the InspectorView, we guarantee that the
> Infobar is removed when the user reloads the page without needing
> to open the Privacy and security panel.
>
> Bug: 400962121
> Change-Id: I612c4899e218e094fd31a3eda154ec69c20e8035
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346989
> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Joshua Thomas <masnoble@chromium.org>
Bug: 400962121
Change-Id: Id4b4c5a1e46e84877642978c3763af784ff751b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367775
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7079.0
Roll created at https://cr-buildbucket.appspot.com/build/8719879389676520017
Bug: none
Change-Id: Icf799ed3d6f0359472a841a0190dd08e291539c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375025
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* [GM3Restyling] Update WebAudio key-value pair
Before: https://i.imgur.com/aVWAr49.png
After: https://i.imgur.com/p3UWBUC.png
Bug: 325443308
Change-Id: I603e8271493508855fabe33a45e08a36de35fbea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375503
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* [AI Assistance] Ignore AI Assistance selectors
Fixed: 405049967
Change-Id: I4c254f2787a367d4dba8d96ae07c462a98f6f622
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375523
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
* Temporarily add logging to `loadLegacyModule` to investigate test timeouts on bots
Bug: 345556266
Change-Id: I8b1f95389bfb22d388747f6251a7959b44d1e294
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375263
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
* [PatchWidget] Update known context values for patch widget and combined diff view
Bug: none
Change-Id: I4aa03ebf9a89794d4ad36b029233ab44be59dadf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376067
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
* Prevent default in tooltip hotkeys
Fixed: 404535134
Change-Id: Id1930b7023938154a1b46348b6c2170eab89d66c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368838
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
* [RPP] Hover/click on 3P table and 3P grouped AggregatedTimelineTreeView
includes `SyntheticNetworkRequests`
Because tree views only consider events on the Main thread, we need to
make an exception for when considering 3P (as this includes network requests). So on hover/click we should include network requests for
completion using the entity mapper.
https://screencast.googleplex.com/cast/NjIyNjk4NzE1OTkxMjQ0OHxjYzJhYjc2MS05Nw
Bug: 394651390
Change-Id: I5d127a6dce58bd54a7fbbfeabd4401753b8f3bf8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6374483
Commit-Queue: Adriana Ixba <aixba@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
* RPP: More explanatory comments for TimelineTreeView
Bug: 394651390
Change-Id: I05d15ba3f0e2ff2e6a7b3fb9414f4cc5bba27557
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6373790
Commit-Queue: Adriana Ixba <aixba@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Adriana Ixba <aixba@chromium.org>
* [docs] Add more documentation for `npm run build`.
Specifically document the Linux specific limits for `inotify` which
one can easily run into when combining `npm run build -- --watch`
and VS code.
Bug: 404192426
Change-Id: Idf301cb2e773325b2d299e61e879f85541551aa4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376063
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
* Fix missing styles for interest group empty state
After dropping the `adoptedStyleSheets` the styles went missing for
the interest group tab's empty state. This CL moves the rendering
of the empty state into the main `render` method, under which we also
include the correct styles.
Before: https://i.imgur.com/N3xS6DM.png
After: https://i.imgur.com/3W26pvn.png
Bug: none
Change-Id: If8eed04ec054e199d08053337cd3e6b2d3112c5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376103
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
* [RPP] Improve performance of singleton overlays
Every call to `add` a new overlay would iterate over all existing
overlays to manage singletons specially. For an extreme case of ~70k
overlays, this resulted in ~22s of extra processing time on my M1 Mac.
This CL reduces it down to 5ms by simply storing singleton overlays in
a map for constant time lookup.
Example trace w/ many overlays on 3p insight: https://trace.cafe/t/V7sS5bz7F0
Bug: 40278532
Change-Id: Ia8b76892e4f22f1a60215fffcc999fb4862121a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376737
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7080.0
Roll created at https://cr-buildbucket.appspot.com/build/8719822769335182177
Bug: none
Change-Id: Ie9c412cdf016ba0316c50e4e2fd9e4a1f2276bc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6377848
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* AI: manually strip 5 backticks from LLM response in Insights agent
See bug for context, we sometimes see the LLM wrap its response in 5
backticks for no apparent reason. We're going to sync with the Aida
folks to see if we can understand why or fix this on their side, but for
now a fix is also to strip the 5 backticks if they are found in the
response.
Bug: 405054694
Change-Id: Ieb7499af142f7f7cba9ffea999729f49e1fbe536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375525
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* [CombinedDiffView] Render workspace relative URL or full display name
Fixed: 405095525
Change-Id: I547dc6bb01c06a77147c2967fae1230dcb42a2eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376066
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
* RPP: add rich tooltip to annotation label generation
Fixed: 405061222
Change-Id: I3a7bc85e40512e3f9de244a0258377b9e3da2077
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375726
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
* Try to deflake RPP landing page test
This has flaked a few times. Trying to see if this retry function will
improve its stability, as we have quite a few rAFs to try to make this
test work.
Bug: 405356930
No-Presubmit: True
No-Tree-Checks: True
No-Try: True
Change-Id: Ib9864aef67413ef1d3fa36d99359e8756b6626cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381858
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8719788792218476385
R=devtools-waterfall-sheriff-onduty@rotations.google.com
Bug: none
Change-Id: Ic9b4442aecfc18ffaf55966d2737fe4ff870395b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381836
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* RPP: add auto-annotation label generation
Fixed: 405061899
Change-Id: Idf06927221664dfa45a1ba3215fb5f2a6ad99084
Also-by: alinavarkki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381853
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
* Fix dialog width for undocked DevTools
Bug: none
Change-Id: I819e3671f84eade93c5e3014a08b8b208cf4e5a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382413
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
* Also test protocol monitor autocomplete
Bug: none
Change-Id: I88792c9561ab7950063335c9b949a7d10e6a5ae9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330113
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
* RPP: hide auto-annotations behind feature flag
Bug: none
Change-Id: I44314f07516a6444b18bfc877efb1e0c0488fac8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383675
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7082.2
Roll created at https://cr-buildbucket.appspot.com/build/8719732170690310641
Bug: none
Change-Id: I20016dec784528efaf22d90184e369d3bd1d1c7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383277
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7083.0
Roll created at https://cr-buildbucket.appspot.com/build/8719698197868596177
Bug: none
Change-Id: I8c8977764f4698385a6df7b8a76034681273a06f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383824
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7084.0
Roll created at https://cr-buildbucket.appspot.com/build/8719641573921810753
Bug: none
Change-Id: Ia627446634cb4cd1d0e27aed2c8b1d5604f621dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381661
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* [documentation] adjust the Tshirt sizing table based on feedback from SWEs
Change-Id: If356c1c17c13741ea8571a2ee47936aaa50e2bd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Meysam Sarabadani <meysarabadani@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
* [css value tracing] No initial focus when showing trace tooltip
Fixed: 404535428
Change-Id: Ib6059ea7d278a172dc1e0880582a1a94bd255859
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372801
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7086.0
Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953
Bug: none
Change-Id: I5e61d37fff280905844083c08c8306cb3a61876e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383222
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Update DevTools DEPS (trusted)
Rolling third_party/siso: git_revision:3a38836e06344016dce6092148a07a114807f9f0..git_revision:ae99e5f46d1fbc718ad9c28bb82c16883d7de99b
Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953
Bug: none
Change-Id: I91f43bb20ce1371651cf60f1f3cecd1ebb9e7102
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383221
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* [test] Fix unit test that leak DOM state
Bug: 388730998
Change-Id: Ida1c4b447a6086c5c0cad08dfc4f2c32e8323fb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382155
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
* [cleanup] Prefer PromiseWithResolvers
This is better typed that the previous version.
Bug: none
Change-Id: I128ecbe730247676ef94460dfbcf8ef8aa1a9756
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383359
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
* Restore the scroll in all frames before taking a screenshot.
Tests run in a subframe and `scrollIntoView` could scroll the parent frame, which could change the visible portion of the test frame.
Bug: 401489541
Change-Id: I4e167448f66d5ba54414c9a9ce369e048b876921
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382080
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
* [GM3Restyling] Update Headers key value pairs
Changes the key-value pair styles in the Headers tab of the Network
panel.
Before: https://i.imgur.com/mradPDQ.png
After: https://i.imgur.com/KlwZuue.png
Bug: 325443308
Change-Id: Ic613c567c366ab440445d7f4069dcc3111e73924
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372906
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
* Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953
R=devtools-waterfall-sheriff-onduty@rotations.google.com
Bug: none
Change-Id: I8e2d761852e038207470ca63ffc1bd199df3bd85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383665
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
* [GM3Restyling] Update Layers key-value pairs (details)
Before: https://i.imgur.com/UlgRbDB.png
After: https://i.imgur.com/2uX52gQ.png
Bug: 325443308
Change-Id: Ib21229e7544102305345176e8007ec26349e043e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375527
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* RPP: auto-annotations UX improvements
1. Ensures that after the user goes through the FRE consent flow, the
empty label remains. If the user declined the consent, they can
manually edit the label. If they accepted it, the AI will generate a
label.
2. Fixed a weird bug with blurring not being so reliable by calling the
editable method ourselves. Bit of a hack, but it's safe to call again
and makes it much more robust.
3. Made the generate icon only be shown when the label is empty.
Retrying won't gain the user anything as the results will be very
similar.
Bug: 393063467
Change-Id: Ic20717f5d7c768a2b289ebd84de4cd99a1aa60c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381739
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* Remove all the references to the processed DOM fragments
Bug: 400353541
Change-Id: Ie86c6e6e8810f34ed51fd22dd43f3e62fe540534
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381538
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
* [deps] Update esbuild to 0.25.1
Drive-by: Update "@types/estree" to a newer version.
Co-Authored-By: liviurau@chromium.org
Fixed: 404582010
Change-Id: I17d7657f485860dc84c8ea256aadccf61daae83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382042
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
* Screenshot tests for the protocol monitor view
Bug: 388730998
Change-Id: I423f3d1b86938f4a683fa7a608e5a5e4d692aa9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6329382
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
* Use kB and avoid unit conversion for tables
This is to keep units from varying within the same context. This
change includes the perf panel 3P table, network & memory panel tables
Bug: 398040368
Change-Id: Ib170f2f9a1a0126c8d190698a654d84f23e0843d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6300607
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* Explain that AI features are unavailable in incognito mode
Screenshots: https://imgur.com/a/MSV1vjv
Bug: 392539164
Change-Id: Iad300778e5c0de3391237087ad92fa0014799b4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382416
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
* Update DevTools DEPS (trusted)
Rolling buildtools/linux64: git_revision:18602f6cf1168cf78302024043edc02e8bad2ffb..git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444
Rolling buildtools/mac: git_revision:18602f6cf1168cf78302024043edc02e8bad2ffb..git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444
Rolling buildtools/win: git_revision:18602f6cf1168cf78302024043edc02e8bad2ffb..git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444
Roll created at https://cr-buildbucket.appspot.com/build/8719517003575560321
Bug: none
Change-Id: I3a231e34207fe02b522b78eed62627c52113d9c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387015
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7087.0
Roll created at https://cr-buildbucket.appspot.com/build/8719517003575560321
Bug: none
Change-Id: Ic44a2aa869d62f690ca7f8ab5f096733743d2b1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387016
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* RPP: add AI support to "INP by Phase"
More optimization and work to come, but this is the first step.
Bug: 405920816
Change-Id: I14eefaebcd9577ad5757b92933976351eeb1e991
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387115
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
* Port 1 elements tests to non-hosted
Bug: 400683715
Change-Id: I2535e72ff4cdab24e8c5e3a423b6a9f65944d11d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367036
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
* [GM3Restyling] Update payload key-value pairs
Before: https://i.imgur.com/LJFe1Rv.png
After: https://i.imgur.com/qeiLbsM.png
Bug: 325443308
Change-Id: If0ca6888147ceaca898efd1994d5774a397a98eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375424
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
* Fix fonts used in keyvalue pairs
These three updates used the regular font, but we want to use the
medium for keys.
Bug: 325443308
Change-Id: Ic7961031702ee0acf7afacfe1dd5c8a26a9c9a2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387357
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* [Patch agent] Add ability to scroll to list in SelectWorkspaceDialog
Screenshots: https://imgur.com/a/1bdugN2
Fixed: 405915357
Change-Id: Ib3836c709bf78a698f5108eca07ef731906148a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387120
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
* Remove 'Floating entrypoints for AI assistance' experiment
Experiment has been enabled by default for a long time.
Bug: none
Change-Id: Icaff6f79434ad0971ab1441ad4e6e94c0268e028
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387756
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* RPP: do not pass insight details each time
Bug: 399610873
Change-Id: I4a2135c3726af3e7d356637af223de22389d2c6a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387438
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
* RPP: fix incorrectly formatted aggregate third party time
We incorrectly cast this to microsecs but the values we are reducing are
milliseconds.
Bug: 394651390
Change-Id: I20b514ea3d27b49e1707b0a9358189923199c49b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387360
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7088.0
Roll created at https://cr-buildbucket.appspot.com/build/8719460381265138641
Bug: none
Change-Id: I3b101110a3ec57cbfcb92ff07bf4deb71c03a768
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6389080
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Remove top padding in infobar for alignment
Bug: none
Change-Id: Ib96c84830f8b4025bc0cf401e55144cbaa9cce86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387718
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
* Hide media player sidebar if no players are registered
Before: https://i.imgur.com/Jd8Io9y.png
After: https://i.imgur.com/jlkNhkw.png
Bug: 400383914
Change-Id: I770ee01489ecce9fb24e8f83e36db89ea45ad02c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387322
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* [unit] log browser output
Bug: none
Change-Id: I8aabb82379cabe1939e05a55d04cc61d715b2c21
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387802
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
* Use default slot for the adorner content
This makes it easier to specify the content in the template
Bug: 301364727
Change-Id: I8b16c253eb222d28062b734cab196b24ae5ed0fa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6388135
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
* Support ToolbarInput and Adorner in the preferTemplateLiterals
Bug: 400353541
Change-Id: Ibb13f752eb215b3a01b8d0ad16ced080b98a68ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387797
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
* [css value tracing] evaluate percentages in longhands
This adds support for evaluating <percentage> units in css value
tracing, but only for longhands. For shorthands, we need additional reasoning about which longhand the unit pertains to in order to understand whether it's relative to a width or a height.
Bug: 401213719
Change-Id: I823ef9d52bb12ab40e7bcabce770733ad36a51b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376104
Reviewed-by: Eric Leese <leese@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
* Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8719460381265138641
R=devtools-waterfall-sheriff-onduty@rotations.google.com
Bug: none
Change-Id: I2c7b312112dc073c76bf5dd457b2b855f11f3050
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6389081
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* [RPP][AI] Remove button flickering and fix button visibility bug
Only animating the width gets rid of the flickering.
Also fix the button not disappearing the the label is not empty.
Before: https://screencast.googleplex.com/cast/NDcxMjU2ODAzNDY4OTAyNHw0MmRjMjdhMi03MA
After: http://screencast/cast/NjI2NTUzNTgwMDAxNjg5Nnw3Nzg3M2Y3Yy02Mg
Bug: 405980546
Change-Id: I7fbf4a57cf1562ada7a708627a877b61c688cb1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387104
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
* Provide mocha context to it.only function
On e2e_non_hosted tests it.only fails with:
`ReferenceError: mocha is not defined`
Bug: 400683715
Change-Id: I576eb03f5f007e032a772a3230802c06e9443812
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387109
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
* [AI Assistance] Stash Inspector protocol changes
Stash inspector protocol changes while waiting for writing to disc.
Uses git like names for convenience.
Fixed: 399561324
Change-Id: I65b97df4aaa94ef652b898de38d3c7b0d76b1093
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387119
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
* Remove the adorner from ToolbarButton, and its last client — last year's easter egg.
Bug: 301364727
Change-Id: I5295318d006b1b59c7645edd4470a6f129be38ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387325
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
* [npm] Port `npm start` to JavaScript.
There's no point in writing this one script in Python. It's much better
to have it in JavaScript, just like `npm run build`.
Bug: 404192426
Change-Id: Ic19eaeb5b1d97ca750ae4253963b8434072d00fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387801
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
* [RPP] Button hover state
Bug: 405916098
Change-Id: Ib7dd95d38edb806620d68b07af97a7702e7204d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387364
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* [cleanup] Fix yargs type
Uses ParseSync else the result is Promise<T> | T.
This give IDE better types to work with.
Bug: none
Change-Id: I4d6014aeccd7428ec03bfde90c5d728c6182c1f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387381
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
* Display css function rules in Elements panel
Bug: 392034817
Change-Id: I589055e527364996c346b37bb760c654a39bc1fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6308828
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
* [cleanup] Don't declare default in constructor (#1)
This moves some of the default from the constructor
to the declaration methods, this requires less space and
also point easier to what is coming from outside and what
the constructor is doing.
Bug: 397260638
Change-Id: I67a00b28e2cc92394e4bceca431b3d6f662a7537
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6377983
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
* AI: change Insights AI prompt
Following feedback and iterations from Gemini. Needs more testing but
initial results are promising in terms of more consistent output.
Bug: 404834406
Change-Id: I2a46138ffa8020bf2447b08ec391746ffb56150d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6388120
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* [Perf panel] Remove support for experimental server timings track
We did not receive clear signal about the usefulness of having a mechanism to display server timings in the client timeline.
Developers will still be able to see server timings in the details of network requests (as of https://crrev.com/c/6387100) and if needed, a server timing track could be injected using the extensibility API. (granted, a mechanisim to map server timestamps to the client clock needs to be implemented, but this doesn't seem to be a big constraint as devs are alreading doing so, like React).
Bug: 403223638
Change-Id: I10d80fe10598dcf7c3014cfc1fcbce03b6024fb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387102
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
* Remove 'autofill-view' experiment
Experiment has been enabled by default for a long time.
Bug: none
Change-Id: I3a1e7756197a438c2257a642fa61c60817c0f0f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387440
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* [Perf panel] Render server timings in network request event details
Took the chance to adjust the layout of the component to resemble latest designs:
https://www.figma.com/design/YzfTbApaJu7ZnKpZGSAwjH/RPP?node-id=9477-294967&t=IQSeyjtLhrpWLcuN-1
Screenshot: https://screenshot.googleplex.com/8wSC885V89XzXXC
Bug: 340811171
Change-Id: I1fba2ea944f66f61a13d8037fd2b441bdaaf96ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387100
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
* [RPP] Make events searchable by top level properties when on debug mode
I find myself frequently making this change to my local checkout to be
able to easily find events when debugging the panel (e.g. looking up an
event by timestamp). I figured it could be useful to have it upstream.
R=paulirish@chromium.org
Bug: none
Change-Id: Iec8c953b80b59a4eec1a77d55cdf909af1a75042
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387355
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
* Add more experiment flags to start script
Bug:none
Change-Id: Iec3215c9dd003b2eaa71b9062db045c473c1c9cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6391995
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
* Fix script to pass only non included options
This should be more correct than deleting the object above as
under some cases yargs will include the aliases
https://github.com/yargs/yargs-parser?tab=readme-ov-file#strip-aliased
Bug: none
Change-Id: I8daa2a77e4b103c516a06aaf47cdded1bf3ca605
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387922
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
* [Lighthouse] Change font to match with rest of DevTools
Before: https://i.imgur.com/mzIFQiO.png
After: https://i.imgur.com/d7siraO.png
Bug: none
Change-Id: Ia610daae00cdb5714477dde71a16f3c40c19eed0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387323
Reviewed-by: Adam Raine <asraine@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* Define window.scheduler as non-optional
We used the wicg-task-scheduling types for `window.scheduler` but it
types it as optional - this is true for the general case but because we
are in Chrome we know it exists.
Unfortunately you cannot override the member from optional or not on
`Window`, so this CL removes the use of the
`@types/wicg-task-scheduling` package and reuses the code inline with
the extension to the `Window` interface making it always present.
Bug: none
Change-Id: I8399d3477f89f88e758ed31399c6256fcbd31de9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393155
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
* [UseCache] Filter to context bounds
Bug: None
Change-Id: Id481a6bade76630433c856ec652ffc8c57608ecc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6379246
Auto-Submit: Adam Raine <asraine@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
* [elements] Update working copy from Styles tab.
When modifying CSS, the Styles tab previously wrote straight to disk
when a workspace folder was connected, instead of updating the working
copy (like the Sources panel does). This is a very inconsistent and
confusing behavior, and doesn't align with the intended use cases that
we're working on for Workspace feature.
Also show an asterisk in the Styles tab for modified CSS files, similar
to what we do in the Sources panel.
Bug: 405312529
Screenshot: https://i.imgur.com/iXDyU1S.png
Change-Id: I980cb87a8d985f4cab6b6b26fa2618ee6001d24c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382153
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* Support toolbar buttons in the preferTemplateLiterals
Tighten up types along the way.
Bug: 400353541
Change-Id: I23b644e7ebc2c19194486817ac98c39498ae1679
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387112
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
* Support class properties as DOM fragments in the preferTemplateLiterals
Bug: 400353541
Change-Id: I0d0724f752d75a262da31deaf0662221cc8442d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387921
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
* [Lighthouse] Roll Lighthouse 12.5.0
Bug: 40543651
Change-Id: I1234f71d79d2b2c053501d5dec711721f690f7dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395415
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Adam Raine <asraine@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
* Update DevTools DEPS (trusted)
Rolling third_party/siso: git_revision:ae99e5f46d1fbc718ad9c28bb82c16883d7de99b..git_revision:68bdc49e4e23aef066fc652cbdb1b4973aab1a31
Roll created at https://cr-buildbucket.appspot.com/build/8719369783692319201
Bug: none
Change-Id: I3ada400daf7731fc5b6645d6d0ce81cbb83f8596
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394708
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7090.0
Roll created at https://cr-buildbucket.appspot.com/build/8719369783692319201
Bug: none
Change-Id: Ie92ea5ccb7546fce20c117f8b56800bd6a223971
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395603
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Delete core/platform/ServerTimings
It was added in https://crrev.com/c/5783824 so that it could be used by
the perf panel trace engine. This introduced another layer over the
existing ServerTiming implementation in sdk/, which we no longer need
given that we no longer use it in the trace engine as of
https://crrev.com/c/6387102.
Fixed: 403223638
Change-Id: I97a1e7009984fadde9a67c6540cfa8ddd154af08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387103
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
* [npm] Enable Auto-annotation labeling with `npm start`.
Bug: 393063467
Change-Id: I93ce321a5d62308ca48d040697501416b0d51790
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387111
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
* [GM3Restyling] Update buttons in network payload tab
This changes two <button>s to use the Button component.
Before: https://i.imgur.com/zyw1gZ7.png
After: https://i.imgur.com/rNo5HSd.png
Bug: none
Change-Id: I8d8b094c37f91da74df85671811f2df5eea9dc1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387116
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
* [application] Add right padding to report sections and inline links
The frame details report view was previously using a separate
class for adding report sections. After changing to the general
devtools-report-section, the "learn more" link styling changed.
This CL makes sure that learn more links are in-line with the
preceding text, and adds right padding to report sections. Thus,
focus styles are also properly seen if things are narrow.
Before: https://i.imgur.com/oZowNJv.png
After: https://i.imgur.com/3WGIBBv.png
Fixed: 406226081
Change-Id: I9a7117a106e84f75f9c5b6c9338c6ac186730d86
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394676
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* Fix passing command to sub-script
https://github.com/yargs/yargs-parser?tab=readme-ov-file#strip-aliased
Bug: none
Change-Id: Ifb1a77de162ea6367ed76d7e2f6f4301d4c9890d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396776
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
* Make quick open suggestion input not tabbable
Fixes input text highlight contrast issue
Bug: 402343613
Change-Id: I960176b83408b23d6e2df7077487fba65aa41571
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396678
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
* RPP: support call tree generation (and AI labels) for hidden events
If the user turns on the "Show all events" experiment, they will see
events that are not listed in our default `visibleTypes` list. This was
problematic for the call tree generation which relies on that list to
generate the data to send to the AI for label generation and "Ask AI".
This CL now updates the implementation to filter for visible types only
when that experiment is disabled.
As a drive-by, I also wrapped the AICallTree generation in a rAF to
ensure the UI updates are snappy.
Fixed: 406004077
Change-Id: Iea80cc59771738389de77375828caee16e654f35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396679
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* [RPP][AI] Loading state for the auto-generated label
Video: http://screencast/cast/NTgwOTAwMDg1NDU4NTM0NHwzNmZkMmExNS1hZg
Bug: 405354543
Change-Id: I721d498864f8d4d23dbecbeb31164b83fe8c75dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394177
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
* Use Network projects for AI Assistance
Fixed: 406216870
Change-Id: I724e85501d7c22f6ad0db36dd7e2279ea0042b9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387356
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
* Fix delete after copy
Bug: none
Change-Id: I278b7409a86756a16e93d0ac1751ff288a74bd77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396857
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
* [RPP][AI] Hide 'Generate label' button from tracks other than Main
Bug: 406211641
Change-Id: I4722999f7ed2832dc8d5622b78611c0e040a38c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396856
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
* [npm] Fix flag name for patching.
Bug: 393063467
Change-Id: Ib439eeb44079655ff4eadc7cb8102b4f89796a70
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396858
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7091.0
Roll created at https://cr-buildbucket.appspot.com/build/8719335810148117585
Bug: none
Change-Id: I518bdd2faccc2cfc3641ef49018f24207734a0f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395610
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* Add ServiceWorker Static Routing API information in HAR.
Currently static routing api info is not available upon HAR export. So,
this cl adds following custom fields that has routing info to the HAR response and timing property.
- serviceWorkerRouterRuleIdMatched
- serviceWorkerRouterMatchedSourceType
- serviceWorkerRouterActualSourceType
- workerRouterEvaluationStart
- workerCacheLookupStart
per https://docs.google.com/document/d/1aVRdEGQiCsWjEwgU6W9Lz7b1AtxxJXybWjPkmMvYURA/edit?tab=t.0
After this CL, HAR contains ServiceWorkerRouterInfo under
response and timing fields, and the timing view shows service worker routing info (id/matched/actual/evalaution/cache lookup) when imported HAR.
Bug: 375515693
Change-Id: Ic63ccefc27edc35b3305d144bc28cb3dcff599c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6334706
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Monica Chintala <monicach@microsoft.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
* Fix overflow behavior for Interest Groups
This has been fixed here crrev.com/c/3436688 but through some
refactorings the CSS no longer applies to the correct widget.
Fixed: 402806164
Change-Id: I181a8eff68532f024a1eb99f40b48144a9a10c0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396059
Auto-Submit: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
Roll created at https://cr-buildbucket.appspot.com/build/8719335810148117585
R=devtools-waterfall-sheriff-onduty@rotations.google.com
Bug: none
Change-Id: If769a30d617ba77c8b042079d07cd2d83931be59
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395611
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
* AI: update privacy disclaimer for Performance AI assistance
Fixed: 405920760
Change-Id: I3ab52899b2df23d01f023c97f831abcd00effc89
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394238
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
* Remove `?.` that is not required.
Bug: none
Change-Id: Id054b35a49d5358be6ead822cf881d3b489eb6e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397056
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
* [AI Assistance] Copy whole working file
Get the working copy based on file name we previously provided.
Fixed: 406217573
Change-Id: I097ea3ee6e85e97251ed1ee22041ef9a4e071d97
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396061
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
* Set trace timeouts for Lantern tests
They timed out at 5s in
https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/19959/overview,
but they do not have the larger timeout that we set for trace parsing
tests.
Bug: none
Change-Id: Ief62eb0159c090a4ac44b72b3b5032ac55c64ea4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397055
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
* [cleanup] Use JS private for UISourceCode
This makes it easier to follow properties, remove the `internal`
suffix and fixes typos
Bug: none
Change-Id: I05ac6d0133551011978a61e713a89a7d4dfe76a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395500
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
* RPP: improve performance of expanding 3P insight
This CL tries to improve the performance of expanding the 3P insight
which was very slow. This was down to a couple of factors:
1. For a problematic trace, we were creating over 40k overlays. Overlays
are DOM elements and handling that many is a very intensive job. Most
of these overlays were tiny. This CL updates the code to only create
overlays for events of 1ms or more.
2. The additional work to generate, update and then show the summary tab
was blocking the 3P insight expanding in the sidebar. This work and
the work to create the overlays is now scheduled, so we let the UI in
the sidebar update first.
Some numbers from a problematic trace in the associated bug.
BEFORE
1. Time to handle dispatchInsightToggle (user click event): 118ms
2. Time to render overlays, dimming, summary drawer w/ 1/3P table: 1.05s
3. INP for clicking to expand the 3P Insight: 170ms
AFTER
1. Time to handle dispatchInsightToggle (user click event): 2.31ms
2. Time to render overlays, dimming, summary drawer w/ 1/3P table: 407ms
3. INP for clicking to expand the 3P Insight: 59ms
4. In this version the overlays & dimming are scheduled, as are
the summary drawer & 1/3P table, so it feels much snappier to the
user as we draw the updates w/ the insight expanded much quicker.
So there is plenty more we can do (407ms is slow to do all that work in)
but we have taken the total time of work from ~1.16s down to ~409ms.
Bug: 404884558
Change-Id: I55f38cb14e53998f90be497aec97c0b9f1fc9345
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387796
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
* Extract DOM fragment and AST libraries from preferTemplateLiterals rule
Bug: 400353541
Change-Id: Id52ceaa205579096a7b9d845bc3d521a3e7bb303
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396062
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
* [GM3Restyling] Update Performance flame chart tooltip styles
Screenshot: https://imgur.com/a/DrPAtHE
Bug: 406466030
Change-Id: Ic43622bf72aea0e9de25c419b2b83799b968be2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397058
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
* [RPP] Tweak column for DuplicatedJavaScript; styling for sub-items
https://i.imgur.com/CJJu8Ok.png
Bug: 394373632
Change-Id: I5e74ff18b8797ea48f2aecc0c2ffbd97e39c47ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393949
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
* [RPP] Use modern HTTP insight
https://screenshot.googleplex.com/8fMuNY5mgW7SdGq
Also adds the protocol to the network request details
Bug: 404926025
Change-Id: If026e83b27c493f2dd27089ea83a83d4436f39d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6378828
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
* [Lighthouse] Roll Lighthouse 12.5.1
Bug: 40543651
Change-Id: Id022662b3b9587789e24721e6797de0731e8da63
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6398222
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Adam Raine <asraine@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
* Update Chrome (for Testing) PIN
Chromium pin updated to 136.0.7092.0
Roll created at https://cr-buildbucket.appspot.com/build/8719279187825753585
Bug: none
Change-Id: I496598105fb3d539693ed0cb4eed35280d2d1a5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6399018
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
* [css] Track inspector stylesheets in service projects.
Previously the inspector stylesheets were added to the network projects
were the regular CSS resources also end up, but this way they show up
in the Page tree and look as if they are resources served from the page
even though they are not.
With this change we introduce a dedicated project type ('inspector') and
track them via dedicated service projects, similar to what we do for
transient `debugger:///VM<ID>` scripts.
Screenshot: http://screen/7daQT5GYhEXTcmf.png
Fixed: 406453050
Bug: 40803732
Change-Id: I9ac803a1e3a659031cfb6a016e96e688e80550be
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396060
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
* Rename UseCache insight to Cache
For naming consistency, we are sticking to just nouns for insights. This
was the only insight that used a verb.
Bug: none
Change-Id: I914a7eb5ef556022e2fae49459e37f69e47736e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397503
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
* Use correct package for JavaScript natives
We never install the packages mentioned in that package json
but rely on the node_modules one, so removed.
Also update the packages and types
Bug: none
Change-Id: I0676c36621f39bff7408c5b910f5e4461f3f0158
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394480
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
* [RPP] Update sample trace id parsing
As of https://crrev.com/c/6397026 the shape of trace id in CPU profile
changed to a traceid -> node id mapping (before it was sample index ->
traceid). This allows us to simplify their parsing as they are we no
longer need to get the stack data (node id) via the sample index,
effectively removing a level of indirection and preventing bugs due to
the samples order being altered in the frontend (see attached bug).
Fixed: 403628855
Change-Id: I1d56ce8aa6414798a95a20b5dbcd9ecb871043f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394268
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
* [RPP] Exclude extensions from Duplicated JavaScript insight
Bug: 394373632
Change-Id: I5de1420c7a5294f3c95e767971b57d8d1ae9bc9f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393951
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
* [cleanup] Remove `styles-pane-css-changes` experiment.
The feature hasn't been actively developed and maintained, and is mostly
broken by now. It also has unclear implications for how we think about
Workspaces and the Patch Agent integration with Freestyler these days.
Therefore I'm removing the support for the experiment.
Later this year we will likely start investigating a solution which
tracks changes to the CSSOM (by DevTools) and provides users with the
ability to "sourcify" and persist them to their project.
Fixed: 40803732
Bug: 406453050
Change-Id: I5f40617402f8f0efe53797b4e87f4a97680f575b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394479
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
* RPP: experiment with prompting to improve labels + call frame analysis
Bug: 400357484
Change-Id: I55e11343f93618b3c80d6fb6f0b0c7dcd69fce66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394477
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
* Fix checkbox focus styles in devices settings tab
This removes custom focus styles for checkboxes for the devices tab
that are no longer needed with the general styles.
Before: https://i.imgur.com/IVOFhoq.png
After: https://i.imgur.com/LsgJI4Q.png
Fixed: 390135039
Change-Id: Ib420509a7341beb012edc80d6cb38a6075e53936
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396864
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
* [cleanup] Remove unused disable comments
This is already the case with EsLint, and it prevent issues
from being masked by accident.
Bug: 397260638
Change-Id: Ibcc80b76118bd398ae48447a827963c18a2a8f56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397061
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
* RPP: add label to FRE dialog for auto annotations
Fixed: 406541372
Change-Id: I054a33b806f73f1346d8abebf62c48aa51ecd8dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401153
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
* [PatchWidget] Update texts and disclaimer
Fixed: 406216564
Change-Id: Ie89e078eaedf91a07845e638cecdb2cb868fa8ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400634
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
* DirectSocket TCP panel #1
DirectSocket TCP protocol methods are added to NetworkManager.ts with
tests. The next CL will add necessary panels to UI.
The related commit in chromium -
https://chromium-review.googlesource.com/c/chromium/src/+/6308994
Design Document: go/chrome-devtools:directsockets-design
Bug: 358327120
Change-Id: I59f6c213f44db29ba4b2563d15d081c9c407a512
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6316791
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Vlad Krot <vkrot@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
* Update Protocol
Bug: chromium:401011862
Change-Id: I3c0032666c3b1cee1e5c6169878cb7cb214c95e7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395222
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
* [GM3Restyling] Update Popover Helper usages
Screenshot: https://imgur.com/a/J3ewzJ2
Bug: 406664599
Change-Id: I6d90f444824158af688f6d233a68d77f0e2cff5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396865
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
* RPP: improve keyboard experience of annotations
This CL makes it so that when you tab into the annotation, you…1 parent 41bf86b commit f2a508f
File tree
26,247 files changed
+2791425
-1136466
lines changed- .github/workflows
- .vscode
- build_overrides
- config
- gni
- owner
- typescript
- docs
- checklist
- images
- contributing
- images
- cookbook
- images
- ecosystem
- images
- images
- policy
- images
- styleguide
- tsstyle
- ux
- images
- extension-api
- extensions/cxx_debugging
- e2e
- standalone
- src
- tests
- inputs
- third_party
- lit-html
- lldb-eval
- llvm
- tools
- front_end
- Images
- src
- core
- common
- dom_extension
- host
- i18n
- locales
- platform
- protocol_client
- rn_experiments
- root
- sdk
- entrypoints
- device_mode_emulation_frame
- devtools_app
- formatter_worker
- heap_snapshot_worker
- inspector_main
- js_app
- lighthouse_worker
- main
- node_app
- rehydrated_devtools_app
- rn_fusebox
- rn_inspector
- shell
- wasmparser_worker
- worker_app
- generated
- global_typings
- legacy_test_runner
- application_test_runner
- axe_core_test_runner
- bindings_test_runner
- data_grid_test_runner
- device_mode_test_runner
- elements_test_runner
- heap_profiler_test_runner
- layers_test_runner
- network_test_runner
- performance_test_runner
- sdk_test_runner
- security_test_runner
- sources_test_runner
- test_runner
- legacy
- models
- ai_assistance
- agents
- data_formatters
- autofill_manager
- bindings
- breakpoints
- cpu_profile
- crux-manager
- emulation
- extensions
- formatter
- har
- heap_snapshot_model
- issues_manager
- descriptions
- javascript_metadata
- live-metrics
- web-vitals-injected
- spec
- logs
- persistence
- project_settings
- react_native
- source_map_scopes
- text_utils
- timeline_model
- trace
- extras
- handlers
- helpers
- insights
- lantern
- core
- graph
- metrics
- simulation
- testing
- types
- root-causes
- types
- workspace_diff
- workspace
- panels
- accessibility
- ai_assistance
- components
- animation
- application
- components
- preloading
- components
- autofill
- browser_debugger
- changes
- common
- console_counters
- console
- coverage
- css_overview
- components
- developer_resources
- elements
- components
- emulation
- components
- event_listeners
- explain
- components
- freestyler
- components
- issues
- components
- js_timeline
- layer_viewer
- layers
- lighthouse
- linear_memory_inspector
- components
- media
- mobile_throttling
- network
- components
- forward
- performance_monitor
- profiler
- protocol_monitor
- components
- react_devtools
- recorder
- components
- controllers
- converters
- extensions
- injected
- selectors
- models
- recorder-actions
- testing
- util
- rn_welcome
- screencast
- search
- security
- sensors
- settings
- components
- emulation
- components
- utils
- snippets
- sources
- components
- timeline
- components
- insights
- docs
- extensions
- fixtures/traces
- lantern/typescript-angular
- scripts
- overlays
- components
- track_appenders
- utils
- utils
- web_audio
- graph_visualizer
- webauthn
- whats_new
- resources
- services
- puppeteer
- trace_bounds
- tracing
- testing
- third_party
- acorn
- axe-core
- chromium/client-variations
- codemirror.next
- chunk
- codemirror
- csp_evaluator
- diff
- i18n
- intl-messageformat
- package
- json5
- lib
- package/lib
- legacy-javascript
- lib
- lighthouse
- locales
- report-assets
- report
- lit
- lib
- src
- lodash-isequal
- package
- marked
- puppeteer-replay
- package
- lib
- cjs
- puppeteer
- package
- lib/cjs/puppeteer
- api
- locators
- bidi
- core
- cdp
- common
- generated
- injected
- node
- util
- util
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
26,247 files changed
+2791425
-1136466
lines changedThis file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | | - | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | 27 | | |
| 28 | + | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
0 commit comments