Skip to content

Commit 5c49927

Browse files
Naming inconsistency causing build failure in Android Java file. (#3678)
* Android Java build fail file CenteredText.java in class name is CenteredText. However, in the CenteredTextManager.java file, we used the name RTNCenteredText instead of CenteredText. This is causing issues when trying to create a fabric component, as the build fails when updating the class name to CenteredText. Everything works fine when using the correct class name. * Update pillars-fabric-components.md Naming inconsistency issue fixed in 0.70.0 version * Update pillars-fabric-components.md Naming inconsistency updated version 0.70.0 * Update pillars-fabric-components.md Naming inconsistency updated name * Update pillars-fabric-components.md VERSION 0.70.0 there is classname itself RTNCenteredText so We don't need to update
1 parent bcd8b65 commit 5c49927

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

docs/the-new-architecture/pillars-fabric-components.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -749,10 +749,10 @@ import com.facebook.react.viewmanagers.RTNCenteredTextManagerInterface;
749749
import com.facebook.react.viewmanagers.RTNCenteredTextManagerDelegate;
750750

751751
@ReactModule(name = CenteredTextManager.NAME)
752-
public class CenteredTextManager extends SimpleViewManager<RTNCenteredText>
753-
implements RTNCenteredTextManagerInterface<RTNCenteredText> {
752+
public class CenteredTextManager extends SimpleViewManager<CenteredText>
753+
implements RTNCenteredTextManagerInterface<CenteredText> {
754754

755-
private final ViewManagerDelegate<RTNCenteredText> mDelegate;
755+
private final ViewManagerDelegate<CenteredText> mDelegate;
756756

757757
static final String NAME = "RTNCenteredText";
758758

@@ -762,7 +762,7 @@ public class CenteredTextManager extends SimpleViewManager<RTNCenteredText>
762762

763763
@Nullable
764764
@Override
765-
protected ViewManagerDelegate<RTNCenteredText> getDelegate() {
765+
protected ViewManagerDelegate<CenteredText> getDelegate() {
766766
return mDelegate;
767767
}
768768

@@ -774,13 +774,13 @@ public class CenteredTextManager extends SimpleViewManager<RTNCenteredText>
774774

775775
@NonNull
776776
@Override
777-
protected RTNCenteredText createViewInstance(@NonNull ThemedReactContext context) {
778-
return new RTNCenteredText(context);
777+
protected CenteredText createViewInstance(@NonNull ThemedReactContext context) {
778+
return new CenteredText(context);
779779
}
780780

781781
@Override
782782
@ReactProp(name = "text")
783-
public void setText(RTNCenteredText view, @Nullable String text) {
783+
public void setText(CenteredText view, @Nullable String text) {
784784
view.setText(text);
785785
}
786786
}

website/versioned_docs/version-0.71/the-new-architecture/pillars-fabric-components.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -749,10 +749,10 @@ import com.facebook.react.viewmanagers.RTNCenteredTextManagerInterface;
749749
import com.facebook.react.viewmanagers.RTNCenteredTextManagerDelegate;
750750

751751
@ReactModule(name = CenteredTextManager.NAME)
752-
public class CenteredTextManager extends SimpleViewManager<RTNCenteredText>
753-
implements RTNCenteredTextManagerInterface<RTNCenteredText> {
752+
public class CenteredTextManager extends SimpleViewManager<CenteredText>
753+
implements RTNCenteredTextManagerInterface<CenteredText> {
754754

755-
private final ViewManagerDelegate<RTNCenteredText> mDelegate;
755+
private final ViewManagerDelegate<CenteredText> mDelegate;
756756

757757
static final String NAME = "RTNCenteredText";
758758

@@ -762,7 +762,7 @@ public class CenteredTextManager extends SimpleViewManager<RTNCenteredText>
762762

763763
@Nullable
764764
@Override
765-
protected ViewManagerDelegate<RTNCenteredText> getDelegate() {
765+
protected ViewManagerDelegate<CenteredText> getDelegate() {
766766
return mDelegate;
767767
}
768768

@@ -774,13 +774,13 @@ public class CenteredTextManager extends SimpleViewManager<RTNCenteredText>
774774

775775
@NonNull
776776
@Override
777-
protected RTNCenteredText createViewInstance(@NonNull ThemedReactContext context) {
778-
return new RTNCenteredText(context);
777+
protected CenteredText createViewInstance(@NonNull ThemedReactContext context) {
778+
return new CenteredText(context);
779779
}
780780

781781
@Override
782782
@ReactProp(name = "text")
783-
public void setText(RTNCenteredText view, @Nullable String text) {
783+
public void setText(CenteredText view, @Nullable String text) {
784784
view.setText(text);
785785
}
786786
}

0 commit comments

Comments
 (0)