Skip to content

Commit 0b5c1a9

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Fix publish-updated-packages-test (#54012)
Summary: Pull Request resolved: #54012 Differential Revision: D83667870
1 parent 7dc26f5 commit 0b5c1a9

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

scripts/releases-ci/publish-updated-packages.js

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,28 +65,26 @@ async function publishUpdatedPackages() {
6565
const packagesToUpdate = [];
6666

6767
await Promise.all(
68-
Object.values(packages).map(async package => {
69-
const version = package.packageJson.version;
68+
Object.values(packages).map(async pck => {
69+
const version = pck.packageJson.version;
7070

7171
if (!version.startsWith('0.')) {
7272
throw new Error(
7373
`Package version expected to be 0.x.x, but received ${version}`,
7474
);
7575
}
7676

77-
const response = await fetch(
78-
'https://registry.npmjs.org/' + package.name,
79-
);
77+
const response = await fetch('https://registry.npmjs.org/' + pck.name);
8078
const {versions: versionsInRegistry} = await response.json();
8179

8280
if (version in versionsInRegistry) {
8381
console.log(
84-
`- Skipping ${package.name} (${version} already present on npm)`,
82+
`- Skipping ${pck.name} (${version} already present on npm)`,
8583
);
8684
return;
8785
}
8886

89-
packagesToUpdate.push(package.name);
87+
packagesToUpdate.push(pck.name);
9088
}),
9189
);
9290

@@ -97,19 +95,17 @@ async function publishUpdatedPackages() {
9795
const failedPackages = [];
9896

9997
for (const packageName of packagesToUpdate) {
100-
const package = packages[packageName];
101-
console.log(
102-
`- Publishing ${package.name} (${package.packageJson.version})`,
103-
);
98+
const pck = packages[packageName];
99+
console.log(`- Publishing ${pck.name} (${pck.packageJson.version})`);
104100

105101
try {
106-
runPublish(package.name, package.path, tags);
102+
runPublish(pck.name, pck.path, tags);
107103
} catch {
108104
console.log('--- Retrying once! ---');
109105
try {
110-
runPublish(package.name, package.path, tags);
106+
runPublish(pck.name, pck.path, tags);
111107
} catch (e) {
112-
failedPackages.push(package.name);
108+
failedPackages.push(pck.name);
113109
}
114110
}
115111
}

0 commit comments

Comments
 (0)