Skip to content

Commit 0d068a5

Browse files
Antoine Doubovetzkyfacebook-github-bot
authored andcommitted
(AppState) remove outdated TODO (#34264)
Summary: We are already returning the `remove` function, and the `removeEventListener` method has been removed in this PR: #33580. So I believe this comment is now outdated and no longer relevant. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Removed] - Remove outdated TODO in AppState Pull Request resolved: #34264 Reviewed By: dmitryrykun Differential Revision: D38120344 Pulled By: GijsWeterings fbshipit-source-id: c6c4d42f5b631a67bb6ad49c14df1a772f1cc71b
1 parent 8b174a5 commit 0d068a5

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

Libraries/AppState/AppState.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,6 @@ class AppState {
8282
}
8383
}
8484

85-
// TODO: now that AppState is a subclass of NativeEventEmitter, we could
86-
// deprecate `addEventListener` and `removeEventListener` and just use
87-
// addListener` and `listener.remove()` directly. That will be a breaking
88-
// change though, as both the method and event names are different
89-
// (addListener events are currently required to be globally unique).
9085
/**
9186
* Add a handler to AppState changes by listening to the `change` event type
9287
* and providing the handler.

0 commit comments

Comments
 (0)