Commit 2bc6b00
Fixed symbol mapping to slices (#54641)
Summary:
Previously the symbolication support when using the precompiled React.XCFramework copied the symbol bundles to the wrong folder in the framework, causing Xcode to not find the symbols.
This commit fixes this by copying symbols to the correct slice folders instead of in the root of the framework folder.
Note:
Running `pod cache clean --all` and `rm -rf Pods` in the iOS folder followed by a clean rebuild in Xcode might be a good thing to ensure you're using the correct binaries when compiling.
## Changelog:
[IOS] [FIXED] - Fixed copying symbol bundles into correct slice folder
Pull Request resolved: #54641
Test Plan:
```
npx react-native-community/cli init Next --version next --skip-install
cd Next
yarn
cd ios
bundle install
RCT_USE_RN_DEP=1 RCT_USE_PREBUILT_RNCORE=1 RCT_SYMBOLICATE_PREBUILT_FRAMEWORKS=1 bundle exec pod install
```
Run Xcode and observe that you are not able to step into React Native source code.
After this fix, you should be able to step into the source code of React Native.
Reviewed By: cortinico
Differential Revision: D87919202
Pulled By: cipolleschi
fbshipit-source-id: 029bca3e182c170562e358beb50592d5b91d8e8b1 parent 3341bb5 commit 2bc6b00
1 file changed
+14
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
237 | 246 | | |
238 | 247 | | |
239 | 248 | | |
| |||
246 | 255 | | |
247 | 256 | | |
248 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
249 | 262 | | |
250 | 263 | | |
251 | 264 | | |
| |||
0 commit comments