Skip to content

Commit 30b088d

Browse files
huntiefacebook-github-bot
authored andcommitted
Adjust output package.json formatting in scripts (#43133)
Summary: Pull Request resolved: #43133 I noticed inconsistent handling of terminating newlines in D54006327@V1, and had also been noticing `yarn build` reformatting unrelated sections of `package.json` files. For now, this logic isn't moved to a shared util, since there will likely be a higher level abstraction for the release scripts in the next batch of improvements. Changelog: [Internal] Reviewed By: lunaleaps, cipolleschi Differential Revision: D54007565 fbshipit-source-id: 74d58362a85be4fae2f9e058b6c6622a026ff0a0
1 parent 52a70d7 commit 30b088d

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

scripts/build/build.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,7 @@ async function rewritePackageExports(packageName /*: string */) {
184184

185185
pkg.exports = rewriteExportsField(pkg.exports);
186186

187-
await fs.writeFile(
188-
packageJsonPath,
189-
prettier.format(JSON.stringify(pkg), {parser: 'json'}),
190-
);
187+
await fs.writeFile(packageJsonPath, JSON.stringify(pkg, null, 2) + '\n');
191188
}
192189

193190
/*::

scripts/releases/__tests__/__snapshots__/set-rn-version-test.js.snap

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ exports[`setReactNativeVersion should set nightly version: packages/react-native
128128
\\"dependencies\\": {
129129
\\"@react-native/package-a\\": \\"0.81.0-nightly-29282302-abcd1234\\"
130130
}
131-
}"
131+
}
132+
"
132133
`;
133134
134135
exports[`setReactNativeVersion should set release version: packages/react-native/Libraries/Core/ReactNativeVersion.js 1`] = `
@@ -259,5 +260,6 @@ exports[`setReactNativeVersion should set release version: packages/react-native
259260
\\"dependencies\\": {
260261
\\"@react-native/package-a\\": \\"1000.0.0\\"
261262
}
262-
}"
263+
}
264+
"
263265
`;

scripts/releases/set-rn-version.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ async function setReactNativePackageVersion(
110110

111111
await fs.writeFile(
112112
path.join(REPO_ROOT, 'packages/react-native/package.json'),
113-
JSON.stringify(packageJson, null, 2),
114-
'utf-8',
113+
JSON.stringify(packageJson, null, 2) + '\n',
115114
);
116115
}
117116

scripts/releases/set-version/__tests__/__snapshots__/set-version-test.js.snap

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ exports[`setVersion updates monorepo for nightly: packages/react-native/package.
176176
\\"metro-config\\": \\"^0.80.3\\",
177177
\\"metro-runtime\\": \\"^0.80.3\\"
178178
}
179-
}"
179+
}
180+
"
180181
`;
181182
182183
exports[`setVersion updates monorepo for nightly: packages/react-native/template/package.json 1`] = `
@@ -374,7 +375,8 @@ exports[`setVersion updates monorepo for release-candidate: packages/react-nativ
374375
\\"metro-config\\": \\"^0.80.3\\",
375376
\\"metro-runtime\\": \\"^0.80.3\\"
376377
}
377-
}"
378+
}
379+
"
378380
`;
379381
380382
exports[`setVersion updates monorepo for release-candidate: packages/react-native/template/package.json 1`] = `
@@ -572,7 +574,8 @@ exports[`setVersion updates monorepo for stable version: packages/react-native/p
572574
\\"metro-config\\": \\"^0.80.3\\",
573575
\\"metro-runtime\\": \\"^0.80.3\\"
574576
}
575-
}"
577+
}
578+
"
576579
`;
577580
578581
exports[`setVersion updates monorepo for stable version: packages/react-native/template/package.json 1`] = `
@@ -770,7 +773,8 @@ exports[`setVersion updates monorepo on main after release cut: packages/react-n
770773
\\"metro-config\\": \\"^0.80.3\\",
771774
\\"metro-runtime\\": \\"^0.80.3\\"
772775
}
773-
}"
776+
}
777+
"
774778
`;
775779
776780
exports[`setVersion updates monorepo on main after release cut: packages/react-native/template/package.json 1`] = `

scripts/releases/set-version/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ async function updatePackageJson(
4949
return fs.writeFile(
5050
path.join(packagePath, 'package.json'),
5151
JSON.stringify(packageJson, null, 2) + '\n',
52-
'utf-8',
5352
);
5453
}
5554

0 commit comments

Comments
 (0)