Fix int overflow in useRawPropsJsiValue (#53504)

Summary:
Pull Request resolved: #53504

Casting directly from double to int loses precision. Instead, match the (accidental) behaviour of the folly version, which always access the value as an int64_t first.

```
double value = 4294967040
(int)value = 2147483647 (overflow)
(int)(int64_t)value = -256 (signed version of 4294967040)
```

Changelog: [General][Fixed] Casting rawValue to int was incorrectly truncating

Reviewed By: zeyap, sammy-SC

Differential Revision: D81228983

fbshipit-source-id: d68d4e63d7c7bc9a9226592756a1e53666d58978

Author: javache

packages/react-native/ReactCommon/react/renderer/core/RawValue.h

@@ -394,7 +394,8 @@ class RawValue {
 
   static int
   castValue(jsi::Runtime* /*runtime*/, const jsi::Value& value, int* /*type*/) {
-    double number = value.asNumber();
+    // Casting directly from double to int loses precision, go via int64
+    auto number = static_cast<int64_t>(value.asNumber());
     return static_cast<int>(number);
   }
 

packages/react-native/ReactCommon/react/renderer/core/tests/RawPropsTest.cpp

@@ -12,11 +12,11 @@
 #include <react/debug/flags.h>
 #include <react/renderer/core/ConcreteShadowNode.h>
 #include <react/renderer/core/PropsParserContext.h>
+#include <react/renderer/core/RawProps.h>
+#include <react/renderer/core/RawPropsParser.h>
 #include <react/renderer/core/ShadowNode.h>
 #include <react/renderer/core/propsConversions.h>
 
-#include "TestComponent.h"
-
 using namespace facebook;
 using namespace facebook::react;
 

packages/react-native/ReactCommon/react/renderer/core/tests/RawValueTest.cpp

@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <memory>
+
+#include <gtest/gtest.h>
+#include <hermes/hermes.h>
+#include <react/renderer/core/RawValue.h>
+
+using namespace facebook;
+using namespace facebook::react;
+
+TEST(RawValueTest, intValueDoesNotOverflow) {
+  auto runtime = facebook::hermes::makeHermesRuntime();
+  auto rawValue = RawValue(*runtime, jsi::Value(*runtime, 4294967040.0));
+  EXPECT_EQ((int64_t)rawValue, 4294967040);
+  EXPECT_EQ((int)rawValue, static_cast<int>(4294967040));
+
+  rawValue = RawValue(folly::dynamic(4294967040.0));
+  EXPECT_EQ((int64_t)rawValue, 4294967040);
+  EXPECT_EQ((int)rawValue, static_cast<int>(4294967040));
+}