Update baseOutputPath input to generate-artifacts-executor to be optional

The argument for the output path was always optional. This wasn't
reflected in types, however, so this was missed in two prior changes.

Author: kitten

packages/react-native/scripts/codegen/generate-artifacts-executor/generateReactCodegenPodspec.js

@@ -29,7 +29,7 @@ function generateReactCodegenPodspec(
   appPath /*: string */,
   appPkgJson /*: $FlowFixMe */,
   outputPath /*: string */,
-  baseOutputPath /*: string */,
+  baseOutputPath /*: string | void | null */,
 ) {
   const inputFiles = getInputFiles(appPath, appPkgJson);
   const codegenScript = codegenScripts(appPath, baseOutputPath);
@@ -76,14 +76,24 @@ function getInputFiles(appPath /*: string */, appPkgJson /*: $FlowFixMe */) {
   return `[${list}]`;
 }
 
-function codegenScripts(appPath /*: string */, outputPath /*: string */) {
-  const relativeAppPath = path.relative(outputPath, appPath);
+function codegenScripts(
+  appPath /*: string */,
+  outputPath /*: string | void | null */,
+) {
+  const relativeAppPath =
+    outputPath != null && outputPath.length > 0
+      ? path.relative(outputPath, appPath)
+      : '';
+  const relativeReactNativeRootFolder =
+    outputPath != null && outputPath.length > 0
+      ? path.relative(outputPath, REACT_NATIVE_PACKAGE_ROOT_FOLDER)
+      : '';
   return `<<-SCRIPT
 pushd "$PODS_ROOT/../" > /dev/null
 RCT_SCRIPT_POD_INSTALLATION_ROOT=$(pwd)
 popd >/dev/null
 
-export RCT_SCRIPT_RN_DIR="$RCT_SCRIPT_POD_INSTALLATION_ROOT/${path.relative(outputPath, REACT_NATIVE_PACKAGE_ROOT_FOLDER)}"
+export RCT_SCRIPT_RN_DIR="$RCT_SCRIPT_POD_INSTALLATION_ROOT/${relativeReactNativeRootFolder}"
 export RCT_SCRIPT_APP_PATH="$RCT_SCRIPT_POD_INSTALLATION_ROOT/${relativeAppPath.length === 0 ? '.' : relativeAppPath}"
 export RCT_SCRIPT_OUTPUT_DIR="$RCT_SCRIPT_POD_INSTALLATION_ROOT"
 export RCT_SCRIPT_TYPE="withCodegenDiscovery"

packages/react-native/scripts/codegen/generate-artifacts-executor/index.js

@@ -63,7 +63,7 @@ const path = require('path');
 function execute(
   projectRoot /*: string */,
   targetPlatform /*: string */,
-  baseOutputPath /*: string */,
+  baseOutputPath /*: string | void | null */,
   source /*: string */,
   runReactNativeCodegen /*: boolean */ = true,
 ) {
@@ -210,7 +210,7 @@ function readOutputDirFromPkgJson(
 
 function computeOutputPath(
   projectRoot /*: string */,
-  baseOutputPath /*: string */,
+  baseOutputPath /*: string | void | null */,
   pkgJson /*: $FlowFixMe */,
   platform /*: string */,
 ) {

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js

@@ -98,11 +98,13 @@ function cleanupEmptyFilesAndFolders(filepath /*: string */) {
 }
 
 function readGeneratedAutolinkingOutput(
-  baseOutputPath /*: string */,
+  projectRoot /*: string */,
+  baseOutputPath /*: string | void | null */,
 ) /*: $FlowFixMe */ {
   // NOTE: Generated by scripts/cocoapods/autolinking.rb in list_native_modules (called by use_native_modules)
+  // The `baseOutputPath` is based on a CLI argument and optional
   const autolinkingGeneratedPath = path.resolve(
-    baseOutputPath,
+    baseOutputPath || projectRoot,
     'build/generated/autolinking/autolinking.json',
   );
   if (fs.existsSync(autolinkingGeneratedPath)) {
@@ -118,9 +120,12 @@ function readGeneratedAutolinkingOutput(
 
 function readReactNativeConfig(
   projectRoot /*: string */,
-  baseOutputPath /*: string */,
+  baseOutputPath /*: string | void | null */,
 ) /*: $FlowFixMe */ {
-  const autolinkingOutput = readGeneratedAutolinkingOutput(baseOutputPath);
+  const autolinkingOutput = readGeneratedAutolinkingOutput(
+    projectRoot,
+    baseOutputPath,
+  );
   const rnConfigFilePath = path.resolve(projectRoot, 'react-native.config.js');
   if (autolinkingOutput) {
     return autolinkingOutput;
@@ -139,7 +144,7 @@ function readReactNativeConfig(
 function findCodegenEnabledLibraries(
   pkgJson /*: $FlowFixMe */,
   projectRoot /*: string */,
-  baseOutputPath /*: string */,
+  baseOutputPath /*: string | void | null */,
   reactNativeConfig /*: $FlowFixMe */,
 ) /*: Array<$FlowFixMe> */ {
   const projectLibraries = findProjectRootLibraries(pkgJson, projectRoot);
@@ -149,7 +154,7 @@ function findCodegenEnabledLibraries(
     const libraries = [...projectLibraries];
     // If we ran autolinking, we shouldn't try to run our own "autolinking-like"
     // library discovery
-    if (!readGeneratedAutolinkingOutput(baseOutputPath)) {
+    if (!readGeneratedAutolinkingOutput(projectRoot, baseOutputPath)) {
       libraries.push(...findExternalLibraries(pkgJson, projectRoot));
     }
     libraries.push(