Switch from fetch() to curl

Author: motiz88

package.json

@@ -54,6 +54,7 @@
     "@babel/preset-env": "^7.25.3",
     "@babel/preset-flow": "^7.24.7",
     "@electron/packager": "^18.3.6",
+    "@expo/spawn-async": "^1.7.2",
     "@jest/create-cache-key-function": "^29.7.0",
     "@microsoft/api-extractor": "^7.52.2",
     "@motizilberman/dotslash": "0.5.7-1754587239403",

scripts/releases/upload-release-assets-for-dotslash.js

@@ -21,6 +21,7 @@ const {Octokit} = require('@octokit/rest');
 const {
   FIRST_PARTY_DOTSLASH_FILES,
 } = require('./write-dotslash-release-asset-urls');
+const {getWithCurl} = require('./utils/curl-utils');
 
 const config = {
   allowPositionals: true,
@@ -166,14 +167,9 @@ async function uploadReleaseAssetsForDotSlash(
             console.log(
               `[${targetReleaseAssetInfo.name}] Downloading from ${upstreamUrl}...`,
             );
-            const response = await fetch(upstreamUrl);
-            if (!response.ok) {
-              throw new Error(
-                `Failed to download ${upstreamUrl}: ${response.status} ${response.statusText}`,
-              );
-            }
-            const data = await response.arrayBuffer();
-            const contentType = response.headers.get('content-type');
+            // NOTE: Using curl because we have seen issues with fetch() on GHA
+            // and the Meta CDN. ¯\_(ツ)_/¯
+            const {data, headers} = await getWithCurl(upstreamUrl);
             if (dryRun) {
               console.log(
                 `[${targetReleaseAssetInfo.name}] Dry run: Not uploading to release.`,
@@ -190,7 +186,8 @@ async function uploadReleaseAssetsForDotSlash(
                 name: targetReleaseAssetInfo.name,
                 data,
                 headers: {
-                  'content-type': contentType,
+                  'content-type':
+                    headers['content-type'] ?? 'application/octet-stream',
                 },
               });
             }

scripts/releases/utils/curl-utils.js

@@ -0,0 +1,54 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+'use strict';
+
+const {promises: fs} = require('fs');
+const spawnAsync = require('@expo/spawn-async');
+const os = require('os');
+const path = require('path');
+
+/*::
+type CurlResult = {
+  data: Buffer,
+  headers: {[string]: string},
+};
+*/
+
+async function getWithCurl(url /*: string */) /*: Promise<CurlResult> */ {
+  const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'get-with-curl-'));
+  const tempFile = path.join(tempDir, 'data');
+  try {
+    const {
+      output: [curlStdout],
+    } = await spawnAsync(
+      'curl',
+      [
+        '--silent',
+        '--location',
+        '--output',
+        tempFile,
+        url,
+        '--write-out',
+        '%{header_json}',
+      ],
+      {encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe']},
+    );
+    const data = await fs.readFile(tempFile);
+    const headers = JSON.parse(curlStdout);
+    return {data, headers};
+  } finally {
+    await fs.rm(tempDir, {recursive: true, force: true});
+  }
+}
+
+module.exports = {
+  getWithCurl,
+};

yarn.lock

@@ -1411,6 +1411,13 @@
   resolved "https://registry.yarnpkg.com/@eslint/js/-/js-8.57.0.tgz#a5417ae8427873f1dd08b70b3574b453e67b5f7f"
   integrity sha512-Ys+3g2TaW7gADOJzPt83SJtCDhMjndcDMFVQ/Tj9iA1BfJzFKD9mAUXT3OenpuPHbI6P/myECxRJrofUsDx/5g==
 
+"@expo/spawn-async@^1.7.2":
+  version "1.7.2"
+  resolved "https://registry.yarnpkg.com/@expo/spawn-async/-/spawn-async-1.7.2.tgz#fcfe66c3e387245e72154b1a7eae8cada6a47f58"
+  integrity sha512-QdWi16+CHB9JYP7gma19OVVg0BFkvU8zNj9GjWorYI8Iv8FUxjOCcYRuAmX4s/h91e4e7BPsskc8cSrZYho9Ew==
+  dependencies:
+    cross-spawn "^7.0.3"
+
 "@fastify/busboy@^2.0.0":
   version "2.1.1"
   resolved "https://registry.yarnpkg.com/@fastify/busboy/-/busboy-2.1.1.tgz#b9da6a878a371829a0502c9b6c1c143ef6663f4d"