Flatten struct (#52867)

Summary:
Pull Request resolved: #52867

# Changelog: [Internal]

There are currently no reasons for these struct not to be plain, plus this would allow us avoiding potentially expensive copying, when returning `const &`.

Reviewed By: huntie

Differential Revision: D78919222

fbshipit-source-id: 7b39d754c05b25915f07202d7e4839b10a08a47c

Author: hoxyq

packages/react-native/ReactCommon/jsinspector-modern/InstanceAgent.cpp

@@ -172,7 +172,9 @@ tracing::InstanceTracingProfile InstanceAgent::collectTracingProfile() {
   tracing::RuntimeSamplingProfile runtimeSamplingProfile =
       runtimeAgent_->collectSamplingProfile();
 
-  return tracing::InstanceTracingProfile{std::move(runtimeSamplingProfile)};
+  return tracing::InstanceTracingProfile{
+      .runtimeSamplingProfile = std::move(runtimeSamplingProfile),
+  };
 }
 
 } // namespace facebook::react::jsinspector_modern

packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.cpp

@@ -115,7 +115,7 @@ bool TracingAgent::handleRequest(const cdp::PreparsedRequest& req) {
         dataCollectedCallback,
         PROFILE_TRACE_EVENT_CHUNK_SIZE);
     serializer.serializeAndNotify(
-        instanceAgent_->collectTracingProfile().getRuntimeSamplingProfile(),
+        instanceAgent_->collectTracingProfile().runtimeSamplingProfile,
         instanceTracingStartTimestamp_);
 
     frontendChannel_(cdp::jsonNotification(

packages/react-native/ReactCommon/jsinspector-modern/tracing/InstanceTracingProfile.h

@@ -13,15 +13,7 @@ namespace facebook::react::jsinspector_modern::tracing {
 
 struct InstanceTracingProfile {
  public:
-  explicit InstanceTracingProfile(RuntimeSamplingProfile runtimeSamplingProfile)
-      : runtimeSamplingProfile_(std::move(runtimeSamplingProfile)) {}
-
-  const RuntimeSamplingProfile& getRuntimeSamplingProfile() const {
-    return runtimeSamplingProfile_;
-  }
-
- private:
-  RuntimeSamplingProfile runtimeSamplingProfile_;
+  RuntimeSamplingProfile runtimeSamplingProfile;
 };
 
 } // namespace facebook::react::jsinspector_modern::tracing