Skip to content

Commit 42fa4a6

Browse files
kodafbfacebook-github-bot
authored andcommitted
Fix incorrect comment about strictEquals
Summary: The documentation of jsi::Value::strictEquals was confusing it with SameValue (which differs in treatment of signed zeroes and NaN). Fix it by referring to the correct part of the spec. Changelog: [Internal][Fixed] - Fix incorrect comment Reviewed By: avp Differential Revision: D26430216 fbshipit-source-id: 0ea4208fbdda40c87f8028231ddefb2323b6eb96
1 parent 2b2c69a commit 42fa4a6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ReactCommon/jsi/jsi/jsi.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -995,8 +995,8 @@ class JSI_EXPORT Value {
995995
return runtime.createValueFromJsonUtf8(json, length);
996996
}
997997

998-
/// \return according to the SameValue algorithm see more here:
999-
// https://www.ecma-international.org/ecma-262/5.1/#sec-11.9.4
998+
/// \return according to the Strict Equality Comparison algorithm, see:
999+
/// https://262.ecma-international.org/11.0/#sec-strict-equality-comparison
10001000
static bool strictEquals(Runtime& runtime, const Value& a, const Value& b);
10011001

10021002
Value& operator=(Value&& other) {

0 commit comments

Comments
 (0)