Skip to content

Commit 43ad2c0

Browse files
Remove contextContainer !=. nullptr check in ImageFetcher (#53574)
Summary: Pull Request resolved: #53574 Changelog: [Internal] This field is always non nullptr Reviewed By: javache Differential Revision: D81556283 fbshipit-source-id: d75b9cf9730f47c3d2d1ef028c2e738eda3dd785
1 parent 9a95e19 commit 43ad2c0

File tree

1 file changed

+10
-16
lines changed
  • packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager

1 file changed

+10
-16
lines changed

packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.cpp

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,20 @@ namespace facebook::react {
1616
ImageFetcher::ImageFetcher(
1717
std::shared_ptr<const ContextContainer> contextContainer)
1818
: contextContainer_(std::move(contextContainer)) {
19-
if (contextContainer_ != nullptr) {
20-
if (auto uiManagerCommitHookManager =
21-
contextContainer_
22-
->find<std::shared_ptr<UIManagerCommitHookManager>>(
23-
std::string(UIManagerCommitHookManagerKey));
24-
uiManagerCommitHookManager.has_value()) {
25-
(*uiManagerCommitHookManager)->registerCommitHook(*this);
26-
}
19+
if (auto uiManagerCommitHookManager =
20+
contextContainer_->find<std::shared_ptr<UIManagerCommitHookManager>>(
21+
std::string(UIManagerCommitHookManagerKey));
22+
uiManagerCommitHookManager.has_value()) {
23+
(*uiManagerCommitHookManager)->registerCommitHook(*this);
2724
}
2825
}
2926

3027
ImageFetcher::~ImageFetcher() {
31-
if (contextContainer_ != nullptr) {
32-
if (auto uiManagerCommitHookManager =
33-
contextContainer_
34-
->find<std::shared_ptr<UIManagerCommitHookManager>>(
35-
std::string(UIManagerCommitHookManagerKey));
36-
uiManagerCommitHookManager.has_value()) {
37-
(*uiManagerCommitHookManager)->unregisterCommitHook(*this);
38-
}
28+
if (auto uiManagerCommitHookManager =
29+
contextContainer_->find<std::shared_ptr<UIManagerCommitHookManager>>(
30+
std::string(UIManagerCommitHookManagerKey));
31+
uiManagerCommitHookManager.has_value()) {
32+
(*uiManagerCommitHookManager)->unregisterCommitHook(*this);
3933
}
4034
}
4135

0 commit comments

Comments
 (0)