Do not crash on onJSBundleLoadedFromServer when fast-refreshing on bridgeless mode

cortinico · facebook-github-bot · commit 44e5bc9e2c73 · 2024-02-23T10:44:53.000-08:00
Summary:
RN-Tester is currently instacrashing on fast-refresh (pressing r on Metro) as it ends up on `onJSBundleLoadedFromServer`
which throws an exception on Bridgeless mode. I'm fixing it by following the same logic as `onReloadWithJSDebugger`.

Changelog:
[Android] [Fixed] - Do not crash on onJSBundleLoadedFromServer when fast-refreshing on bridgeless mode

Reviewed By: huntie

Differential Revision: D54121838

fbshipit-source-id: 82d98ec0c5b2295f5751525368c956574dd7f3a0
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessDevSupportManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessDevSupportManager.java
@@ -119,7 +119,7 @@ public void onReloadWithJSDebugger(JavaJSExecutor.Factory proxyExecutorFactory)
 
       @Override
       public void onJSBundleLoadedFromServer() {
-        throw new IllegalStateException("Not implemented for bridgeless mode");
+        // Not implemented
       }
 
       @Override

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public void onReloadWithJSDebugger(JavaJSExecutor.Factory proxyExecutorFactory)`
`119`	`119`
`120`	`120`	`@Override`
`121`	`121`	`public void onJSBundleLoadedFromServer() {`
`122`		`- throw new IllegalStateException("Not implemented for bridgeless mode");`
	`122`	`+ // Not implemented`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`@Override`