Skip to content

Commit 4c5eb8d

Browse files
cortinicofacebook-github-bot
authored andcommitted
Bump AGP to 7.4.x (#35456)
Summary: Pull Request resolved: #35456 Fixes #35439 There is a bug in AGP 7.3.x which is causing assets to don't be copied properly inside the final artifact: issuetracker.google.com/issues/237421684 As AGP 7.4.x is really close to release (is in Beta5, should be released stable in the next weeks) we should be fine by bumping to beta5. This also requires a bump of RNGP Changelog: [Android] [Changed] - Bump AGP to 7.4.x allow-large-files Reviewed By: cipolleschi Differential Revision: D41519549 fbshipit-source-id: 60d568a3e49798a23f1d7bf4839ab58bd5549aba
1 parent 92be0e3 commit 4c5eb8d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

packages/react-native-gradle-plugin/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ group = "com.facebook.react"
3333

3434
dependencies {
3535
implementation(gradleApi())
36-
implementation("com.android.tools.build:gradle:7.3.1")
36+
implementation("com.android.tools.build:gradle:7.4.0-beta05")
3737
implementation("com.google.code.gson:gson:2.8.9")
3838
implementation("com.google.guava:guava:31.0.1-jre")
3939
implementation("com.squareup:javapoet:1.13.0")
@@ -50,8 +50,8 @@ dependencies {
5050
}
5151

5252
java {
53-
sourceCompatibility = JavaVersion.VERSION_1_8
54-
targetCompatibility = JavaVersion.VERSION_1_8
53+
sourceCompatibility = JavaVersion.VERSION_11
54+
targetCompatibility = JavaVersion.VERSION_11
5555
}
5656

5757
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {

packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,10 @@ class ReactPlugin : Plugin<Project> {
4747
configureBuildConfigFields(project)
4848
configureDevPorts(project)
4949

50-
project.extensions.getByType(AndroidComponentsExtension::class.java).onVariants { variant ->
51-
project.configureReactTasks(variant = variant, config = extension)
50+
project.extensions.getByType(AndroidComponentsExtension::class.java).apply {
51+
onVariants(selector().all()) { variant ->
52+
project.configureReactTasks(variant = variant, config = extension)
53+
}
5254
}
5355
configureCodegen(project, extension, isLibrary = false)
5456
}

template/android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ buildscript {
1515
mavenCentral()
1616
}
1717
dependencies {
18-
classpath("com.android.tools.build:gradle:7.3.1")
18+
classpath("com.android.tools.build:gradle:7.4.0-beta05")
1919
classpath("com.facebook.react:react-native-gradle-plugin")
2020
}
2121
}

0 commit comments

Comments
 (0)