ios: Deprecate objc legacy core classes (#53453)

Summary:
Pull Request resolved: #53453

Let's deprecate all the classes that aren't used by interop, or the new architecture.

Changelog: [iOS][Deprecated] Deprecate all the objc classes not used by interop, or the new architecture.

Reviewed By: javache

Differential Revision: D80575768

fbshipit-source-id: ad12e4b639c21d608636eedbc7cd502fa9d7f461

Author: RSNara

packages/react-native/React/Base/RCTBridge+Private.h

@@ -21,7 +21,8 @@ RCT_EXTERN void RCTRegisterModule(Class);
 - (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate
                        bundleURL:(NSURL *)bundleURL
                   moduleProvider:(RCTBridgeModuleListProvider)block
-                   launchOptions:(NSDictionary *)launchOptions NS_DESIGNATED_INITIALIZER;
+                   launchOptions:(NSDictionary *)launchOptions NS_DESIGNATED_INITIALIZER
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 #endif // RCT_FIT_RM_OLD_RUNTIME
 
@@ -150,7 +151,8 @@ RCT_EXTERN void RCTRegisterModule(Class);
 @property (nonatomic, readonly) void *runtime;
 
 #ifndef RCT_FIT_RM_OLD_RUNTIME
-- (instancetype)initWithParentBridge:(RCTBridge *)bridge NS_DESIGNATED_INITIALIZER;
+- (instancetype)initWithParentBridge:(RCTBridge *)bridge NS_DESIGNATED_INITIALIZER
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 #endif // RCT_FIT_RM_OLD_RUNTIME
 
 @end

packages/react-native/React/Base/RCTBridge.h

@@ -107,7 +107,9 @@ RCT_EXTERN_C_END
  * pre-initialized module instances if they require additional init parameters
  * or configuration.
  */
-- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate launchOptions:(NSDictionary *)launchOptions;
+- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate
+                   launchOptions:(NSDictionary *)launchOptions
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * DEPRECATED: Use initWithDelegate:launchOptions: instead
@@ -121,7 +123,8 @@ RCT_EXTERN_C_END
  */
 - (instancetype)initWithBundleURL:(NSURL *)bundleURL
                    moduleProvider:(RCTBridgeModuleListProvider)block
-                    launchOptions:(NSDictionary *)launchOptions;
+                    launchOptions:(NSDictionary *)launchOptions
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * This method is used to call functions in the JavaScript application context.

packages/react-native/React/Base/RCTBridgeDelegate.h

@@ -21,7 +21,8 @@ NS_ASSUME_NONNULL_BEGIN
  * When running from a locally bundled JS file, this should be a `file://` url
  * pointing to a path inside the app resources, e.g. `file://.../main.jsbundle`.
  */
-- (NSURL *__nullable)sourceURLForBridge:(RCTBridge *)bridge;
+- (NSURL *__nullable)sourceURLForBridge:(RCTBridge *)bridge
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 @optional
 
@@ -39,7 +40,8 @@ NS_ASSUME_NONNULL_BEGIN
  * not recommended in most cases - if the module methods and behavior do not
  * match exactly, it may lead to bugs or crashes.
  */
-- (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge;
+- (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * The bridge will call this method when a module been called from JS
@@ -48,7 +50,9 @@ NS_ASSUME_NONNULL_BEGIN
  * in the implementation, and the system must attempt to look for it again among registered.
  * If the module was not registered, return NO to prevent further searches.
  */
-- (BOOL)bridge:(RCTBridge *)bridge didNotFindModule:(NSString *)moduleName;
+- (BOOL)bridge:(RCTBridge *)bridge
+    didNotFindModule:(NSString *)moduleName
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * The bridge will automatically attempt to load the JS source code from the
@@ -57,18 +61,22 @@ NS_ASSUME_NONNULL_BEGIN
  */
 - (void)loadSourceForBridge:(RCTBridge *)bridge
                  onProgress:(RCTSourceLoadProgressBlock)onProgress
-                 onComplete:(RCTSourceLoadBlock)loadCallback;
+                 onComplete:(RCTSourceLoadBlock)loadCallback
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Similar to loadSourceForBridge:onProgress:onComplete: but without progress
  * reporting.
  */
-- (void)loadSourceForBridge:(RCTBridge *)bridge withBlock:(RCTSourceLoadBlock)loadCallback;
+- (void)loadSourceForBridge:(RCTBridge *)bridge
+                  withBlock:(RCTSourceLoadBlock)loadCallback
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Retrieve the list of lazy-native-modules names for the given bridge.
  */
-- (NSDictionary<NSString *, Class> *)extraLazyModuleClassesForBridge:(RCTBridge *)bridge;
+- (NSDictionary<NSString *, Class> *)extraLazyModuleClassesForBridge:(RCTBridge *)bridge
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 #endif // RCT_FIT_RM_OLD_RUNTIME
 @end

packages/react-native/React/Base/RCTJavaScriptExecutor.h

@@ -10,15 +10,18 @@
 #import <React/RCTBridgeModule.h>
 #import <React/RCTInvalidating.h>
 
-typedef void (^RCTJavaScriptCompleteBlock)(NSError *error);
-typedef void (^RCTJavaScriptCallback)(id result, NSError *error);
+typedef void (^RCTJavaScriptCompleteBlock)(NSError *__strong)
+    __deprecated_msg("This api will be removed along with the bridge.");
+typedef void (^RCTJavaScriptCallback)(__strong id, NSError *__strong)
+    __deprecated_msg("This api will be removed along with the bridge.");
 
 #ifndef RCT_FIT_RM_OLD_RUNTIME
 /**
  * Abstracts away a JavaScript execution context - we may be running code in a
  * web view (for debugging purposes), or may be running code in a `JSContext`.
  */
-@protocol RCTJavaScriptExecutor <RCTInvalidating, RCTBridgeModule>
+__deprecated_msg("This api will be removed along with the bridge.")
+    @protocol RCTJavaScriptExecutor<RCTInvalidating, RCTBridgeModule>
 
 /**
  * Used to set up the executor after the bridge has been fully initialized.

packages/react-native/React/Base/RCTModuleData.h

@@ -34,76 +34,90 @@ typedef id<RCTBridgeModule> (^RCTBridgeModuleProvider)(void);
                      moduleRegistry:(RCTModuleRegistry *)moduleRegistry
             viewRegistry_DEPRECATED:(RCTViewRegistry *)viewRegistry_DEPRECATED
                       bundleManager:(RCTBundleManager *)bundleManager
-                  callableJSModules:(RCTCallableJSModules *)callableJSModules NS_DESIGNATED_INITIALIZER;
+                  callableJSModules:(RCTCallableJSModules *)callableJSModules NS_DESIGNATED_INITIALIZER
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 - (instancetype)initWithModuleInstance:(id<RCTBridgeModule>)instance
                                 bridge:(RCTBridge *)bridge
                         moduleRegistry:(RCTModuleRegistry *)moduleRegistry
                viewRegistry_DEPRECATED:(RCTViewRegistry *)viewRegistry_DEPRECATED
                          bundleManager:(RCTBundleManager *)bundleManager
-                     callableJSModules:(RCTCallableJSModules *)callableJSModules NS_DESIGNATED_INITIALIZER;
+                     callableJSModules:(RCTCallableJSModules *)callableJSModules NS_DESIGNATED_INITIALIZER
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Calls `constantsToExport` on the module and stores the result. Note that
  * this will init the module if it has not already been created. This method
  * can be called on any thread, but may block the main thread briefly if the
  * module implements `constantsToExport`.
  */
-- (void)gatherConstants;
+- (void)gatherConstants __deprecated_msg("This API will be removed along with the legacy architecture.");
 
-@property (nonatomic, strong, readonly) Class moduleClass;
-@property (nonatomic, copy, readonly) NSString *name;
+@property (nonatomic, strong, readonly)
+    Class moduleClass __deprecated_msg("This API will be removed along with the legacy architecture.");
+@property (nonatomic, copy, readonly)
+    NSString *name __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Returns the module methods. Note that this will gather the methods the first
  * time it is called and then memoize the results.
  */
-@property (nonatomic, copy, readonly) NSArray<id<RCTBridgeMethod>> *methods;
+@property (nonatomic, copy, readonly) NSArray<id<RCTBridgeMethod>> *methods __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Returns a map of the module methods. Note that this will gather the methods the first
  * time it is called and then memoize the results.
  */
-@property (nonatomic, copy, readonly) NSDictionary<NSString *, id<RCTBridgeMethod>> *methodsByName;
+@property (nonatomic, copy, readonly) NSDictionary<NSString *, id<RCTBridgeMethod>> *methodsByName __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Returns the module's constants, if it exports any
  */
-@property (nonatomic, copy, readonly) NSDictionary<NSString *, id> *exportedConstants;
+@property (nonatomic, copy, readonly) NSDictionary<NSString *, id> *exportedConstants __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Returns YES if module instance has already been initialized; NO otherwise.
  */
-@property (nonatomic, assign, readonly) BOOL hasInstance;
+@property (nonatomic, assign, readonly)
+    BOOL hasInstance __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Returns YES if module instance must be created on the main thread.
  */
-@property (nonatomic, assign) BOOL requiresMainQueueSetup;
+@property (nonatomic, assign)
+    BOOL requiresMainQueueSetup __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Returns YES if module has constants to export.
  */
-@property (nonatomic, assign, readonly) BOOL hasConstantsToExport;
+@property (nonatomic, assign, readonly)
+    BOOL hasConstantsToExport __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Returns the current module instance. Note that this will init the instance
  * if it has not already been created. To check if the module instance exists
  * without causing it to be created, use `hasInstance` instead.
  */
-@property (nonatomic, strong, readwrite) id<RCTBridgeModule> instance;
+@property (nonatomic, strong, readwrite) id<RCTBridgeModule> instance __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Returns the module method dispatch queue. Note that this will init both the
  * queue and the module itself if they have not already been created.
  */
-@property (nonatomic, strong, readonly) dispatch_queue_t methodQueue;
+@property (nonatomic, strong, readonly)
+    dispatch_queue_t methodQueue __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 /**
  * Whether the receiver has a valid `instance` which implements -batchDidComplete.
  */
-@property (nonatomic, assign, readonly) BOOL implementsBatchDidComplete;
+@property (nonatomic, assign, readonly)
+    BOOL implementsBatchDidComplete __deprecated_msg("This API will be removed along with the legacy architecture.");
 
-@property (nonatomic, weak, readwrite) id<RCTModuleDataCallInvokerProvider> callInvokerProvider;
+@property (nonatomic, weak, readwrite) id<RCTModuleDataCallInvokerProvider> callInvokerProvider __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 @end

packages/react-native/React/Base/RCTRootContentView.h

@@ -18,18 +18,25 @@
 
 @interface RCTRootContentView : RCTView <RCTInvalidating>
 
-@property (nonatomic, readonly, weak) RCTBridge *bridge;
-@property (nonatomic, readonly, assign) BOOL contentHasAppeared;
-@property (nonatomic, readonly, strong) RCTTouchHandler *touchHandler;
-@property (nonatomic, readonly, assign) CGSize availableSize;
-
-@property (nonatomic, assign) BOOL passThroughTouches;
-@property (nonatomic, assign) RCTRootViewSizeFlexibility sizeFlexibility;
+@property (nonatomic, readonly, weak)
+    RCTBridge *bridge __deprecated_msg("This API will be removed along with the legacy architecture.");
+@property (nonatomic, readonly, assign)
+    BOOL contentHasAppeared __deprecated_msg("This API will be removed along with the legacy architecture.");
+@property (nonatomic, readonly, strong)
+    RCTTouchHandler *touchHandler __deprecated_msg("This API will be removed along with the legacy architecture.");
+@property (nonatomic, readonly, assign)
+    CGSize availableSize __deprecated_msg("This API will be removed along with the legacy architecture.");
+
+@property (nonatomic, assign)
+    BOOL passThroughTouches __deprecated_msg("This API will be removed along with the legacy architecture.");
+@property (nonatomic, assign) RCTRootViewSizeFlexibility sizeFlexibility __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 - (instancetype)initWithFrame:(CGRect)frame
                        bridge:(RCTBridge *)bridge
                      reactTag:(NSNumber *)reactTag
-              sizeFlexibility:(RCTRootViewSizeFlexibility)sizeFlexibility NS_DESIGNATED_INITIALIZER;
+              sizeFlexibility:(RCTRootViewSizeFlexibility)sizeFlexibility NS_DESIGNATED_INITIALIZER
+    __deprecated_msg("This API will be removed along with the legacy architecture.");
 
 @end
 

packages/react-native/React/Base/RCTRootView.h

@@ -47,7 +47,7 @@ extern
  * like any ordinary UIView. You can have multiple RCTRootViews on screen at
  * once, all controlled by the same JavaScript application.
  */
-@interface RCTRootView : UIView
+__deprecated_msg("This API will be removed along with the legacy architecture.") @interface RCTRootView : UIView
 
 /**
  * - Designated initializer -

packages/react-native/React/Base/RCTRootViewInternal.h

@@ -13,7 +13,7 @@
  * The interface provides a set of functions that allow other internal framework
  * classes to change the RCTRootViews's internal state.
  */
-@interface RCTRootView ()
+__deprecated_msg("This API will be removed along with the legacy architecture.") @interface RCTRootView()
 
 /**
  * This setter should be used only by RCTUIManager on react root view

packages/react-native/React/Base/Surface/RCTSurface.h

@@ -32,7 +32,8 @@ NS_ASSUME_NONNULL_BEGIN
  *  * ability to create a UIView instance on demand (later);
  *  * ability to communicate the current stage of the surface granularly.
  */
-@interface RCTSurface : NSObject <RCTSurfaceProtocol>
+__deprecated_msg("This API will be removed along with the legacy architecture.") @interface RCTSurface
+    : NSObject<RCTSurfaceProtocol>
 
 - (instancetype)initWithBridge:(RCTBridge *)bridge
                     moduleName:(NSString *)moduleName

packages/react-native/React/Base/Surface/RCTSurfaceRootShadowView.h

@@ -9,7 +9,8 @@
 #import <React/RCTSurfaceRootShadowViewDelegate.h>
 #import <yoga/YGEnums.h>
 
-@interface RCTSurfaceRootShadowView : RCTShadowView
+__deprecated_msg("This API will be removed along with the legacy architecture.") @interface RCTSurfaceRootShadowView
+    : RCTShadowView
 
 @property (nonatomic, assign, readonly) CGSize minimumSize;
 @property (nonatomic, assign, readonly) CGSize maximumSize;
@@ -18,7 +19,8 @@
 
 @property (nonatomic, assign, readonly) CGSize intrinsicSize;
 
-@property (nonatomic, weak) id<RCTSurfaceRootShadowViewDelegate> delegate;
+@property (nonatomic, weak) id<RCTSurfaceRootShadowViewDelegate> delegate __deprecated_msg(
+    "This API will be removed along with the legacy architecture.");
 
 /**
  * Layout direction (LTR or RTL) inherited from native environment and