De-duplicate building Spannable on Android (#39630)

Summary:
A first step in my work on react-native-community/discussions-and-proposals#695

De-duplicate the code for creating `Spannable` on Android. I'm planning to add quite serious new features to this module. This would be really hard with the current level of code duplication.

## Changelog:

[INTERNAL] [CHANGED] - De-duplicate building `Spannable` on Android

Pull Request resolved: #39630

Test Plan: I tried to ensure that the refactored code is relatively easy to prove to be equivalent to the original duplicated one, but there's always a risk of a human mistake in this process. So far, I have been testing this by ensuring that nothing broke in the `Text` example section in RNTester.

Reviewed By: mdvacca

Differential Revision: D51016244

Pulled By: NickGerleman

fbshipit-source-id: e9f873c01b2af0685c7b0943aebea170c997d22e

Author: cubuspl42

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -1686,6 +1686,7 @@ public final class com/facebook/react/common/MapBuilder$Builder {
 
 public class com/facebook/react/common/ReactConstants {
 	public static final field TAG Ljava/lang/String;
+	public static final field UNSET I
 	public fun <init> ()V
 }
 
@@ -1764,7 +1765,6 @@ public class com/facebook/react/common/assets/ReactFontManager {
 public class com/facebook/react/common/assets/ReactFontManager$TypefaceStyle {
 	public static final field BOLD I
 	public static final field NORMAL I
-	public static final field UNSET I
 	public fun <init> (I)V
 	public fun <init> (II)V
 	public fun <init> (IZ)V
@@ -1906,6 +1906,7 @@ public class com/facebook/react/config/ReactFeatureFlags {
 	public static field enableMountHooks Z
 	public static field enableOnDemandReactChoreographer Z
 	public static field enableRemoveDeleteTreeInstruction Z
+	public static field enableSpannableBuildingUnification Z
 	public static field enableTextSpannableCache Z
 	public static field enableViewRecycling Z
 	public static field excludeYogaFromRawProps Z
@@ -6785,15 +6786,14 @@ public class com/facebook/react/views/text/ReactBackgroundColorSpan : android/te
 	public fun <init> (I)V
 }
 
-public abstract class com/facebook/react/views/text/ReactBaseTextShadowNode : com/facebook/react/uimanager/LayoutShadowNode {
+public abstract class com/facebook/react/views/text/ReactBaseTextShadowNode : com/facebook/react/uimanager/LayoutShadowNode, com/facebook/react/views/text/BasicTextAttributeProvider {
 	public static final field DEFAULT_TEXT_SHADOW_COLOR I
 	public static final field PROP_SHADOW_COLOR Ljava/lang/String;
 	public static final field PROP_SHADOW_OFFSET Ljava/lang/String;
 	public static final field PROP_SHADOW_OFFSET_HEIGHT Ljava/lang/String;
 	public static final field PROP_SHADOW_OFFSET_WIDTH Ljava/lang/String;
 	public static final field PROP_SHADOW_RADIUS Ljava/lang/String;
 	public static final field PROP_TEXT_TRANSFORM Ljava/lang/String;
-	public static final field UNSET I
 	protected field mAccessibilityRole Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$AccessibilityRole;
 	protected field mAdjustsFontSizeToFit Z
 	protected field mBackgroundColor I
@@ -6824,6 +6824,22 @@ public abstract class com/facebook/react/views/text/ReactBaseTextShadowNode : co
 	protected field mTextShadowRadius F
 	public fun <init> ()V
 	public fun <init> (Lcom/facebook/react/views/text/ReactTextViewManagerCallback;)V
+	public fun getAccessibilityRole ()Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$AccessibilityRole;
+	public fun getBackgroundColor ()I
+	public fun getColor ()I
+	public fun getFontFamily ()Ljava/lang/String;
+	public fun getFontFeatureSettings ()Ljava/lang/String;
+	public fun getFontStyle ()I
+	public fun getFontWeight ()I
+	public fun getRole ()Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$Role;
+	public fun getTextShadowColor ()I
+	public fun getTextShadowOffsetDx ()F
+	public fun getTextShadowOffsetDy ()F
+	public fun getTextShadowRadius ()F
+	public fun isBackgroundColorSet ()Z
+	public fun isColorSet ()Z
+	public fun isLineThroughTextDecorationSet ()Z
+	public fun isUnderlineTextDecorationSet ()Z
 	public fun setAccessibilityRole (Ljava/lang/String;)V
 	public fun setAdjustFontSizeToFit (Z)V
 	public fun setAllowFontScaling (Z)V
@@ -7084,12 +7100,19 @@ public class com/facebook/react/views/text/ReactVirtualTextViewManager$$PropsSet
 	public fun setProperty (Lcom/facebook/react/views/text/ReactVirtualTextViewManager;Landroid/view/View;Ljava/lang/String;Ljava/lang/Object;)V
 }
 
+public class com/facebook/react/views/text/SetSpanOperation {
+	protected field end I
+	protected field start I
+	protected field what Lcom/facebook/react/views/text/ReactSpan;
+	public fun execute (Landroid/text/SpannableStringBuilder;I)V
+}
+
 public class com/facebook/react/views/text/ShadowStyleSpan : android/text/style/CharacterStyle, com/facebook/react/views/text/ReactSpan {
 	public fun <init> (FFFI)V
 	public fun updateDrawState (Landroid/text/TextPaint;)V
 }
 
-public class com/facebook/react/views/text/TextAttributeProps {
+public class com/facebook/react/views/text/TextAttributeProps : com/facebook/react/views/text/EffectiveTextAttributeProvider {
 	public static final field TA_KEY_ACCESSIBILITY_ROLE S
 	public static final field TA_KEY_ALIGNMENT S
 	public static final field TA_KEY_ALLOW_FONT_SCALING S
@@ -7117,7 +7140,6 @@ public class com/facebook/react/views/text/TextAttributeProps {
 	public static final field TA_KEY_TEXT_SHADOW_OFFSET_DY S
 	public static final field TA_KEY_TEXT_SHADOW_RADIUS S
 	public static final field TA_KEY_TEXT_TRANSFORM S
-	public static final field UNSET I
 	protected field mAccessibilityRole Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$AccessibilityRole;
 	protected field mAllowFontScaling Z
 	protected field mBackgroundColor I
@@ -7149,13 +7171,32 @@ public class com/facebook/react/views/text/TextAttributeProps {
 	protected field mTextTransform Lcom/facebook/react/views/text/TextTransform;
 	public static fun fromMapBuffer (Lcom/facebook/react/common/mapbuffer/MapBuffer;)Lcom/facebook/react/views/text/TextAttributeProps;
 	public static fun fromReadableMap (Lcom/facebook/react/uimanager/ReactStylesDiffMap;)Lcom/facebook/react/views/text/TextAttributeProps;
+	public fun getAccessibilityRole ()Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$AccessibilityRole;
+	public fun getBackgroundColor ()I
+	public fun getColor ()I
+	public fun getEffectiveFontSize ()I
+	public fun getEffectiveLetterSpacing ()F
 	public fun getEffectiveLineHeight ()F
+	public fun getFontFamily ()Ljava/lang/String;
+	public fun getFontFeatureSettings ()Ljava/lang/String;
+	public fun getFontStyle ()I
+	public fun getFontWeight ()I
 	public static fun getHyphenationFrequency (Ljava/lang/String;)I
 	public static fun getJustificationMode (Lcom/facebook/react/uimanager/ReactStylesDiffMap;I)I
 	public static fun getLayoutDirection (Ljava/lang/String;)I
 	public fun getLetterSpacing ()F
+	public fun getRole ()Lcom/facebook/react/uimanager/ReactAccessibilityDelegate$Role;
 	public static fun getTextAlignment (Lcom/facebook/react/uimanager/ReactStylesDiffMap;ZI)I
 	public static fun getTextBreakStrategy (Ljava/lang/String;)I
+	public fun getTextShadowColor ()I
+	public fun getTextShadowOffsetDx ()F
+	public fun getTextShadowOffsetDy ()F
+	public fun getTextShadowRadius ()F
+	public fun getTextTransform ()Lcom/facebook/react/views/text/TextTransform;
+	public fun isBackgroundColorSet ()Z
+	public fun isColorSet ()Z
+	public fun isLineThroughTextDecorationSet ()Z
+	public fun isUnderlineTextDecorationSet ()Z
 }
 
 public class com/facebook/react/views/text/TextAttributes {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/ReactConstants.java

@@ -10,4 +10,12 @@
 public class ReactConstants {
 
   public static final String TAG = "ReactNative";
+
+  /**
+   * Some types have built-in support for representing a "missing" or "unset" value, for example NaN
+   * in the case of floating point numbers or null in the case of object references. Integers don't
+   * have such a special value. When an integer represent an inherently non-negative value, we use a
+   * special negative value to mark it as "unset".
+   */
+  public static final int UNSET = -1;
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/assets/ReactFontManager.java

@@ -15,6 +15,7 @@
 import androidx.annotation.Nullable;
 import androidx.core.content.res.ResourcesCompat;
 import com.facebook.infer.annotation.Nullsafe;
+import com.facebook.react.common.ReactConstants;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -167,8 +168,6 @@ public static class TypefaceStyle {
 
     public static final int BOLD = 700;
     public static final int NORMAL = 400;
-    public static final int UNSET = -1;
-
     private static final int MIN_WEIGHT = 1;
     private static final int MAX_WEIGHT = 1000;
 
@@ -177,11 +176,11 @@ public static class TypefaceStyle {
 
     public TypefaceStyle(int weight, boolean italic) {
       mItalic = italic;
-      mWeight = weight == UNSET ? NORMAL : weight;
+      mWeight = weight == ReactConstants.UNSET ? NORMAL : weight;
     }
 
     public TypefaceStyle(int style) {
-      if (style == UNSET) {
+      if (style == ReactConstants.UNSET) {
         style = Typeface.NORMAL;
       }
 
@@ -194,12 +193,13 @@ public TypefaceStyle(int style) {
      * existing weight bit in `style` will be used.
      */
     public TypefaceStyle(int style, int weight) {
-      if (style == UNSET) {
+      if (style == ReactConstants.UNSET) {
         style = Typeface.NORMAL;
       }
 
       mItalic = (style & Typeface.ITALIC) != 0;
-      mWeight = weight == UNSET ? (style & Typeface.BOLD) != 0 ? BOLD : NORMAL : weight;
+      mWeight =
+          weight == ReactConstants.UNSET ? (style & Typeface.BOLD) != 0 ? BOLD : NORMAL : weight;
     }
 
     public int getNearestStyle() {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java

@@ -173,4 +173,7 @@ public class ReactFeatureFlags {
    *  when there is work to do.
    */
   public static boolean enableOnDemandReactChoreographer = false;
+
+  /** Enables the new unified {@link android.text.Spannable} building logic. */
+  public static boolean enableSpannableBuildingUnification = false;
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/BasicTextAttributeProvider.kt

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.views.text
+
+import com.facebook.react.uimanager.ReactAccessibilityDelegate
+
+/**
+ * Interface for an entity providing basic text attributes of a text node/fragment. "Basic" means
+ * that they can be provided trivially, without processing the parent element.
+ */
+internal interface BasicTextAttributeProvider {
+  val role: ReactAccessibilityDelegate.Role?
+
+  val accessibilityRole: ReactAccessibilityDelegate.AccessibilityRole?
+
+  val isBackgroundColorSet: Boolean
+
+  val backgroundColor: Int
+
+  val isColorSet: Boolean
+
+  val color: Int
+
+  val fontStyle: Int
+
+  val fontWeight: Int
+
+  val fontFamily: String?
+
+  val fontFeatureSettings: String?
+
+  val isUnderlineTextDecorationSet: Boolean
+
+  val isLineThroughTextDecorationSet: Boolean
+
+  val textShadowOffsetDx: Float
+
+  val textShadowOffsetDy: Float
+
+  val textShadowRadius: Float
+
+  val textShadowColor: Int
+}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/CustomStyleSpan.java

@@ -14,6 +14,7 @@
 import android.text.style.MetricAffectingSpan;
 import androidx.annotation.Nullable;
 import com.facebook.infer.annotation.Nullsafe;
+import com.facebook.react.common.ReactConstants;
 import com.facebook.react.common.assets.ReactFontManager;
 
 @Nullsafe(Nullsafe.Mode.LOCAL)
@@ -61,13 +62,11 @@ public void updateMeasureState(TextPaint paint) {
   }
 
   public int getStyle() {
-    return mStyle == ReactFontManager.TypefaceStyle.UNSET ? Typeface.NORMAL : mStyle;
+    return mStyle == ReactConstants.UNSET ? Typeface.NORMAL : mStyle;
   }
 
   public int getWeight() {
-    return mWeight == ReactFontManager.TypefaceStyle.UNSET
-        ? ReactFontManager.TypefaceStyle.NORMAL
-        : mWeight;
+    return mWeight == ReactConstants.UNSET ? ReactFontManager.TypefaceStyle.NORMAL : mWeight;
   }
 
   public @Nullable String getFontFamily() {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/EffectiveTextAttributeProvider.kt

@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.views.text
+
+import com.facebook.react.common.ReactConstants.UNSET
+
+/** Interface for an entity providing effective text attributes of a text node/fragment */
+internal interface EffectiveTextAttributeProvider : BasicTextAttributeProvider {
+  val textTransform: TextTransform
+
+  val effectiveLetterSpacing: Float
+
+  /** @return The effective font size, or [UNSET] if not set */
+  val effectiveFontSize: Int
+
+  val effectiveLineHeight: Float
+}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/HierarchicTextAttributeProvider.kt

@@ -0,0 +1,63 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.views.text
+
+import com.facebook.react.common.ReactConstants
+
+/**
+ * Implementation of [EffectiveTextAttributeProvider] that provides effective text attributes based
+ * on a [ReactBaseTextShadowNode] instance and its parent.
+ */
+internal class HierarchicTextAttributeProvider(
+    private val textShadowNode: ReactBaseTextShadowNode,
+    private val parentTextAttributes: TextAttributes?,
+    private val textAttributes: TextAttributes
+) : EffectiveTextAttributeProvider, BasicTextAttributeProvider by textShadowNode {
+  override val textTransform: TextTransform
+    get() = textAttributes.textTransform
+
+  override val effectiveLetterSpacing: Float
+    get() {
+      val letterSpacing = textAttributes.effectiveLetterSpacing
+
+      val isParentLetterSpacingDifferent =
+          parentTextAttributes == null ||
+              parentTextAttributes.effectiveLetterSpacing != letterSpacing
+
+      return if (!letterSpacing.isNaN() && isParentLetterSpacingDifferent) {
+        letterSpacing
+      } else {
+        Float.NaN
+      }
+    }
+
+  override val effectiveFontSize: Int
+    get() {
+      val fontSize = textAttributes.effectiveFontSize
+
+      return if (parentTextAttributes == null ||
+          parentTextAttributes.effectiveFontSize != fontSize) {
+        fontSize
+      } else {
+        ReactConstants.UNSET
+      }
+    }
+
+  override val effectiveLineHeight: Float
+    get() {
+      val lineHeight = textAttributes.effectiveLineHeight
+      val isParentLineHeightDifferent =
+          parentTextAttributes == null || parentTextAttributes.effectiveLineHeight != lineHeight
+
+      return if (!lineHeight.isNaN() && isParentLineHeightDifferent) {
+        lineHeight
+      } else {
+        Float.NaN
+      }
+    }
+}