Skip to content

Commit 7d7f48d

Browse files
cortinicofacebook-github-bot
authored andcommitted
Remove Buck OSS 1 setup. (#36900)
Summary: Pull Request resolved: #36900 This commit effectively removes all the Buck 1 OSS infra code we do have inside React Native as we'll need to rework most of it once we move to Buck 2 Changelog: [Internal] [Changed] - Remove Buck OSS 1 setup Reviewed By: mdvacca, cipolleschi Differential Revision: D44956134 fbshipit-source-id: c0ad1914286c428480248658c4282df5477bba2b
1 parent d50934a commit 7d7f48d

23 files changed

+0
-1078
lines changed

.circleci/Dockerfiles/Dockerfile.android

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ ADD scripts /app/scripts
3737

3838
WORKDIR /app
3939

40-
RUN scripts/buck/buck_fetch.sh
41-
42-
RUN buck build packages/react-native/ReactAndroid/src/main/java/com/facebook/react
43-
RUN buck build packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell
44-
4540
ADD . /app
4641

4742
RUN yarn

.circleci/config.yml

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -719,60 +719,6 @@ jobs:
719719
- store_test_results:
720720
path: ./reports/junit
721721

722-
# -------------------------
723-
# JOBS: Test Buck
724-
# -------------------------
725-
test_buck:
726-
executor: reactnativeandroid
727-
environment:
728-
KOTLIN_HOME=packages/react-native/third-party/kotlin
729-
steps:
730-
- checkout
731-
- setup_artifacts
732-
- run_yarn
733-
734-
- run:
735-
name: Download Dependencies Using Buck
736-
command: ./scripts/buck/buck_fetch.sh
737-
738-
- run:
739-
name: Build & Test React Native using Buck
740-
command: |
741-
buck build packages/react-native/ReactAndroid/src/main/java/com/facebook/react
742-
buck build packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell
743-
744-
- run:
745-
name: Run Tests - Android Unit Tests with Buck
746-
command: buck test packages/react-native/ReactAndroid/src/test/... --config build.threads=$BUILD_THREADS --xml ./reports/buck/all-results-raw.xml
747-
748-
- run:
749-
name: Build JavaScript Bundle for instrumentation tests
750-
working_directory: ~/react-native/packages/react-native
751-
command: node cli.js bundle --max-workers 2 --platform android --dev true --entry-file ReactAndroid/src/androidTest/js/TestBundle.js --bundle-output ReactAndroid/src/androidTest/assets/AndroidTestBundle.js
752-
753-
- run:
754-
name: Build Tests - Android Instrumentation Tests with Buck
755-
# Here, just build the instrumentation tests. There is a known issue with installing the APK to android-21+ emulator.
756-
command: |
757-
if [[ ! -e packages/react-native/ReactAndroid/src/androidTest/assets/AndroidTestBundle.js ]]; then
758-
echo "JavaScript bundle missing, cannot run instrumentation tests. Verify Build JavaScript Bundle step completed successfully."; exit 1;
759-
fi
760-
source scripts/android-setup.sh && NO_BUCKD=1 scripts/retry3 timeout 300 buck build packages/react-native/ReactAndroid/src/androidTest/buck-runner:instrumentation-tests --config build.threads=$BUILD_THREADS
761-
762-
- run:
763-
name: Collect Test Results
764-
command: |
765-
find . -type f -regex ".*/build/test-results/debug/.*xml" -exec cp {} ./reports/build/ \;
766-
find . -type f -regex ".*/outputs/androidTest-results/connected/.*xml" -exec cp {} ./reports/outputs/ \;
767-
find . -type f -regex ".*/buck-out/gen/packages/react-native/ReactAndroid/src/test/.*/.*xml" -exec cp {} ./reports/buck/ \;
768-
if [ -f ~/react-native/reports/buck/all-results-raw.xml ]; then
769-
~/react-native/scripts/circleci/buckToJunit/buckToJunit.sh ~/react-native/reports/buck/all-results-raw.xml ~/react-native/reports/junit/results.xml
770-
fi
771-
when: always
772-
773-
- store_test_results:
774-
path: ./reports/junit
775-
776722
# -------------------------
777723
# JOBS: Test Android
778724
# -------------------------
@@ -1667,7 +1613,6 @@ workflows:
16671613
architecture: ["NewArch", "OldArch"]
16681614
jsengine: ["Hermes", "JSC"]
16691615
flavor: ["Debug", "Release"]
1670-
- test_buck
16711616
- test_ios_template:
16721617
requires:
16731618
- build_npm_package

scripts/buck/buck_fetch.sh

Lines changed: 0 additions & 53 deletions
This file was deleted.

scripts/buck/download-kotlin-compiler-with-buck.sh

Lines changed: 0 additions & 12 deletions
This file was deleted.

scripts/circleci/buckToJunit/buckToJunit.sh

Lines changed: 0 additions & 25 deletions
This file was deleted.

scripts/circleci/buckToJunit/buckToJunit.xsl

Lines changed: 0 additions & 58 deletions
This file was deleted.

tools/build_defs/apple/config_utils_defs.bzl

Lines changed: 0 additions & 12 deletions
This file was deleted.

tools/build_defs/apple/fb_apple_asset_catalog.bzl

Lines changed: 0 additions & 7 deletions
This file was deleted.

tools/build_defs/apple/fb_apple_bundle.bzl

Lines changed: 0 additions & 7 deletions
This file was deleted.

tools/build_defs/apple/fb_apple_test.bzl

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)