Move dumpOpcodeStats() to jsi::Instrumentation, remove IHermesExtra (#53475)

Summary:
Pull Request resolved: #53475

This is cleanup of IHermesExtra. Move the last method in IHermesExtra,
dumpOpcodeStats(), to jsi::Instrumentation, since other profile stats
dumping methods live in that interface as well.

Changelog: [Internal]

Reviewed By: tsaichien

Differential Revision: D81087047

fbshipit-source-id: e145aafea7459a161fca04ffc30f0838ee6c03c6

Author: lavenzg

packages/react-native/ReactCommon/jsi/jsi/decorator.h

@@ -516,6 +516,10 @@ class RuntimeDecorator : public Base, private jsi::Instrumentation {
         .writeBasicBlockProfileTraceToFile(fileName);
   }
 
+  void dumpOpcodeStats(std::ostream& os) const override {
+    const_cast<Plain&>(plain()).instrumentation().dumpOpcodeStats(os);
+  }
+
   /// Dump external profiler symbols to the given file name.
   void dumpProfilerSymbolsToFile(const std::string& fileName) const override {
     const_cast<Plain&>(plain()).instrumentation().dumpProfilerSymbolsToFile(

packages/react-native/ReactCommon/jsi/jsi/instrumentation.h

@@ -121,6 +121,9 @@ class JSI_EXPORT Instrumentation {
   virtual void writeBasicBlockProfileTraceToFile(
       const std::string& fileName) const = 0;
 
+  /// Write the opcode stats to the given stream.
+  virtual void dumpOpcodeStats(std::ostream& os) const = 0;
+
   /// Dump external profiler symbols to the given file name.
   virtual void dumpProfilerSymbolsToFile(const std::string& fileName) const = 0;
 };

packages/react-native/ReactCommon/jsi/jsi/jsi.cpp

@@ -334,6 +334,10 @@ Instrumentation& Runtime::instrumentation() {
       std::abort();
     }
 
+    void dumpOpcodeStats(std::ostream&) const override {
+      std::abort();
+    }
+
     void dumpProfilerSymbolsToFile(const std::string&) const override {
       std::abort();
     }