reuse container and label, too

Author: shirakaba

packages/react-native/React/CoreModules/RCTDevLoadingView.mm

@@ -117,25 +117,26 @@ - (void)showMessage:(NSString *)message color:(UIColor *)color backgroundColor:(
       self->_window = [[UIWindow alloc] initWithWindowScene:mainWindow.windowScene];
       self->_window.windowLevel = UIWindowLevelStatusBar + 1;
       self->_window.rootViewController = [UIViewController new];
+
+      self->_container = [[UIView alloc] init];
+      self->_container.translatesAutoresizingMaskIntoConstraints = NO;
+      UITapGestureRecognizer *tapGesture = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(hide)];
+      [self->_container addGestureRecognizer:tapGesture];
+      self->_container.userInteractionEnabled = YES;
+
+      self->_label = [[UILabel alloc] init];
+      self->_label.translatesAutoresizingMaskIntoConstraints = NO;
+      self->_label.font = [UIFont monospacedDigitSystemFontOfSize:12.0 weight:UIFontWeightRegular];
+      self->_label.textAlignment = NSTextAlignmentCenter;
+
+      [self->_window.rootViewController.view addSubview:self->_container];
+      [self->_container addSubview:self->_label];
     }
 
-    self->_container = [[UIView alloc] init];
     self->_container.backgroundColor = backgroundColor;
-    self->_container.translatesAutoresizingMaskIntoConstraints = NO;
-    UITapGestureRecognizer *tapGesture = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(hide)];
-    [self->_container addGestureRecognizer:tapGesture];
-    self->_container.userInteractionEnabled = YES;
-
-    self->_label = [[UILabel alloc] init];
-    self->_label.translatesAutoresizingMaskIntoConstraints = NO;
-    self->_label.font = [UIFont monospacedDigitSystemFontOfSize:12.0 weight:UIFontWeightRegular];
-    self->_label.textAlignment = NSTextAlignmentCenter;
     self->_label.textColor = color;
     self->_label.text = message;
 
-    [self->_window.rootViewController.view addSubview:self->_container];
-    [self->_container addSubview:self->_label];
-
     CGFloat topSafeAreaHeight = mainWindow.safeAreaInsets.top;
     CGFloat height = topSafeAreaHeight + 25;
     self->_window.frame = CGRectMake(0, 0, mainWindow.frame.size.width, height);