Skip to content

Commit a70354d

Browse files
Apply lint updates from buildifier in xplat
Summary: In D37873933, we update the buildifier binaries, which apply some minor changes to existing lint. Specifically, entries are now properly sorted. Update the files in xplat such that updating buildifier does not cause lint changes in users diffs. drop-conflicts allow_many_files #nocancel #forcetdhashing (Note: this ignores all push blocking failures!) Reviewed By: d16r Differential Revision: D37873936 fbshipit-source-id: f31d9c50d64ae99f99298977b471bf13e7ed5262
1 parent a67360b commit a70354d

File tree

5 files changed

+7
-7
lines changed
  • ReactAndroid/src/main
    • libraries
      • fbjni
      • soloader/java/com/facebook/soloader
    • third-party/kotlin
  • packages/react-native-codegen

5 files changed

+7
-7
lines changed

BUCK

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ fb_native.genrule(
5757
) + [
5858
react_native_root_target("packages/rn-tester:nativecomponent-srcs"),
5959
],
60-
labels = ["uses_hg"],
61-
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
6260
out = "schema-rncore.json",
61+
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
62+
labels = ["uses_hg"],
6363
)
6464

6565
rn_codegen_components(

ReactAndroid/src/main/libraries/fbjni/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
22

33
fb_native.android_library(
44
name = "java",
5+
visibility = ["PUBLIC"],
56
exported_deps = [
67
":fbjni-binary",
78
],
8-
visibility = ["PUBLIC"],
99
)
1010

1111
fb_native.android_prebuilt_aar(

ReactAndroid/src/main/libraries/soloader/java/com/facebook/soloader/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
22

33
fb_native.android_library(
44
name = "soloader",
5+
visibility = ["PUBLIC"],
56
exported_deps = [
67
":annotation-binary",
78
":nativeloader-binary",
89
":soloader-binary",
910
],
10-
visibility = ["PUBLIC"],
1111
)
1212

1313
fb_native.prebuilt_jar(

ReactAndroid/src/main/third-party/kotlin/BUCK

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ fb_native.remote_file(
8383

8484
fb_native.genrule(
8585
name = "kotlin-compiler-download",
86-
type = "copy",
8786
srcs = [
8887
":annotations-13.0.jar",
8988
":kotlin-annotation-processing.jar",
@@ -94,9 +93,10 @@ fb_native.genrule(
9493
":kotlin-stdlib.jar",
9594
":trove4j.jar",
9695
],
96+
out = "kotlin-compiler-out",
9797
cmd = "mkdir ${OUT} && cp ${SRCS} ${OUT}",
9898
cmd_exe = "@powershell -Command Copy-Item '${SRCS}' '${OUT}'",
99-
out = "kotlin-compiler-out",
99+
type = "copy",
100100
)
101101

102102
fb_native.remote_file(

packages/react-native-codegen/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ fb_native.genrule(
1717
"**/e2e/__test_fixtures__/modules/Native*.js",
1818
],
1919
),
20-
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
2120
out = "schema-codegen_tests.json",
21+
cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
2222
)
2323

2424
rn_codegen_components(

0 commit comments

Comments
 (0)