Skip to content

Commit c4325c3

Browse files
cortinicofacebook-github-bot
authored andcommitted
Fix broken Modal OSS E2E test due to createNewDialog setter (#52341)
Summary: Pull Request resolved: #52341 The setter for `createNewDialog` is now wrong (after D76834213). If the `createNewDialog` has been set to `true` by any other field, we should respect it and not set it to true/false regardless (only considering the `isEdgeToEdgeFeatureFlagOn`) property. This fixes it. Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D77539533 fbshipit-source-id: a1deaf1f1b856895304e8b73fa5d0c0367e677af
1 parent 73e5132 commit c4325c3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@ public class ReactModalHostView(context: ThemedReactContext) :
8888
get() = field || isEdgeToEdgeFeatureFlagOn
8989
set(value) {
9090
field = value
91-
createNewDialog = !isEdgeToEdgeFeatureFlagOn
91+
createNewDialog = createNewDialog || !isEdgeToEdgeFeatureFlagOn
9292
}
9393

9494
public var navigationBarTranslucent: Boolean = false
9595
get() = field || isEdgeToEdgeFeatureFlagOn
9696
set(value) {
9797
field = value
98-
createNewDialog = !isEdgeToEdgeFeatureFlagOn
98+
createNewDialog = createNewDialog || !isEdgeToEdgeFeatureFlagOn
9999
}
100100

101101
public var animationType: String? = null

0 commit comments

Comments
 (0)