Add comments and separate pods/xcode autolinking.json loading

Author: kitten

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js

@@ -100,27 +100,34 @@ function cleanupEmptyFilesAndFolders(filepath /*: string */) {
 function readGeneratedAutolinkingOutput(
   baseOutputPath /*: string */,
 ) /*: $FlowFixMe */ {
-  const outputPathCandidates = [
-    // The `outputDir` may not be set correctly if it's set to the a temporary output directory
-    process.env.RCT_SCRIPT_OUTPUT_DIR,
-    // NOTE: Generated by scripts/cocoapods/autolinking.rb in list_native_modules (called by use_native_modules)
-    baseOutputPath,
-  ];
-  for (const outputPathCandidate of outputPathCandidates) {
-    if (outputPathCandidate != null && outputPathCandidate.length > 0) {
-      const autolinkingGeneratedPath = path.resolve(
-        outputPathCandidate,
-        'build/generated/autolinking/autolinking.json',
-      );
-      if (fs.existsSync(autolinkingGeneratedPath)) {
-        // $FlowFixMe[unsupported-syntax]
-        return require(autolinkingGeneratedPath);
-      }
-      codegenLog(
-        `Could not find generated autolinking output at: ${autolinkingGeneratedPath}`,
-      );
+  // When run from Xcode, the generated file can be found via `RCT_SCRIPT_OUTPUT_DIR` consistently
+  if (process.env.RCT_SCRIPT_OUTPUT_DIR) {
+    const xcodeAutolinkingGeneratedPath = path.resolve(
+      process.env.RCT_SCRIPT_OUTPUT_DIR,
+      'build/generated/autolinking/autolinking.json',
+    );
+    if (fs.existsSync(xcodeAutolinkingGeneratedPath)) {
+      // $FlowFixMe[unsupported-syntax]
+      return require(xcodeAutolinkingGeneratedPath);
     }
+    codegenLog(
+      `Could not find generated autolinking output at: ${xcodeAutolinkingGeneratedPath}`,
+    );
   }
+
+  // Otherwise, we expect to find it in the output path iself, when it's been generated in Cocoapods
+  const podsAutolinkingGeneratedPath = path.resolve(
+    baseOutputPath,
+    'build/generated/autolinking/autolinking.json',
+  );
+  if (fs.existsSync(podsAutolinkingGeneratedPath)) {
+    // $FlowFixMe[unsupported-syntax]
+    return require(podsAutolinkingGeneratedPath);
+  }
+  codegenLog(
+    `Could not find generated autolinking output at: ${podsAutolinkingGeneratedPath}`,
+  );
+
   return null;
 }