Introduce DefaultReactHostDelegate (#37565)

Summary:
Pull Request resolved: #37565

Introduce DefaultReactHostDelegate class that will be used to simplify creation of ReactHostDelegate in React Native Android

changelog: [internal] internal

Reviewed By: cortinico, philIip

Differential Revision: D45665528

fbshipit-source-id: 154f4a2f0916c6f1cb846bc052a86dfc72f04dd7

Author: mdvacca

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/BindingsInstaller.kt

@@ -13,7 +13,7 @@ import com.facebook.proguard.annotations.DoNotStripAny
 import com.facebook.soloader.SoLoader
 
 @DoNotStripAny
-abstract class BindingsInstaller(@field:DoNotStrip private val mHybridData: HybridData) {
+abstract class BindingsInstaller(@field:DoNotStrip private val mHybridData: HybridData?) {
   companion object {
     init {
       SoLoader.loadLibrary("rninstance")

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/ReactHostDelegate.kt

@@ -32,7 +32,7 @@ interface ReactHostDelegate {
 
   fun getTurboModuleManagerDelegate(context: ReactApplicationContext): TurboModuleManagerDelegate
 
-  fun handleInstanceException(e: Exception)
+  fun handleInstanceException(error: Exception)
 
   fun getReactNativeConfig(context: ReactContext): ReactNativeConfig
 
@@ -46,14 +46,14 @@ interface ReactHostDelegate {
       private val turboModuleManagerDelegate:
           (context: ReactApplicationContext) -> TurboModuleManagerDelegate,
       private val reactNativeConfig: ReactNativeConfig = ReactNativeConfig.DEFAULT_CONFIG,
-      private val exceptionHandler: (Exception) -> Unit = {}
+      private val exceptionHandler: (error: Exception) -> Unit = {}
   ) : ReactHostDelegate {
 
     override fun getTurboModuleManagerDelegate(context: ReactApplicationContext) =
         turboModuleManagerDelegate(context)
 
     override fun getReactNativeConfig(context: ReactContext) = reactNativeConfig
 
-    override fun handleInstanceException(e: Exception) = exceptionHandler(e)
+    override fun handleInstanceException(error: Exception) = exceptionHandler(error)
   }
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridgeless/hermes/HermesInstance.kt

@@ -12,7 +12,7 @@ import com.facebook.jni.annotations.DoNotStrip
 import com.facebook.react.bridgeless.JSEngineInstance
 import com.facebook.soloader.SoLoader
 
-class HermesInstance() : JSEngineInstance(initHybrid()!!) {
+class HermesInstance : JSEngineInstance(initHybrid()!!) {
 
   companion object {
     @JvmStatic @DoNotStrip protected external fun initHybrid(): HybridData?

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultBindingsInstaller.kt

@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.defaults
+
+import com.facebook.react.bridgeless.BindingsInstaller
+import com.facebook.react.common.annotations.UnstableReactNativeAPI
+
+@UnstableReactNativeAPI class DefaultBindingsInstaller : BindingsInstaller(null) {}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHostDelegate.kt

@@ -0,0 +1,41 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.defaults
+
+import com.facebook.react.ReactPackage
+import com.facebook.react.bridge.JSBundleLoader
+import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.bridge.ReactContext
+import com.facebook.react.bridgeless.BindingsInstaller
+import com.facebook.react.bridgeless.JSEngineInstance
+import com.facebook.react.bridgeless.ReactHostDelegate
+import com.facebook.react.bridgeless.hermes.HermesInstance
+import com.facebook.react.common.annotations.UnstableReactNativeAPI
+import com.facebook.react.fabric.ReactNativeConfig
+import com.facebook.react.turbomodule.core.TurboModuleManagerDelegate
+
+@UnstableReactNativeAPI
+class DefaultReactHostDelegate(
+    override val jSMainModulePath: String,
+    override val jSBundleLoader: JSBundleLoader,
+    override val reactPackages: List<ReactPackage> = emptyList(),
+    override val jSEngineInstance: JSEngineInstance = HermesInstance(),
+    override val bindingsInstaller: BindingsInstaller = DefaultBindingsInstaller(),
+    private val turboModuleManagerDelegate:
+        (context: ReactApplicationContext) -> TurboModuleManagerDelegate,
+    private val reactNativeConfig: ReactNativeConfig = ReactNativeConfig.DEFAULT_CONFIG,
+    private val exceptionHandler: (Exception) -> Unit = {}
+) : ReactHostDelegate {
+
+  override fun getTurboModuleManagerDelegate(context: ReactApplicationContext) =
+      turboModuleManagerDelegate(context)
+
+  override fun getReactNativeConfig(context: ReactContext) = reactNativeConfig
+
+  override fun handleInstanceException(error: Exception) = exceptionHandler(error)
+}

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridgeless/ReactHostDelegateTest.kt

@@ -7,10 +7,10 @@
 
 package com.facebook.react.bridgeless
 
-import com.facebook.react.ReactPackage
 import com.facebook.react.bridge.JSBundleLoader
+import com.facebook.react.bridgeless.hermes.HermesInstance
 import com.facebook.react.common.annotations.UnstableReactNativeAPI
-import com.facebook.react.fabric.ReactNativeConfig
+import com.facebook.react.defaults.DefaultReactHostDelegate
 import com.facebook.react.turbomodule.core.TurboModuleManagerDelegate
 import com.facebook.testutils.shadows.ShadowSoLoader
 import org.assertj.core.api.Assertions.assertThat
@@ -25,28 +25,23 @@ import org.robolectric.annotation.Config
 @Config(shadows = [ShadowSoLoader::class])
 class ReactHostDelegateTest {
 
-  /** Mock test for ReactInstanceDelegate, used to setup the process to create a stable API */
+  /**
+   * Mock test for {@link DefaultReactHostDelegate}, used to setup the process to create a stable
+   * API
+   */
   @Test
-  fun testReactInstanceDelegateCreation() {
+  fun testDefaultReactHostDelegateCreation() {
     val jsBundleLoader: JSBundleLoader = Mockito.mock(JSBundleLoader::class.java)
-    val reactPackage: ReactPackage = Mockito.mock(ReactPackage::class.java)
-    val bindingsInstallerMock: BindingsInstaller = Mockito.mock(BindingsInstaller::class.java)
     val turboModuleManagerDelegateMock: TurboModuleManagerDelegate =
         Mockito.mock(TurboModuleManagerDelegate::class.java)
-    val jsEngineInstanceMock: JSEngineInstance = Mockito.mock(JSEngineInstance::class.java)
-    val reactNativeConfigMock: ReactNativeConfig = Mockito.mock(ReactNativeConfig::class.java)
-    val reactPackages = listOf(reactPackage)
+    val hermesInstance: JSEngineInstance = Mockito.mock(HermesInstance::class.java)
     val jsMainModulePathMocked = "mockedJSMainModulePath"
     val delegate =
-        ReactHostDelegate.ReactHostDelegateBase(
-            jsMainModulePathMocked,
+        DefaultReactHostDelegate(
+            jSMainModulePath = jsMainModulePathMocked,
             jSBundleLoader = jsBundleLoader,
-            reactPackages = reactPackages,
-            bindingsInstaller = bindingsInstallerMock,
-            jSEngineInstance = jsEngineInstanceMock,
-            reactNativeConfig = reactNativeConfigMock,
-            turboModuleManagerDelegate = { turboModuleManagerDelegateMock },
-            exceptionHandler = {})
+            jSEngineInstance = hermesInstance,
+            turboModuleManagerDelegate = { turboModuleManagerDelegateMock })
 
     assertThat(delegate.jSMainModulePath).isEqualTo(jsMainModulePathMocked)
   }