Remove experimental notice from V2 API snapshot and build by default (#52301)

Summary:
Pull Request resolved: #52301

Readying for imminent productionisation.

Changelog: [Internal]

Reviewed By: j-piasecki

Differential Revision: D77386064

fbshipit-source-id: 2769545eace4e6c09da0b2f0f34cf74b2fdcb730

Author: huntie

.github/actions/build-npm-package/action.yml

@@ -129,7 +129,7 @@ runs:
       run: yarn build
     - name: Build types
       shell: bash
-      run: yarn build-types
+      run: yarn build-types --skip-snapshot
     # Continue with publish steps
     - name: Set npm credentials
       if: ${{ inputs.release-type == 'release' ||

.github/actions/lint/action.yml

@@ -49,7 +49,7 @@ runs:
       run: yarn run lint-markdown
     - name: Build types
       shell: bash
-      run: yarn build-types
+      run: yarn build-types --skip-snapshot
     - name: Run typescript check of generated types
       shell: bash
       run: yarn test-generated-typescript

.github/workflows/publish-bumped-packages.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Build packages
         run: yarn build
       - name: Build types
-        run: yarn build-types
+        run: yarn build-types --skip-snapshot
       - name: Set NPM auth token
         run: echo "//registry.npmjs.org/:_authToken=$GHA_NPM_TOKEN" > ~/.npmrc
       - name: Find and publish all bumped packages

scripts/build-types/README.md

@@ -11,7 +11,7 @@ Specifically, it reduces the runtime JavaScript API of `react-native` into two o
 - **Generated TypeScript types**\
 Public user types for react-native, shipped to npm\
 `packages/react-native/types_generated/`
-- **‌Public API snapshot (experimental)**\
+- **‌Public API snapshot**\
 Snapshot file of the public API shape, used by maintainers\
 `packages/react-native/ReactNativeApi.d.ts`
 
@@ -29,11 +29,11 @@ Snapshot file of the public API shape, used by maintainers\
 > API snapshot generation is currently **experimental**, and will be folded into the default behaviour when ready.
 
 ```sh
-# Build types
-yarn build-types
+# Build types + API snapshot
+yarn build-types [--validate]
 
-# Build types + API snapshot (experimental)
-yarn build-types --withSnapshot [--validate]
+# Build types without API snapshot
+yarn build-types --skip-snapshot
 ```
 
 #### Configuration
@@ -54,7 +54,7 @@ Directory providing TypeScript user types for the `react-native` package, distri
 - Preserves doc comments.
 - Preserves source file names (for go to definition).
 
-### Public API snapshot (experimental)
+### Public API snapshot
 
 `ReactNative.d.ts`
 

scripts/build-types/index.js

@@ -20,7 +20,7 @@ const config = {
     debug: {type: 'boolean'},
     'debug-version-annotations': {type: 'boolean'},
     help: {type: 'boolean'},
-    withSnapshot: {type: 'boolean'},
+    'skip-snapshot': {type: 'boolean'},
     validate: {type: 'boolean'},
   },
 };
@@ -31,7 +31,7 @@ async function main() {
       debug: debugEnabled,
       'debug-version-annotations': debugVersionAnnotations,
       help,
-      withSnapshot,
+      'skip-snapshot': skipSnapshot,
       validate,
     },
     /* $FlowFixMe[incompatible-call] Natural Inference rollout. See
@@ -49,22 +49,14 @@ async function main() {
     --debug-version-annotations
                       Outputs debug info alongside versioned type hashes as
                       part of the API snapshot contents.
-    --withSnapshot    [Experimental] Include API snapshot generation.
+    --skip-snapshot   Skip API snapshot generation.
     --validate        Validate if the current API snapshot on disk is up to
                       date. Exits with an error if differences are detected.
     `);
     process.exitCode = 0;
     return;
   }
 
-  if (validate && !withSnapshot) {
-    console.error(
-      "build-types: '--validate' can only be used with '--withSnapshot'.",
-    );
-    process.exitCode = 2;
-    return;
-  }
-
   if (debugEnabled) {
     debug.enable('build-types:*');
   }
@@ -79,10 +71,9 @@ async function main() {
   );
   await buildGeneratedTypes();
 
-  if (withSnapshot) {
+  if (!skipSnapshot) {
     console.log(
-      styleText(['bold', 'inverse'], ' [Experimental] Building API snapshot ') +
-        '\n',
+      styleText(['bold', 'inverse'], ' Building API snapshot ') + '\n',
     );
     await buildApiSnapshot({validate, debugVersionAnnotations});
   }

scripts/build-types/templates/ReactNativeApi.d.ts-template.js

@@ -19,8 +19,6 @@ function apiSnapshotTemplate(source: string): string {
  * LICENSE file in the root directory of this source tree.
  *
  * ${signedsource.getSigningToken()}
- * @${'nocommit'} EXPERIMENTAL V2 API SNAPSHOT - Continue to use public-api-test.js
- *     until we productionize this format.
  *
  * This file was generated by scripts/build-types/index.js.
  */