Remove unnecessary NativeArgumentsParseException (#53408)

Summary:
Pull Request resolved: #53408

This class is internal + legacy arch so can safely be removed now.
I've replaced the throw/catch site with the superclass of this exception.

Changelog:
[Internal] [Changed] -

Reviewed By: mdvacca

Differential Revision: D80710950

fbshipit-source-id: 96615835588ce409de40d31ee83b82c88d3a07a0

Author: cortinico

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JavaMethodWrapper.kt

@@ -189,7 +189,7 @@ internal class JavaMethodWrapper(
           }
 
       if (jsArgumentsNeeded != parameters.size()) {
-        throw NativeArgumentsParseException(
+        throw JSApplicationCausedNativeException(
             "$traceName got ${parameters.size()} arguments, expected $jsArgumentsNeeded"
         )
       }
@@ -208,7 +208,7 @@ internal class JavaMethodWrapper(
           i++
         }
       } catch (e: UnexpectedNativeTypeException) {
-        throw NativeArgumentsParseException(
+        throw JSApplicationCausedNativeException(
             "${e.message} (constructing arguments for $traceName at argument index ${
               getAffectedRange(
                   jsArgumentsConsumed,
@@ -218,7 +218,7 @@ internal class JavaMethodWrapper(
             e,
         )
       } catch (e: NullPointerException) {
-        throw NativeArgumentsParseException(
+        throw JSApplicationCausedNativeException(
             "${e.message} (constructing arguments for $traceName at argument index ${
               getAffectedRange(
                   jsArgumentsConsumed,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeArgumentsParseException.kt

@@ -44,7 +44,7 @@ class BaseJavaModuleTest {
   private fun findMethod(mname: String, methods: List<JavaModuleWrapper.MethodDescriptor>): Int =
       methods.indexOfFirst({ it.name === mname })
 
-  @Test(expected = NativeArgumentsParseException::class)
+  @Test(expected = JSApplicationCausedNativeException::class)
   fun testCallMethodWithoutEnoughArgs() {
     val methodId = findMethod("regularMethod", methods)
     whenever(arguments.size()).thenReturn(1)