Skip to content

Commit eba38b8

Browse files
rozelefacebook-github-bot
authored andcommitted
Fix DefaultNewArchitectureEntryPoint config validation (#53807)
Summary: Pull Request resolved: #53807 We need to read the values off feature flags before checking them. ## Changelog [Internal] Reviewed By: javache Differential Revision: D82572898 fbshipit-source-id: 09fbc09570c78b41d9c25fb03c5557e390da7cae
1 parent 18cb4ed commit eba38b8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultNewArchitectureEntryPoint.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,17 +120,17 @@ public object DefaultNewArchitectureEntryPoint {
120120
internal fun loadWithFeatureFlags(featureFlags: ReactNativeFeatureFlagsProvider) {
121121
ReactNativeFeatureFlags.override(featureFlags)
122122

123+
privateFabricEnabled = featureFlags.enableFabricRenderer()
124+
privateTurboModulesEnabled = featureFlags.useTurboModules()
125+
privateConcurrentReactEnabled = featureFlags.enableFabricRenderer()
126+
privateBridgelessEnabled = featureFlags.enableBridgelessArchitecture()
127+
123128
val (isValid, errorMessage) =
124129
isConfigurationValid(turboModulesEnabled, fabricEnabled, bridgelessEnabled)
125130
if (!isValid) {
126131
error(errorMessage)
127132
}
128133

129-
privateFabricEnabled = featureFlags.enableFabricRenderer()
130-
privateTurboModulesEnabled = featureFlags.useTurboModules()
131-
privateConcurrentReactEnabled = featureFlags.enableFabricRenderer()
132-
privateBridgelessEnabled = featureFlags.enableBridgelessArchitecture()
133-
134134
DefaultSoLoader.maybeLoadSoLibrary()
135135
}
136136

0 commit comments

Comments
 (0)