Skip to content

Commit eca4d76

Browse files
javachefacebook-github-bot
authored andcommitted
Rollout enableBridgelessArchitectureSoftExceptions (#43485)
Summary: Pull Request resolved: #43485 Already fully rolled out internally. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54804177 fbshipit-source-id: 128822d408b6943f1f1536eb0101c6684cd45106
1 parent 7488dc0 commit eca4d76

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1909,7 +1909,6 @@ public class com/facebook/react/config/ReactFeatureFlags {
19091909
public static field dispatchPointerEvents Z
19101910
public static field enableBridgelessArchitecture Z
19111911
public static field enableBridgelessArchitectureNewCreateReloadDestroy Z
1912-
public static field enableBridgelessArchitectureSoftExceptions Z
19131912
public static field enableClonelessStateProgression Z
19141913
public static field enableCppPropsIteratorSetter Z
19151914
public static field enableEagerRootViewAttachment Z

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,6 @@ public class ReactFeatureFlags {
6666
*/
6767
public static boolean enableBridgelessArchitecture = false;
6868

69-
/**
70-
* Does the bridgeless architecture log soft exceptions. Could be useful for tracking down issues.
71-
*/
72-
public static volatile boolean enableBridgelessArchitectureSoftExceptions = false;
73-
7469
/** Does the bridgeless architecture use the new create/reload/destroy routines */
7570
public static volatile boolean enableBridgelessArchitectureNewCreateReloadDestroy = true;
7671

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import com.facebook.react.bridge.queue.ReactQueueConfiguration;
4949
import com.facebook.react.common.LifecycleState;
5050
import com.facebook.react.common.build.ReactBuildConfig;
51-
import com.facebook.react.config.ReactFeatureFlags;
5251
import com.facebook.react.devsupport.DevSupportManagerBase;
5352
import com.facebook.react.devsupport.DisabledDevSupportManager;
5453
import com.facebook.react.devsupport.InspectorFlags;
@@ -879,16 +878,14 @@ private void raiseSoftException(String method, String message) {
879878

880879
private void raiseSoftException(String method, String message, @Nullable Throwable throwable) {
881880
log(method, message);
882-
if (ReactFeatureFlags.enableBridgelessArchitectureSoftExceptions) {
883-
if (throwable != null) {
884-
ReactSoftExceptionLogger.logSoftException(
885-
TAG, new ReactNoCrashSoftException(method + ": " + message, throwable));
886-
return;
887-
}
888-
881+
if (throwable != null) {
889882
ReactSoftExceptionLogger.logSoftException(
890-
TAG, new ReactNoCrashSoftException(method + ": " + message));
883+
TAG, new ReactNoCrashSoftException(method + ": " + message, throwable));
884+
return;
891885
}
886+
887+
ReactSoftExceptionLogger.logSoftException(
888+
TAG, new ReactNoCrashSoftException(method + ": " + message));
892889
}
893890

894891
private Task<Boolean> callWithExistingReactInstance(

0 commit comments

Comments
 (0)