Skip to content

Commit f53aad7

Browse files
cipolleschicipolleschi
committed
[LOCAL][RN][iOS] Fix CI not finding the RCTTestRunner Symbol
1 parent 7d90103 commit f53aad7

File tree

8 files changed

+23
-61
lines changed

8 files changed

+23
-61
lines changed

‎.github/actions/setup-xcode/action.yml‎

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ inputs:
44
xcode-version:
55
description: 'The xcode version to use'
66
required: false
7-
default: '16.2.0'
7+
default: '16.4.0'
88
platform:
99
description: 'The platform to use. Valid values are: ios, ios-simulator, macos, mac-catalyst, tvos, tvos-simulator, xros, xros-simulator'
1010
required: false
@@ -16,21 +16,3 @@ runs:
1616
uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd
1717
with:
1818
xcode-version: ${{ inputs.xcode-version }}
19-
- name: Setup Platform ${{ inputs.platform }}
20-
if: ${{ inputs.platform != 'macos' && inputs.platform != 'mac-catalyst' }}
21-
shell: bash
22-
run: |
23-
# https://github.com/actions/runner-images/issues/12541
24-
sudo xcodebuild -runFirstLaunch
25-
sudo xcrun simctl list
26-
27-
# Install platform based on the platform
28-
if [[ "${{ inputs.platform }}" == "xros" || "${{ inputs.platform }}" == "xros-simulator" ]]; then
29-
sudo xcodebuild -downloadPlatform visionOS
30-
elif [[ "${{ inputs.platform }}" == "tvos" || "${{ inputs.platform }}" == "tvos-simulator" ]]; then
31-
sudo xcodebuild -downloadPlatform tvOS
32-
else
33-
sudo xcodebuild -downloadPlatform iOS
34-
fi
35-
36-
sudo xcodebuild -runFirstLaunch

‎.github/actions/test-ios-rntester/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ inputs:
66
default: 2.6.10
77
run-unit-tests:
88
description: whether unit tests should run or not.
9-
default: "true"
9+
default: false
1010
flavor:
1111
description: The flavor of the build. Must be one of "Debug", "Release".
1212
default: Debug

‎.github/workflows/prebuild-ios-core.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,6 @@ jobs:
146146
- name: Setup xcode
147147
if: steps.restore-ios-xcframework.outputs.cache-hit != 'true'
148148
uses: ./.github/actions/setup-xcode
149-
with:
150-
xcode-version: '16.2.0'
151149
- name: Yarn Install
152150
if: steps.restore-ios-xcframework.outputs.cache-hit != 'true'
153151
uses: ./.github/actions/yarn-install

‎.github/workflows/prebuild-ios-dependencies.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,6 @@ jobs:
124124
uses: ./.github/actions/setup-node
125125
- name: Setup xcode
126126
uses: ./.github/actions/setup-xcode
127-
with:
128-
xcode-version: '16.1'
129127
- name: Restore XCFramework
130128
id: restore-xcframework
131129
uses: actions/cache/restore@v5

‎.github/workflows/test-hermes-v1-ios.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040

4141
- name: Setup xcode
4242
uses: maxim-lobanov/setup-xcode@v1
43-
with:
44-
xcode-version: 16.4.0
4543

4644
- name: Build iOS with retry
4745
uses: nick-fields/retry@v3

‎packages/rn-tester/Podfile.lock‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
PODS:
22
- FBLazyVector (0.84.0-rc.0)
3-
- hermes-engine (0.15.0):
4-
- hermes-engine/Pre-built (= 0.15.0)
5-
- hermes-engine/Pre-built (0.15.0)
3+
- hermes-engine (250829098.0.5):
4+
- hermes-engine/Pre-built (= 250829098.0.5)
5+
- hermes-engine/Pre-built (250829098.0.5)
66
- MyNativeView (0.84.0-rc.0):
77
- hermes-engine
88
- RCTRequired
@@ -1991,7 +1991,7 @@ EXTERNAL SOURCES:
19911991
:path: "../react-native/Libraries/FBLazyVector"
19921992
hermes-engine:
19931993
:podspec: "../react-native/sdks/hermes-engine/hermes-engine.podspec"
1994-
:tag: hermes-v0.15.0
1994+
:tag: hermes-v250829098.0.5
19951995
MyNativeView:
19961996
:path: NativeComponentExample
19971997
NativeCxxModuleExample:
@@ -2149,7 +2149,7 @@ EXTERNAL SOURCES:
21492149

21502150
SPEC CHECKSUMS:
21512151
FBLazyVector: 60db88825afeddb4b8fac96e70230c12bde0fa8e
2152-
hermes-engine: 938a9cdde5b6f097720af751658786c90769fa30
2152+
hermes-engine: 733c2f53c483de462d6f97993795369152db68d6
21532153
MyNativeView: 06ffd5f7a4c400b471e230dab9920df2ba67bdd1
21542154
NativeCxxModuleExample: 8af5455cac2bdf72402da5ed6a1b445b443b1ebc
21552155
OCMock: 589f2c84dacb1f5aaf6e4cec1f292551fe748e74
@@ -2161,7 +2161,7 @@ SPEC CHECKSUMS:
21612161
React: a5f1b853a4eda5dbea8d01430e322650d7cddfe5
21622162
React-callinvoker: 50627079f30a508a8b5e4cefb71329942e60ebcf
21632163
React-Core: 27574a6d01e033fc2fbde60c0fe8ef4a6ccec121
2164-
React-Core-prebuilt: a4d0e4ba023bf11c14ae79fd57d555ddc9c4e43c
2164+
React-Core-prebuilt: e7fa6227c9298a24b98f641c08b829d484c1bd3b
21652165
React-CoreModules: 26bdba7a4016457ba13a6233565e8e2c55cf7368
21662166
React-cxxreact: 2271ef9b8f53fb159949edaeb0a539d880f1fbde
21672167
React-debug: 003f262a91683df3033fcb0f660b9f071284346f
@@ -2207,7 +2207,7 @@ SPEC CHECKSUMS:
22072207
React-RCTPushNotification: e03bfdae0cdbda626bdb0ab326c6290b5203195c
22082208
React-RCTRuntime: 774642b42ca8533dea31972e761af95053c378b3
22092209
React-RCTSettings: 36efade455b8edbad99b177051be4b40c544981a
2210-
React-RCTTest: 0a978c0ce5be24c5c484ed88d5d92a3b73e0a1b3
2210+
React-RCTTest: 9b1f90df8cae57012145702f0463edd470a1fb29
22112211
React-RCTText: d920aa8f6d55a60d590ae854368a90ff5451f215
22122212
React-RCTVibration: f31a70e15106ed7da934d0c5b4435b0fd872a2d7
22132213
React-rendererconsistency: 8935199fadbd672c9b6bb6e26ab14895e05a1bf7
@@ -2225,7 +2225,7 @@ SPEC CHECKSUMS:
22252225
ReactCodegen: 59fd9793bdb850ddde0063c5d0ab6ea6efa755f5
22262226
ReactCommon: c206b8a681ce20c4652e777a890599ceb3535797
22272227
ReactCommon-Samples: 0f45aab5d3cca4afbf3bb799a552c797a7526200
2228-
ReactNativeDependencies: 76c872a08280a05a5e4434172e891a0ed69342e8
2228+
ReactNativeDependencies: eed00171d9e126191ccf91dd4dbed525792a4c8d
22292229
ScreenshotManager: 58a57c417506cc5a2a16b767fd7d3b480f9673e7
22302230
Yoga: e80453f68a32823bc6074a069aa7318875f00dc1
22312231

‎packages/rn-tester/RCTTest/React-RCTTest.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Pod::Spec.new do |s|
2626
s.platforms = min_supported_versions
2727
s.compiler_flags = '-Wno-nullability-completeness'
2828
s.source = source
29-
s.source_files = podspec_sources("**/*.{h,m,mm}", "**/*.h")
29+
s.source_files = "**/*.{h,m,mm}"
3030
s.preserve_paths = "package.json", "LICENSE", "LICENSE-docs"
3131
s.framework = "XCTest"
3232
s.header_dir = "RCTTest"

‎packages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj‎

Lines changed: 12 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -500,14 +500,10 @@
500500
inputFileListPaths = (
501501
"${PODS_ROOT}/Target Support Files/Pods-RNTester/Pods-RNTester-frameworks-${CONFIGURATION}-input-files.xcfilelist",
502502
);
503-
inputPaths = (
504-
);
505503
name = "[CP] Embed Pods Frameworks";
506504
outputFileListPaths = (
507505
"${PODS_ROOT}/Target Support Files/Pods-RNTester/Pods-RNTester-frameworks-${CONFIGURATION}-output-files.xcfilelist",
508506
);
509-
outputPaths = (
510-
);
511507
runOnlyForDeploymentPostprocessing = 0;
512508
shellPath = /bin/sh;
513509
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNTester/Pods-RNTester-frameworks.sh\"\n";
@@ -543,14 +539,10 @@
543539
inputFileListPaths = (
544540
"${PODS_ROOT}/Target Support Files/Pods-RNTesterIntegrationTests/Pods-RNTesterIntegrationTests-resources-${CONFIGURATION}-input-files.xcfilelist",
545541
);
546-
inputPaths = (
547-
);
548542
name = "[CP] Copy Pods Resources";
549543
outputFileListPaths = (
550544
"${PODS_ROOT}/Target Support Files/Pods-RNTesterIntegrationTests/Pods-RNTesterIntegrationTests-resources-${CONFIGURATION}-output-files.xcfilelist",
551545
);
552-
outputPaths = (
553-
);
554546
runOnlyForDeploymentPostprocessing = 0;
555547
shellPath = /bin/sh;
556548
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNTesterIntegrationTests/Pods-RNTesterIntegrationTests-resources.sh\"\n";
@@ -564,14 +556,10 @@
564556
inputFileListPaths = (
565557
"${PODS_ROOT}/Target Support Files/Pods-RNTesterUnitTests/Pods-RNTesterUnitTests-resources-${CONFIGURATION}-input-files.xcfilelist",
566558
);
567-
inputPaths = (
568-
);
569559
name = "[CP] Copy Pods Resources";
570560
outputFileListPaths = (
571561
"${PODS_ROOT}/Target Support Files/Pods-RNTesterUnitTests/Pods-RNTesterUnitTests-resources-${CONFIGURATION}-output-files.xcfilelist",
572562
);
573-
outputPaths = (
574-
);
575563
runOnlyForDeploymentPostprocessing = 0;
576564
shellPath = /bin/sh;
577565
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNTesterUnitTests/Pods-RNTesterUnitTests-resources.sh\"\n";
@@ -619,14 +607,10 @@
619607
inputFileListPaths = (
620608
"${PODS_ROOT}/Target Support Files/Pods-RNTesterIntegrationTests/Pods-RNTesterIntegrationTests-frameworks-${CONFIGURATION}-input-files.xcfilelist",
621609
);
622-
inputPaths = (
623-
);
624610
name = "[CP] Embed Pods Frameworks";
625611
outputFileListPaths = (
626612
"${PODS_ROOT}/Target Support Files/Pods-RNTesterIntegrationTests/Pods-RNTesterIntegrationTests-frameworks-${CONFIGURATION}-output-files.xcfilelist",
627613
);
628-
outputPaths = (
629-
);
630614
runOnlyForDeploymentPostprocessing = 0;
631615
shellPath = /bin/sh;
632616
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNTesterIntegrationTests/Pods-RNTesterIntegrationTests-frameworks.sh\"\n";
@@ -662,14 +646,10 @@
662646
inputFileListPaths = (
663647
"${PODS_ROOT}/Target Support Files/Pods-RNTester/Pods-RNTester-resources-${CONFIGURATION}-input-files.xcfilelist",
664648
);
665-
inputPaths = (
666-
);
667649
name = "[CP] Copy Pods Resources";
668650
outputFileListPaths = (
669651
"${PODS_ROOT}/Target Support Files/Pods-RNTester/Pods-RNTester-resources-${CONFIGURATION}-output-files.xcfilelist",
670652
);
671-
outputPaths = (
672-
);
673653
runOnlyForDeploymentPostprocessing = 0;
674654
shellPath = /bin/sh;
675655
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNTester/Pods-RNTester-resources.sh\"\n";
@@ -705,14 +685,10 @@
705685
inputFileListPaths = (
706686
"${PODS_ROOT}/Target Support Files/Pods-RNTesterUnitTests/Pods-RNTesterUnitTests-frameworks-${CONFIGURATION}-input-files.xcfilelist",
707687
);
708-
inputPaths = (
709-
);
710688
name = "[CP] Embed Pods Frameworks";
711689
outputFileListPaths = (
712690
"${PODS_ROOT}/Target Support Files/Pods-RNTesterUnitTests/Pods-RNTesterUnitTests-frameworks-${CONFIGURATION}-output-files.xcfilelist",
713691
);
714-
outputPaths = (
715-
);
716692
runOnlyForDeploymentPostprocessing = 0;
717693
shellPath = /bin/sh;
718694
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNTesterUnitTests/Pods-RNTesterUnitTests-frameworks.sh\"\n";
@@ -943,14 +919,18 @@
943919
IPHONEOS_DEPLOYMENT_TARGET = 15.1;
944920
MTL_ENABLE_DEBUG_INFO = YES;
945921
ONLY_ACTIVE_ARCH = YES;
946-
OTHER_CFLAGS = "$(inherited)";
922+
OTHER_CFLAGS = (
923+
"$(inherited)",
924+
"-DRCT_REMOVE_LEGACY_ARCH=1",
925+
);
947926
OTHER_CPLUSPLUSFLAGS = (
948927
"$(OTHER_CFLAGS)",
949928
"-DFOLLY_NO_CONFIG",
950929
"-DFOLLY_MOBILE=1",
951930
"-DFOLLY_USE_LIBCPP=1",
952931
"-DFOLLY_CFG_NO_COROUTINES=1",
953932
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
933+
"-DRCT_REMOVE_LEGACY_ARCH=1",
954934
);
955935
OTHER_LDFLAGS = (
956936
"-ObjC",
@@ -959,6 +939,7 @@
959939
REACT_NATIVE_PATH = "${PODS_ROOT}/../../react-native";
960940
SDKROOT = iphoneos;
961941
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
942+
SWIFT_ENABLE_EXPLICIT_MODULES = NO;
962943
USE_HERMES = true;
963944
WARNING_CFLAGS = (
964945
"-Wextra",
@@ -1036,21 +1017,26 @@
10361017
);
10371018
IPHONEOS_DEPLOYMENT_TARGET = 15.1;
10381019
MTL_ENABLE_DEBUG_INFO = NO;
1039-
OTHER_CFLAGS = "$(inherited)";
1020+
OTHER_CFLAGS = (
1021+
"$(inherited)",
1022+
"-DRCT_REMOVE_LEGACY_ARCH=1",
1023+
);
10401024
OTHER_CPLUSPLUSFLAGS = (
10411025
"$(OTHER_CFLAGS)",
10421026
"-DFOLLY_NO_CONFIG",
10431027
"-DFOLLY_MOBILE=1",
10441028
"-DFOLLY_USE_LIBCPP=1",
10451029
"-DFOLLY_CFG_NO_COROUTINES=1",
10461030
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
1031+
"-DRCT_REMOVE_LEGACY_ARCH=1",
10471032
);
10481033
OTHER_LDFLAGS = (
10491034
"-ObjC",
10501035
"-lc++",
10511036
);
10521037
REACT_NATIVE_PATH = "${PODS_ROOT}/../../react-native";
10531038
SDKROOT = iphoneos;
1039+
SWIFT_ENABLE_EXPLICIT_MODULES = NO;
10541040
USE_HERMES = true;
10551041
VALIDATE_PRODUCT = YES;
10561042
WARNING_CFLAGS = (

0 commit comments

Comments
 (0)