Fix border disappearing when only one edge is transparent (#47940)

Summary:
Pull Request resolved: #47940

Fixes #47905

Border was disappearing when only one edge had an alpha of 0. This was due to clipping conditional

Changelog: [Internal]

Reviewed By: shwanton, NickGerleman

Differential Revision: D66397736

fbshipit-source-id: 8937323ad16e0c6e98a55051f244c08ef54c96eb

Author: jorge-cab

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/BorderDrawable.kt

@@ -675,10 +675,10 @@ internal class BorderDrawable(
 
     val borderWidth = computeBorderInsets()
 
-    // Clip border ONLY if its color is non transparent
-    if (Color.alpha(computedBorderColors.left) != 0 &&
-        Color.alpha(computedBorderColors.top) != 0 &&
-        Color.alpha(computedBorderColors.right) != 0 &&
+    // Clip border ONLY if at least one edge is non-transparent
+    if (Color.alpha(computedBorderColors.left) != 0 ||
+        Color.alpha(computedBorderColors.top) != 0 ||
+        Color.alpha(computedBorderColors.right) != 0 ||
         Color.alpha(computedBorderColors.bottom) != 0) {
       innerClipTempRectForBorderRadius?.top =
           innerClipTempRectForBorderRadius?.top?.plus(borderWidth.top) ?: 0f

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java

@@ -646,13 +646,13 @@ private void updatePath() {
       colorTop = colorBlockStart;
     }
 
-    // Clip border ONLY if its color is non transparent
+    // Clip border ONLY if at least one edge is non-transparent
     float pathAdjustment = 0f;
     if (Color.alpha(colorLeft) != 0
-        && Color.alpha(colorTop) != 0
-        && Color.alpha(colorRight) != 0
-        && Color.alpha(colorBottom) != 0
-        && Color.alpha(borderColor) != 0) {
+        || Color.alpha(colorTop) != 0
+        || Color.alpha(colorRight) != 0
+        || Color.alpha(colorBottom) != 0
+        || Color.alpha(borderColor) != 0) {
 
       mInnerClipTempRectForBorderRadius.top += borderWidth.top;
       mInnerClipTempRectForBorderRadius.bottom -= borderWidth.bottom;