Skip to content

Commit f9cecc5

Browse files
hoxyqfacebook-github-bot
authored andcommitted
fix: correctly assign name to both begin and end events for measures (#53588)
Summary: Pull Request resolved: #53588 # Changelog: [Internal] Since the `name` was already moved for the begin event, there is nothing to be moved for `end` event. Instead, we will be creating a copy for the `begin` event. This was actually affecting some entries on a timeline, like component triggers (yellow ones). Reviewed By: vzaidman Differential Revision: D81589847 fbshipit-source-id: 3b7d801d3429217ce279ed7de41c40c3838a5f37
1 parent 8d84521 commit f9cecc5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
445445

446446
events.emplace_back(TraceEvent{
447447
.id = eventId,
448-
.name = std::move(event.name),
448+
.name = event.name,
449449
.cat = "blink.user_timing",
450450
.ph = 'b',
451451
.ts = event.start,

0 commit comments

Comments
 (0)